lwc

Author: mrginglymus

libraries/lwc/src/basic-tests.js

@@ -21,6 +21,7 @@ import {
   createComponentWithChildrenRerender,
   createComponentWithDifferentViews,
   createComponentWithProperties,
+  createComponentWithoutProperties,
   createComponentWithImperativeEvent,
 } from './components';
 
@@ -135,6 +136,17 @@ describe('basic support', function() {
       const data = wc.str || wc.getAttribute('str');
       expect(data).to.eql('lwc');
     });
+
+    it("will not overwrite unwriteable properties", function () {
+      this.weight = 3;
+      const cmp = createComponentWithoutProperties();
+      scratch.appendChild(cmp);
+      const wc = cmp.shadowRoot.querySelector('ce-without-properties');
+      expect(wc.getAttribute('amethod')).to.eql('method');
+      expect(wc.getAttribute('agetter')).to.eql('getter');
+      expect(wc.getAttribute('areadonly')).to.eql('readonly');
+      expect(wc.innerHTML).to.eql('Success');
+    });
   });
 
   describe('events', function() {

libraries/lwc/src/components.js

@@ -18,6 +18,7 @@
 import 'ce-without-children';
 import 'ce-with-children';
 import 'ce-with-properties';
+import 'ce-without-properties';
 import 'ce-with-event';
 
 import { createElement } from 'lwc';
@@ -27,6 +28,7 @@ import WithChildren from 'x/withChildren';
 import WithChildrenRerender from 'x/withChildrenRerender';
 import WithDifferentViews from 'x/withDifferentViews';
 import WithProperties from 'x/withProperties';
+import WithoutProperties from 'x/withoutProperties';
 import WithImperativeEvent from 'x/withImperativeEvent';
 import WithDeclarativeEvent from 'x/withDeclarativeEvent';
 
@@ -50,6 +52,10 @@ export function createComponentWithProperties() {
   return createElement('x-with-properties', { is: WithProperties });
 }
 
+export function createComponentWithoutProperties() {
+  return createElement('x-without-properties', { is: WithoutProperties });
+}
+
 export function createComponentWithImperativeEvent() {
   return createElement('x-with-imperative-event', { is: WithImperativeEvent });
 }

libraries/lwc/src/modules/x/withoutProperties/withoutProperties.html

@@ -0,0 +1,7 @@
+<template>
+    <ce-without-properties lwc:external
+        amethod={method}
+        agetter={getter}
+        areadonly={readonly}
+    ></ce-without-properties>
+</template>

libraries/lwc/src/modules/x/withoutProperties/withoutProperties.js

@@ -0,0 +1,7 @@
+import { LightningElement } from "lwc";
+
+export default class extends LightningElement {
+    method = 'method';
+    readonly = 'readonly';
+    getter = 'getter';
+}

libraries/vue/src/basic-tests.js

@@ -148,7 +148,7 @@ describe("basic support", function() {
       expect(data).to.eql("Vue");
     });
 
-    it('will not overwrite unwriteable properties', function () {
+    it("will not overwrite unwriteable properties", function () {
      const app = createApp(ComponentWithoutProperties);
      app.mount(scratch);
      const wc = scratch.querySelector('#wc');