Solid

Author: mrginglymus

libraries/solid/src/basic-tests.js

@@ -23,6 +23,7 @@ import {
   ComponentWithChildrenRerender,
   ComponentWithDifferentViews,
   ComponentWithProperties,
+  ComponentWithoutProperties,
   ComponentWithUnregistered,
   ComponentWithImperativeEvent,
   ComponentWithDeclarativeEvent
@@ -110,6 +111,16 @@ describe("basic support", function() {
       expect(data).to.eql("Solid");
     });
 
+    it("will not overwrite unwriteable properties", function () {
+      this.weight = 3;
+      let wc;
+      render(() => wc = <ComponentWithoutProperties />, document.body);
+      expect(wc.getAttribute('amethod')).to.eql('method');
+      expect(wc.getAttribute('agetter')).to.eql('getter');
+      expect(wc.getAttribute('areadonly')).to.eql('readonly');
+      expect(wc.innerHTML).to.eql('Success');
+    });
+
     // TODO: Is it the framework's responsibility to check if the underlying
     // property is defined? Or should it just always assume it is and do its
     // usual default behavior? Preact will actually check if it's defined and

libraries/solid/src/components.js

@@ -20,6 +20,7 @@ import { createStore } from "solid-js/store";
 import "ce-without-children";
 import "ce-with-children";
 import "ce-with-properties";
+import "ce-without-properties";
 import "ce-with-event";
 
 export const ComponentWithoutChildren = () => <ce-without-children />;
@@ -63,6 +64,21 @@ export const ComponentWithProperties = () => {
   );
 };
 
+export const ComponentWithoutProperties = () => {
+  const data = {
+    getter: 'getter',
+    method: 'method',
+    readonly: 'readonly',
+  }
+  return (
+    <ce-without-properties
+      attr:agetter={data.getter}
+      attr:amethod={data.method}
+      attr:areadonly={data.readonly}
+    />
+  )
+}
+
 export const ComponentWithUnregistered = () => {
   const data = {
     bool: true,