Fix null handling in getLoadedChunkAsync for paper/spigot 1.21.3/1.21.4

Author: ZockiRR

bukkit-helper-121-3/src/main/java/org/dynmap/bukkit/helper/v121_3/MapChunkCache121_3.java

@@ -38,18 +38,15 @@ public MapChunkCache121_3(GenericChunkCache cc) {
 
     @Override
     protected Supplier<GenericChunk> getLoadedChunkAsync(DynmapChunk chunk) {
-        CompletableFuture<SerializableChunkData> chunkData = CompletableFuture.supplyAsync(() -> {
+        CompletableFuture<Optional<SerializableChunkData>> chunkData = CompletableFuture.supplyAsync(() -> {
             CraftWorld cw = (CraftWorld) w;
             Chunk c = cw.getHandle().getChunkIfLoaded(chunk.x, chunk.z);
-            if (c == null || !c.q) { //!c.loaded
-                return null;
+            if (c == null || !c.q) { // !c.loaded
+                return Optional.empty();
             }
-            return SerializableChunkData.a(cw.getHandle(), c); //SerializableChunkData.copyOf
+            return Optional.of(SerializableChunkData.a(cw.getHandle(), c)); // SerializableChunkData.copyOf
         }, ((CraftServer) Bukkit.getServer()).getServer());
-        return () -> {
-            NBTTagCompound nbt = chunkData.join().a(); // SerializableChunkData.write
-            return parseChunkFromNBT(new NBT.NBTCompound(nbt));
-        };
+        return () -> chunkData.join().map(SerializableChunkData::a).map(NBT.NBTCompound::new).map(this::parseChunkFromNBT).orElse(null); // SerializableChunkData::write
     }
 
     protected GenericChunk getLoadedChunk(DynmapChunk chunk) {

bukkit-helper-121-4/src/main/java/org/dynmap/bukkit/helper/v121_4/MapChunkCache121_4.java

@@ -38,18 +38,15 @@ public MapChunkCache121_4(GenericChunkCache cc) {
 
     @Override
     protected Supplier<GenericChunk> getLoadedChunkAsync(DynmapChunk chunk) {
-        CompletableFuture<SerializableChunkData> chunkData = CompletableFuture.supplyAsync(() -> {
+        CompletableFuture<Optional<SerializableChunkData>> chunkData = CompletableFuture.supplyAsync(() -> {
             CraftWorld cw = (CraftWorld) w;
             Chunk c = cw.getHandle().getChunkIfLoaded(chunk.x, chunk.z);
-            if (c == null || !c.q) { //!c.loaded
-                return null;
+            if (c == null || !c.q) { // !c.loaded
+                return Optional.empty();
             }
-            return SerializableChunkData.a(cw.getHandle(), c); //SerializableChunkData.copyOf
+            return Optional.of(SerializableChunkData.a(cw.getHandle(), c)); // SerializableChunkData.copyOf
         }, ((CraftServer) Bukkit.getServer()).getServer());
-        return () -> {
-            NBTTagCompound nbt = chunkData.join().a(); // SerializableChunkData.write
-            return parseChunkFromNBT(new NBT.NBTCompound(nbt));
-        };
+        return () -> chunkData.join().map(SerializableChunkData::a).map(NBT.NBTCompound::new).map(this::parseChunkFromNBT).orElse(null); // SerializableChunkData::write
     }
 
     protected GenericChunk getLoadedChunk(DynmapChunk chunk) {