fix: data field in CodableTransaction must be passed into the envelope

Author: JeneaVranceanu

Sources/Core/Transaction/CodableTransaction.swift

@@ -56,9 +56,10 @@ public struct CodableTransaction {
         set { envelope.value = newValue }
     }
 
-    // MARK: - Ruins signing and decoding tests if tied to envelop
-    /// any additional data for the transaction
-    public var data: Data
+    public var data: Data  {
+        get { return envelope.data }
+        set { envelope.data = newValue }
+    }
 
     // MARK: - Properties transaction type related either sends to a node if exist
 
@@ -174,8 +175,6 @@ public struct CodableTransaction {
     public init?(rawValue: Data) {
         guard let env = EnvelopeFactory.createEnvelope(rawValue: rawValue) else { return nil }
         self.envelope = env
-        // FIXME: This is duplication and should be fixed.
-        data = Data()
         noncePolicy = .latest
         gasLimitPolicy = .automatic
         gasPricePolicy = .automatic
@@ -233,9 +232,6 @@ extension CodableTransaction: Codable {
     public init(from decoder: Decoder) throws {
         guard let env = try EnvelopeFactory.createEnvelope(from: decoder) else { throw Web3Error.dataError }
         self.envelope = env
-        // FIXME: This is duplication and should be fixed.
-        data = Data()
-
         noncePolicy = .latest
         gasLimitPolicy = .automatic
         gasPricePolicy = .automatic
@@ -420,8 +416,6 @@ extension CodableTransaction {
                 chainID: BigUInt = 0, value: BigUInt = 0, data: Data = Data(),
                 gasLimit: BigUInt = 0, maxFeePerGas: BigUInt? = nil, maxPriorityFeePerGas: BigUInt? = nil,  gasPrice: BigUInt? = nil,
                 accessList: [AccessListEntry]? = nil, v: BigUInt = 1, r: BigUInt = 0, s: BigUInt = 0) {
-        // FIXME: This is duplication and should be fixed.
-        self.data = data
         self.accessList = accessList
         self.gasLimitPolicy = .automatic
         self.noncePolicy = .pending