fix: createNewAccount always non-hardened derivation

JeneaVranceanu · JeneaVranceanu · commit d76e6ee726b3 · 2023-06-30T09:15:57.000+03:00
diff --git a/Sources/Web3Core/KeystoreManager/BIP32Keystore.swift b/Sources/Web3Core/KeystoreManager/BIP32Keystore.swift
@@ -155,13 +155,7 @@ public class BIP32Keystore: AbstractKeystore {
         guard let newAddress = Utilities.publicToAddress(newNode.publicKey) else {
             throw AbstractKeystoreError.keyDerivationError
         }
-        let prefixPath = self.rootPrefix
-        var newPath: String
-        if newNode.isHardened {
-            newPath = prefixPath + "/" + String(newNode.index % HDNode.hardenedIndexPrefix) + "'"
-        } else {
-            newPath = prefixPath + "/" + String(newNode.index)
-        }
+        let newPath = rootPrefix + "/" + String(newNode.index)
         addressStorage.add(address: newAddress, for: newPath)
     }
 

Original file line number	Diff line number	Diff line change
`@@ -155,13 +155,7 @@ public class BIP32Keystore: AbstractKeystore {`
`155`	`155`	`guard let newAddress = Utilities.publicToAddress(newNode.publicKey) else {`
`156`	`156`	`throw AbstractKeystoreError.keyDerivationError`
`157`	`157`	`}`
`158`		`- let prefixPath = self.rootPrefix`
`159`		`- var newPath: String`
`160`		`- if newNode.isHardened {`
`161`		`- newPath = prefixPath + "/" + String(newNode.index % HDNode.hardenedIndexPrefix) + "'"`
`162`		`- } else {`
`163`		`- newPath = prefixPath + "/" + String(newNode.index)`
`164`		`- }`
	`158`	`+ let newPath = rootPrefix + "/" + String(newNode.index)`
`165`	`159`	`addressStorage.add(address: newAddress, for: newPath)`
`166`	`160`	`}`
`167`	`161`