Cloudstek/fixes (#156)

* Update gitignore

* Remove tree builder without root node deprecation notice in Symfony 4.2 and up.

Removes the "A tree builder without a root node is deprecated since Symfony 4.2 and will not be supported anymore in 5.0." notice in Symfony 4.2 and up, with BC.

* Ignore deprecation notices caused by vendor libraries

Ignores deprecation notices caused by vendor libraries whilst still failing tests for deprecation notices caused by code outside the vendors directory. This only affects the exit code and will still report all notices.

Author: mdeboer

.gitignore

@@ -7,3 +7,7 @@ jose.phar.version
 .travis/secrets.tar
 report.md
 composer.lock
+.php_cs
+.php_cs.cache
+vendor/
+src/Bundle/JoseFramework/var/

phpunit.xml.dist

@@ -27,6 +27,7 @@
         <ini name="intl.error_level" value="0" />
         <ini name="memory_limit" value="-1" />
         <server name="KERNEL_CLASS" value="Jose\Bundle\JoseFramework\Tests\AppKernel" />
+        <env name="SYMFONY_DEPRECATIONS_HELPER" value="weak_vendors" />
     </php>
     <filter>
         <whitelist>

src/Bundle/JoseFramework/DependencyInjection/Configuration.php

@@ -42,13 +42,23 @@ public function __construct(string $alias, array $sources)
 
     public function getConfigTreeBuilder()
     {
-        $treeBuilder = new TreeBuilder();
-        $rootNode = $treeBuilder->root($this->alias);
+        $treeBuilder = new TreeBuilder($this->alias);
+        $rootNode = $this->getRootNode($treeBuilder, $this->alias);
 
         foreach ($this->sources as $source) {
             $source->getNodeDefinition($rootNode);
         }
 
         return $treeBuilder;
     }
+    
+     private function getRootNode(TreeBuilder $treeBuilder, $name)
+     {
+         // BC layer for symfony/config 4.1 and older
+         if (! \method_exists($treeBuilder, 'getRootNode')) {
+             return $treeBuilder->root($name);
+         }
+
+         return $treeBuilder->getRootNode();
+     }
 }