Deprecate compression (#539)

Deprecate Compression

Author: Spomky

ecs.php

@@ -2,7 +2,6 @@
 
 declare(strict_types=1);
 
-use PhpCsFixer\Fixer\Alias\MbStrFunctionsFixer;
 use PhpCsFixer\Fixer\ArrayNotation\ArraySyntaxFixer;
 use PhpCsFixer\Fixer\ClassNotation\ProtectedToPrivateFixer;
 use PhpCsFixer\Fixer\Comment\HeaderCommentFixer;
@@ -30,6 +29,8 @@
 use Symplify\EasyCodingStandard\Config\ECSConfig;
 use Symplify\EasyCodingStandard\ValueObject\Set\SetList;
 
+//use PhpCsFixer\Fixer\Alias\MbStrFunctionsFixer;
+
 return static function (ECSConfig $config): void {
     $header = '';
     $config->import(SetList::PSR_12);
@@ -53,7 +54,7 @@
     $config->rule(ProtectedToPrivateFixer::class);
     $config->rule(DeclareStrictTypesFixer::class);
     $config->rule(NativeConstantInvocationFixer::class);
-    $config->rule(MbStrFunctionsFixer::class);
+    //$config->rule(MbStrFunctionsFixer::class);
     $config->rule(LinebreakAfterOpeningTagFixer::class);
     $config->rule(CombineConsecutiveIssetsFixer::class);
     $config->rule(CombineConsecutiveUnsetsFixer::class);

performance/JWE/EncryptionBench.php

@@ -46,17 +46,16 @@
  */
 abstract class EncryptionBench
 {
-    private AlgorithmManager $contentEncryptionAlgorithmsManager;
-
-    private AlgorithmManager $keyEncryptionAlgorithmsManager;
+    private AlgorithmManager $algorithmsManager;
 
     private CompressionMethodManager $compressionMethodsManager;
 
     private JWESerializerManager $serializerManager;
 
     public function init(): void
     {
-        $this->keyEncryptionAlgorithmsManager = new AlgorithmManager([
+        $this->algorithmsManager = new AlgorithmManager([
+            // Key Encryption
             new A128KW(),
             new A192KW(),
             new A256KW(),
@@ -74,8 +73,8 @@ public function init(): void
             new RSA15(),
             new RSAOAEP(),
             new RSAOAEP256(),
-        ]);
-        $this->contentEncryptionAlgorithmsManager = new AlgorithmManager([
+
+            // Content Encryption
             new A128CBCHS256(),
             new A192CBCHS384(),
             new A256CBCHS512(),
@@ -97,11 +96,7 @@ public function init(): void
      */
     public function encryption(array $params): void
     {
-        $jweBuilder = new JWEBuilder(
-            $this->getKeyEncryptionAlgorithmsManager(),
-            $this->getContentEncryptionAlgorithmsManager(),
-            $this->getCompressionMethodsManager()
-        );
+        $jweBuilder = new JWEBuilder($this->getAlgorithmsManager(), $this->getCompressionMethodsManager());
         $jweBuilder
             ->withPayload($params['payload'])
             ->withAAD($this->getAAD())
@@ -118,11 +113,7 @@ public function encryption(array $params): void
      */
     public function decryption(array $params): void
     {
-        $jweLoader = new JWEDecrypter(
-            $this->getKeyEncryptionAlgorithmsManager(),
-            $this->getContentEncryptionAlgorithmsManager(),
-            $this->getCompressionMethodsManager()
-        );
+        $jweLoader = new JWEDecrypter($this->getAlgorithmsManager(), $this->getCompressionMethodsManager());
         $jwe = $this->serializerManager->unserialize($params['input']);
         $keyset = JWKSet::createFromKeyData($params['recipient_keys']);
         $jweLoader->decryptUsingKeySet($jwe, $keyset, 0);
@@ -143,14 +134,9 @@ abstract public function dataRecipientPublicKeys(): array;
 
     abstract protected function getAAD(): ?string;
 
-    private function getKeyEncryptionAlgorithmsManager(): AlgorithmManager
-    {
-        return $this->keyEncryptionAlgorithmsManager;
-    }
-
-    private function getContentEncryptionAlgorithmsManager(): AlgorithmManager
+    private function getAlgorithmsManager(): AlgorithmManager
     {
-        return $this->contentEncryptionAlgorithmsManager;
+        return $this->algorithmsManager;
     }
 
     private function getCompressionMethodsManager(): CompressionMethodManager