ECDSA Signature computation fixed

Spomky · Spomky · commit 04c6bd28afcc · 2017-12-03T09:26:14.000+01:00
diff --git a/src/Component/Core/Util/ECSignature.php b/src/Component/Core/Util/ECSignature.php
@@ -89,7 +89,7 @@ public static function fromDER(string $der, int $partLength): string
      */
     private static function preparePositiveInteger(string $data): string
     {
-        if (mb_substr($data, 0, 2, '8bit') >= '7f') {
+        if (mb_substr($data, 0, 2, '8bit') > '7f') {
             return '00'.$data;
         }
         while ('00' === mb_substr($data, 0, 2, '8bit') && mb_substr($data, 2, 2, '8bit') <= '7f') {

Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,7 @@ public static function fromDER(string $der, int $partLength): string`
`89`	`89`	`*/`
`90`	`90`	`private static function preparePositiveInteger(string $data): string`
`91`	`91`	`{`
`92`		`- if (mb_substr($data, 0, 2, '8bit') >= '7f') {`
	`92`	`+ if (mb_substr($data, 0, 2, '8bit') > '7f') {`
`93`	`93`	`return '00'.$data;`
`94`	`94`	`}`
`95`	`95`	`while ('00' === mb_substr($data, 0, 2, '8bit') && mb_substr($data, 2, 2, '8bit') <= '7f') {`