Skip to content

Commit 8764033

Browse files
mcanshMichaelDeBoey
mcansh
authored and
MichaelDeBoey
committed
fix: "ERR_INVALID_THIS" on Node 20 (#32)
* fix: node 20 pnpm/node-fetch#1 Signed-off-by: Logan McAnsh <logan@mcan.sh> * ci: test against more node versions Signed-off-by: Logan McAnsh <logan@mcan.sh> * ci: update action versions Signed-off-by: Logan McAnsh <logan@mcan.sh> * chore: remove nested .github dir Signed-off-by: Logan McAnsh <logan@mcan.sh> * ci: disable fail fast Signed-off-by: Logan McAnsh <logan@mcan.sh> * ci: new server per test Signed-off-by: Logan McAnsh <logan@mcan.sh> * test: update family agent option test Signed-off-by: Logan McAnsh <logan@mcan.sh> * Create polite-eggs-jam.md * test: use ipv4 Signed-off-by: Logan McAnsh <logan@mcan.sh> * test: use family 0 Signed-off-by: Logan McAnsh <logan@mcan.sh> --------- Signed-off-by: Logan McAnsh <logan@mcan.sh>
1 parent db89ba2 commit 8764033

File tree

18 files changed

+1353
-1459
lines changed

18 files changed

+1353
-1459
lines changed

‎.changeset/polite-eggs-jam.md‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@remix-run/web-fetch": patch
3+
---
4+
5+
fixes "ERR_INVALID_THIS" on Node 20

‎.github/workflows/blob.yml‎

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,10 @@ jobs:
2323
project:
2424
- blob
2525
steps:
26-
- uses: actions/checkout@v2
26+
- uses: actions/checkout@v3
2727

2828
- name: Setup node ${{ matrix.node-version }}
29-
uses: actions/setup-node@v2
29+
uses: actions/setup-node@v3
3030
with:
3131
node-version: ${{ matrix.node-version }}
3232

@@ -42,9 +42,12 @@ jobs:
4242
runs-on: ${{ matrix.os }}
4343

4444
strategy:
45+
fail-fast: false
4546
matrix:
4647
node-version:
4748
- 16
49+
- 18
50+
- 20
4851
os:
4952
- ubuntu-latest
5053
- windows-latest
@@ -53,10 +56,10 @@ jobs:
5356
- blob
5457

5558
steps:
56-
- uses: actions/checkout@v2
59+
- uses: actions/checkout@v3
5760

5861
- name: Setup Node
59-
uses: actions/setup-node@v2
62+
uses: actions/setup-node@v3
6063
with:
6164
node-version: ${{ matrix.node-version }}
6265

‎.github/workflows/fetch.yml‎

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,10 @@ jobs:
2424
project:
2525
- fetch
2626
steps:
27-
- uses: actions/checkout@v2
27+
- uses: actions/checkout@v3
2828

2929
- name: Setup node ${{ matrix.node-version }}
30-
uses: actions/setup-node@v2
30+
uses: actions/setup-node@v3
3131
with:
3232
node-version: ${{ matrix.node-version }}
3333

@@ -44,9 +44,12 @@ jobs:
4444
runs-on: ${{ matrix.os }}
4545

4646
strategy:
47+
fail-fast: false
4748
matrix:
4849
node-version:
4950
- 16
51+
- 18
52+
- 20
5053
os:
5154
- ubuntu-latest
5255
- windows-latest
@@ -61,10 +64,10 @@ jobs:
6164
node-version: 14
6265

6366
steps:
64-
- uses: actions/checkout@v2
67+
- uses: actions/checkout@v3
6568

6669
- name: Setup Node
67-
uses: actions/setup-node@v2
70+
uses: actions/setup-node@v3
6871
with:
6972
node-version: ${{ matrix.node-version }}
7073

‎.github/workflows/file.yml‎

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,10 @@ jobs:
2323
project:
2424
- file
2525
steps:
26-
- uses: actions/checkout@v2
26+
- uses: actions/checkout@v3
2727

2828
- name: Setup node ${{ matrix.node-version }}
29-
uses: actions/setup-node@v2
29+
uses: actions/setup-node@v3
3030
with:
3131
node-version: ${{ matrix.node-version }}
3232

@@ -42,9 +42,12 @@ jobs:
4242
runs-on: ${{ matrix.os }}
4343

4444
strategy:
45+
fail-fast: false
4546
matrix:
4647
node-version:
4748
- 16
49+
- 18
50+
- 20
4851
os:
4952
- ubuntu-latest
5053
- windows-latest
@@ -53,10 +56,10 @@ jobs:
5356
- file
5457

5558
steps:
56-
- uses: actions/checkout@v2
59+
- uses: actions/checkout@v3
5760

5861
- name: Setup Node
59-
uses: actions/setup-node@v2
62+
uses: actions/setup-node@v3
6063
with:
6164
node-version: ${{ matrix.node-version }}
6265

‎.github/workflows/form-data.yml‎

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,10 @@ jobs:
2424
project:
2525
- form-data
2626
steps:
27-
- uses: actions/checkout@v2
27+
- uses: actions/checkout@v3
2828

2929
- name: Setup node ${{ matrix.node-version }}
30-
uses: actions/setup-node@v2
30+
uses: actions/setup-node@v3
3131
with:
3232
node-version: ${{ matrix.node-version }}
3333

@@ -43,9 +43,12 @@ jobs:
4343
runs-on: ${{ matrix.os }}
4444

4545
strategy:
46+
fail-fast: false
4647
matrix:
4748
node-version:
4849
- 16
50+
- 18
51+
- 20
4952
os:
5053
- ubuntu-latest
5154
- windows-latest
@@ -54,10 +57,10 @@ jobs:
5457
- form-data
5558

5659
steps:
57-
- uses: actions/checkout@v2
60+
- uses: actions/checkout@v3
5861

5962
- name: Setup Node
60-
uses: actions/setup-node@v2
63+
uses: actions/setup-node@v3
6164
with:
6265
node-version: ${{ matrix.node-version }}
6366

‎.github/workflows/stream.yml‎

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,10 @@ jobs:
2424
- stream
2525
steps:
2626
- name: Checkout
27-
uses: actions/checkout@v2
27+
uses: actions/checkout@v3
2828

2929
- name: Setup node ${{ matrix.node-version }}
30-
uses: actions/setup-node@v2
30+
uses: actions/setup-node@v3
3131
with:
3232
node-version: ${{ matrix.node-version }}
3333

@@ -43,9 +43,12 @@ jobs:
4343
runs-on: ${{ matrix.os }}
4444

4545
strategy:
46+
fail-fast: false
4647
matrix:
4748
node-version:
4849
- 16
50+
- 18
51+
- 20
4952
os:
5053
- ubuntu-latest
5154
- windows-latest
@@ -55,10 +58,10 @@ jobs:
5558

5659
steps:
5760
- name: Checkout
58-
uses: actions/checkout@v2
61+
uses: actions/checkout@v3
5962

6063
- name: Setup Node
61-
uses: actions/setup-node@v2
64+
uses: actions/setup-node@v3
6265
with:
6366
node-version: ${{ matrix.node-version }}
6467

@@ -83,10 +86,10 @@ jobs:
8386

8487
steps:
8588
- name: Checkout
86-
uses: actions/checkout@v2
89+
uses: actions/checkout@v3
8790

8891
- name: Setup Node
89-
uses: actions/setup-node@v2
92+
uses: actions/setup-node@v3
9093
with:
9194
node-version: 16
9295

‎packages/fetch/.github/FUNDING.yml‎

Lines changed: 0 additions & 12 deletions
This file was deleted.

‎packages/fetch/.github/ISSUE_TEMPLATE/bug_report.md‎

Lines changed: 0 additions & 40 deletions
This file was deleted.

‎packages/fetch/.github/ISSUE_TEMPLATE/config.yml‎

Lines changed: 0 additions & 5 deletions
This file was deleted.

‎packages/fetch/.github/ISSUE_TEMPLATE/feature-request.md‎

Lines changed: 0 additions & 21 deletions
This file was deleted.

0 commit comments

Comments
 (0)