Skip to content

Commit 2e0c3e0

Browse files
mcanshMichaelDeBoey
mcansh
authored and
MichaelDeBoey
committed
fix: "ERR_INVALID_THIS" on Node 20 (#32)
* fix: node 20 pnpm/node-fetch#1 Signed-off-by: Logan McAnsh <logan@mcan.sh> * ci: test against more node versions Signed-off-by: Logan McAnsh <logan@mcan.sh> * ci: update action versions Signed-off-by: Logan McAnsh <logan@mcan.sh> * chore: remove nested .github dir Signed-off-by: Logan McAnsh <logan@mcan.sh> * ci: disable fail fast Signed-off-by: Logan McAnsh <logan@mcan.sh> * ci: new server per test Signed-off-by: Logan McAnsh <logan@mcan.sh> * test: update family agent option test Signed-off-by: Logan McAnsh <logan@mcan.sh> * Create polite-eggs-jam.md * test: use ipv4 Signed-off-by: Logan McAnsh <logan@mcan.sh> * test: use family 0 Signed-off-by: Logan McAnsh <logan@mcan.sh> --------- Signed-off-by: Logan McAnsh <logan@mcan.sh>
1 parent e55e8cf commit 2e0c3e0

File tree

18 files changed

+1348
-1459
lines changed

18 files changed

+1348
-1459
lines changed

‎.changeset/polite-eggs-jam.md‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@remix-run/web-fetch": patch
3+
---
4+
5+
fixes "ERR_INVALID_THIS" on Node 20

‎.github/workflows/blob.yml‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,10 @@ jobs:
2424
project:
2525
- blob
2626
steps:
27-
- uses: actions/checkout@v2
27+
- uses: actions/checkout@v3
2828

2929
- name: Setup node ${{ matrix.node-version }}
30-
uses: actions/setup-node@v2
30+
uses: actions/setup-node@v3
3131
with:
3232
node-version: ${{ matrix.node-version }}
3333

@@ -47,6 +47,8 @@ jobs:
4747
matrix:
4848
node-version:
4949
- 16
50+
- 18
51+
- 20
5052
os:
5153
- ubuntu-latest
5254
- windows-latest
@@ -55,10 +57,10 @@ jobs:
5557
- blob
5658

5759
steps:
58-
- uses: actions/checkout@v2
60+
- uses: actions/checkout@v3
5961

6062
- name: Setup Node
61-
uses: actions/setup-node@v2
63+
uses: actions/setup-node@v3
6264
with:
6365
node-version: ${{ matrix.node-version }}
6466

‎.github/workflows/fetch.yml‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,10 @@ jobs:
2525
project:
2626
- fetch
2727
steps:
28-
- uses: actions/checkout@v2
28+
- uses: actions/checkout@v3
2929

3030
- name: Setup node ${{ matrix.node-version }}
31-
uses: actions/setup-node@v2
31+
uses: actions/setup-node@v3
3232
with:
3333
node-version: ${{ matrix.node-version }}
3434

@@ -49,6 +49,8 @@ jobs:
4949
matrix:
5050
node-version:
5151
- 16
52+
- 18
53+
- 20
5254
os:
5355
- ubuntu-latest
5456
- windows-latest
@@ -57,10 +59,10 @@ jobs:
5759
- fetch
5860

5961
steps:
60-
- uses: actions/checkout@v2
62+
- uses: actions/checkout@v3
6163

6264
- name: Setup Node
63-
uses: actions/setup-node@v2
65+
uses: actions/setup-node@v3
6466
with:
6567
node-version: ${{ matrix.node-version }}
6668

‎.github/workflows/file.yml‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,10 @@ jobs:
2424
project:
2525
- file
2626
steps:
27-
- uses: actions/checkout@v2
27+
- uses: actions/checkout@v3
2828

2929
- name: Setup node ${{ matrix.node-version }}
30-
uses: actions/setup-node@v2
30+
uses: actions/setup-node@v3
3131
with:
3232
node-version: ${{ matrix.node-version }}
3333

@@ -47,6 +47,8 @@ jobs:
4747
matrix:
4848
node-version:
4949
- 16
50+
- 18
51+
- 20
5052
os:
5153
- ubuntu-latest
5254
- windows-latest
@@ -55,10 +57,10 @@ jobs:
5557
- file
5658

5759
steps:
58-
- uses: actions/checkout@v2
60+
- uses: actions/checkout@v3
5961

6062
- name: Setup Node
61-
uses: actions/setup-node@v2
63+
uses: actions/setup-node@v3
6264
with:
6365
node-version: ${{ matrix.node-version }}
6466

‎.github/workflows/form-data.yml‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,10 @@ jobs:
2525
project:
2626
- form-data
2727
steps:
28-
- uses: actions/checkout@v2
28+
- uses: actions/checkout@v3
2929

3030
- name: Setup node ${{ matrix.node-version }}
31-
uses: actions/setup-node@v2
31+
uses: actions/setup-node@v3
3232
with:
3333
node-version: ${{ matrix.node-version }}
3434

@@ -48,6 +48,8 @@ jobs:
4848
matrix:
4949
node-version:
5050
- 16
51+
- 18
52+
- 20
5153
os:
5254
- ubuntu-latest
5355
- windows-latest
@@ -56,10 +58,10 @@ jobs:
5658
- form-data
5759

5860
steps:
59-
- uses: actions/checkout@v2
61+
- uses: actions/checkout@v3
6062

6163
- name: Setup Node
62-
uses: actions/setup-node@v2
64+
uses: actions/setup-node@v3
6365
with:
6466
node-version: ${{ matrix.node-version }}
6567

‎.github/workflows/stream.yml‎

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,10 @@ jobs:
2525
- stream
2626
steps:
2727
- name: Checkout
28-
uses: actions/checkout@v2
28+
uses: actions/checkout@v3
2929

3030
- name: Setup node ${{ matrix.node-version }}
31-
uses: actions/setup-node@v2
31+
uses: actions/setup-node@v3
3232
with:
3333
node-version: ${{ matrix.node-version }}
3434

@@ -48,6 +48,8 @@ jobs:
4848
matrix:
4949
node-version:
5050
- 16
51+
- 18
52+
- 20
5153
os:
5254
- ubuntu-latest
5355
- windows-latest
@@ -57,10 +59,10 @@ jobs:
5759

5860
steps:
5961
- name: Checkout
60-
uses: actions/checkout@v2
62+
uses: actions/checkout@v3
6163

6264
- name: Setup Node
63-
uses: actions/setup-node@v2
65+
uses: actions/setup-node@v3
6466
with:
6567
node-version: ${{ matrix.node-version }}
6668

@@ -86,10 +88,10 @@ jobs:
8688

8789
steps:
8890
- name: Checkout
89-
uses: actions/checkout@v2
91+
uses: actions/checkout@v3
9092

9193
- name: Setup Node
92-
uses: actions/setup-node@v2
94+
uses: actions/setup-node@v3
9395
with:
9496
node-version: 16
9597

‎packages/fetch/.github/FUNDING.yml‎

Lines changed: 0 additions & 12 deletions
This file was deleted.

‎packages/fetch/.github/ISSUE_TEMPLATE/bug_report.md‎

Lines changed: 0 additions & 40 deletions
This file was deleted.

‎packages/fetch/.github/ISSUE_TEMPLATE/config.yml‎

Lines changed: 0 additions & 5 deletions
This file was deleted.

‎packages/fetch/.github/ISSUE_TEMPLATE/feature-request.md‎

Lines changed: 0 additions & 21 deletions
This file was deleted.

0 commit comments

Comments
 (0)