Upgrade compute-baseline to use BCD 7.0.0 (#3288)

This causes the following breaking changes:

- The `RealSupportStatement` class has been removed. All BCD statements now have "real" values (that is, they do not contain `true` or `null` values where version strings might appear), so the distinction between "real" and "non-real" statements no longer has any meaning. Use the `SupportStatement` class instead.

- The `statement()` factory method has been removed. It serves no purpose without the real/non-real value distinction. Use `new SupportStatement()` instead.

Co-authored-by: Philip Jägenstedt <philip@foolip.org>

Author: ddbeck

package-lock.json

@@ -40,7 +40,7 @@
   "devDependencies": {
     "@eslint/js": "^9.34.0",
     "@js-temporal/polyfill": "^0.5.1",
-    "@mdn/browser-compat-data": "^6.1.5",
+    "@mdn/browser-compat-data": "^7.0.0",
     "@octokit/rest": "^22.0.0",
     "@types/caniuse-lite": "^1.0.4",
     "@types/node": "^20.19.11",

package.json

@@ -35,7 +35,7 @@
     "mocha": "^11.7.1"
   },
   "peerDependencies": {
-    "@mdn/browser-compat-data": "^6.0.2"
+    "@mdn/browser-compat-data": "^7.0.0"
   },
   "dependencies": {
     "@js-temporal/polyfill": "^0.5.1",

packages/compute-baseline/package.json

@@ -4,8 +4,6 @@ import { Compat, defaultCompat } from "./compat.js";
 import { Release } from "./release.js";
 import {
   Qualifications,
-  RealSupportStatement,
-  statement,
   Supported,
   SupportStatement,
   UnknownSupport,
@@ -95,12 +93,11 @@ export class Feature {
   }
 
   /**
-   * Get this feature's `SupportStatement` or `RealSupportStatement` objects,
-   * for a given browser.
+   * Get this feature's `SupportStatement` objects, for a given browser.
    */
   supportStatements(browser: Browser): SupportStatement[] {
-    return this.rawSupportStatements(browser).map((raw) =>
-      statement(raw, browser, this),
+    return this.rawSupportStatements(browser).map(
+      (raw) => new SupportStatement(raw, browser, this),
     );
   }
 
@@ -114,8 +111,6 @@ export class Feature {
   ): (Supported | Unsupported | UnknownSupport)[] {
     const result = [];
     for (const s of this.supportStatements(release.browser)) {
-      this.assertRealSupportStatement(s, release.browser);
-
       result.push(s.supportedInDetails(release));
     }
     return result;
@@ -130,8 +125,6 @@ export class Feature {
   supportedIn(release: Release): boolean | null {
     let unknown = false;
     for (const s of this.supportStatements(release.browser)) {
-      this.assertRealSupportStatement(s, release.browser);
-
       const supported = s.supportedInDetails(release);
       if (supported.supported && !supported.qualifications) {
         return true;
@@ -152,8 +145,6 @@ export class Feature {
   ): { release: Release; qualifications?: Qualifications }[] {
     const result = [];
     for (const s of this.supportStatements(browser)) {
-      this.assertRealSupportStatement(s, browser);
-
       result.push(...s.supportedBy());
     }
 
@@ -175,17 +166,4 @@ export class Feature {
     }
     return result;
   }
-
-  /**
-   * Throws when a support statement contains non-real values.
-   */
-  assertRealSupportStatement(
-    statement: SupportStatement,
-    browser: Browser,
-  ): asserts statement is RealSupportStatement {
-    if (!(statement instanceof RealSupportStatement))
-      throw new Error(
-        `${this.id} contains non-real values for ${browser.name}. Cannot expand support.`,
-      );
-  }
 }

packages/compute-baseline/src/browser-compat-data/feature.ts

@@ -4,8 +4,6 @@ import { feature, Feature } from "./feature.js";
 import { query } from "./query.js";
 import { Release } from "./release.js";
 import {
-  RealSupportStatement,
-  statement,
   SupportStatement,
 } from "./supportStatements.js";
 import { walk } from "./walk.js";
@@ -17,9 +15,7 @@ export {
   feature,
   Feature,
   query,
-  RealSupportStatement,
   Release,
-  statement,
   SupportStatement,
-  walk,
+  walk
 };

packages/compute-baseline/src/browser-compat-data/index.ts

@@ -1,30 +1,9 @@
 import assert from "node:assert/strict";
 
 import { browser } from "./browser.js";
-import {
-  RealSupportStatement,
-  SupportStatement,
-  statement,
-} from "./supportStatements.js";
+import { SupportStatement } from "./supportStatements.js";
 
 describe("statements", function () {
-  describe("statement()", function () {
-    it("upgrades support statements", function () {
-      const v1 = statement(new SupportStatement({ version_added: "1" }));
-      assert(v1 instanceof RealSupportStatement);
-    });
-
-    it("passes through real support statements", function () {
-      const original = new RealSupportStatement({ version_added: "2" });
-      assert(original === statement(original));
-    });
-
-    it("accepts raw support statement objects", function () {
-      const v3 = statement({ version_added: "3" });
-      assert(v3 instanceof RealSupportStatement);
-    });
-  });
-
   describe("SupportStatement", function () {
     describe("#flags", function () {
       const s = {
@@ -75,16 +54,6 @@ describe("statements", function () {
         });
         assert.equal(s.version_added, "1");
       });
-
-      it("returns false for undefined", function () {
-        const s = new SupportStatement({});
-        assert.equal(s.version_added, false);
-      });
-
-      it("returns null for null", function () {
-        const s = new SupportStatement({ version_added: null });
-        assert.equal(s.version_added, null);
-      });
     });
 
     describe("#version_removed", function () {
@@ -96,85 +65,15 @@ describe("statements", function () {
         assert.equal(s.version_removed, "2");
       });
 
-      it("returns false", function () {
-        const s = new SupportStatement({
-          version_added: "1",
-          version_removed: false,
-        });
-        assert.equal(s.version_removed, false);
-      });
-
       it("returns undefined", function () {
         const s = new SupportStatement({ version_added: "1" });
         assert.equal(s.version_removed, undefined);
       });
     });
-  });
-
-  describe("RealSupportStatement", function () {
-    describe("#constructor", function () {
-      it("throws for empty support statement", function () {
-        assert.throws(() => new RealSupportStatement({}));
-      });
-
-      it("throws for missing version_added", function () {
-        assert.throws(
-          () => new RealSupportStatement({ version_removed: false }),
-        );
-      });
-
-      it("throws for explicitly undefined version_added or version_removed", function () {
-        assert.throws(
-          () => new RealSupportStatement({ version_added: undefined }),
-        );
-        assert.throws(
-          () =>
-            new RealSupportStatement({
-              version_added: "1",
-              version_removed: undefined,
-            }),
-        );
-      });
-
-      it("throws for null version_added or version_removed", function () {
-        assert.throws(() => new RealSupportStatement({ version_added: null }));
-        assert.throws(
-          () =>
-            new RealSupportStatement({
-              version_added: "1",
-              version_removed: null,
-            }),
-        );
-      });
-
-      it("throws for true version_added or version_removed", function () {
-        assert.throws(() => new RealSupportStatement({ version_added: true }));
-        assert.throws(
-          () =>
-            new RealSupportStatement({
-              version_added: "1",
-              version_removed: true,
-            }),
-        );
-      });
-
-      it("does not throw for false version_added or version_removed", function () {
-        assert.doesNotThrow(
-          () => new RealSupportStatement({ version_added: false }),
-        );
-        assert.doesNotThrow(
-          () =>
-            new RealSupportStatement({
-              version_added: "1",
-              version_removed: false,
-            }),
-        );
-      });
-    });
 
     describe("#supportedBy", function () {
       it("returns an array of releases represented by the statement", function () {
-        const st = new RealSupportStatement(
+        const st = new SupportStatement(
           { version_added: "1" },
           browser("chrome"),
         );
@@ -187,7 +86,7 @@ describe("statements", function () {
       // of that range? If so, you should be able to opt-in to warnings or
       // errors about it.
       it("handles ≤ gracefully", function () {
-        const st = new RealSupportStatement(
+        const st = new SupportStatement(
           { version_added: "≤11" },
           browser("chrome"),
         );
@@ -199,12 +98,12 @@ describe("statements", function () {
     describe("supportedIn()", function () {
       it("throws when browser is undefined", function () {
         const cr = browser("chrome");
-        const statement = new RealSupportStatement({ version_added: "1" });
+        const statement = new SupportStatement({ version_added: "1" });
         assert.throws(() => statement.supportedInDetails(cr.current()), Error);
       });
 
       it("throws when release does not correspond to the statement's browser", function () {
-        const statement = new RealSupportStatement(
+        const statement = new SupportStatement(
           { version_added: "1" },
           browser("chrome"),
         );
@@ -216,8 +115,8 @@ describe("statements", function () {
 
       it("returns supported when release is on after version_added", function () {
         const cr = browser("chrome");
-        const unranged = new RealSupportStatement({ version_added: "100" }, cr);
-        const ranged = new RealSupportStatement({ version_added: "≤100" }, cr);
+        const unranged = new SupportStatement({ version_added: "100" }, cr);
+        const ranged = new SupportStatement({ version_added: "≤100" }, cr);
 
         assert.equal(
           unranged.supportedInDetails(cr.version("100")).supported,
@@ -254,11 +153,11 @@ describe("statements", function () {
 
       it("returns supported when release is on after version_added and before version_removed", function () {
         const cr = browser("chrome");
-        const unranged = new RealSupportStatement(
+        const unranged = new SupportStatement(
           { version_added: "100", version_removed: "125" },
           cr,
         );
-        const ranged = new RealSupportStatement(
+        const ranged = new SupportStatement(
           { version_added: "≤100", version_removed: "125" },
           cr,
         );
@@ -308,11 +207,8 @@ describe("statements", function () {
 
       it("returns unknown support when release is before ranged version_added", function () {
         const cr = browser("chrome");
-        const rangedOpen = new RealSupportStatement(
-          { version_added: "≤100" },
-          cr,
-        );
-        const rangedClosed = new RealSupportStatement(
+        const rangedOpen = new SupportStatement({ version_added: "≤100" }, cr);
+        const rangedClosed = new SupportStatement(
           { version_added: "≤100", version_removed: "125" },
           cr,
         );
@@ -329,7 +225,7 @@ describe("statements", function () {
 
       it("returns unknown support when release is after version_added and before ranged version_removed", function () {
         const cr = browser("chrome");
-        const rangedEnd = new RealSupportStatement(
+        const rangedEnd = new SupportStatement(
           { version_added: "100", version_removed: "≤125" },
           cr,
         );
@@ -354,10 +250,7 @@ describe("statements", function () {
 
       it("returns unsupported when statement is version_added false", function () {
         const cr = browser("chrome");
-        const statement = new RealSupportStatement(
-          { version_added: false },
-          cr,
-        );
+        const statement = new SupportStatement({ version_added: false }, cr);
 
         for (const release of cr.releases) {
           assert.equal(statement.supportedInDetails(release).supported, false);
@@ -366,7 +259,7 @@ describe("statements", function () {
 
       it("returns unsupported when release is before fixed version_added", function () {
         const cr = browser("chrome");
-        const unranged = new RealSupportStatement({ version_added: "100" }, cr);
+        const unranged = new SupportStatement({ version_added: "100" }, cr);
         assert.equal(
           unranged.supportedInDetails(cr.version("99")).supported,
           false,
@@ -376,7 +269,7 @@ describe("statements", function () {
       it("returns unsupported when release is on or after version_removed", function () {
         const cr = browser("chrome");
 
-        const unranged = new RealSupportStatement(
+        const unranged = new SupportStatement(
           { version_added: "1", version_removed: "10" },
           cr,
         );
@@ -397,7 +290,7 @@ describe("statements", function () {
           false,
         );
 
-        const ranged = new RealSupportStatement(
+        const ranged = new SupportStatement(
           { version_added: "≤5", version_removed: "10" },
           cr,
         );