-
-
Notifications
You must be signed in to change notification settings - Fork 739
test: migrate rspack wasm test to rstest #11990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for rspack canceled.
|
3417a39 to
3ac4a9b
Compare
📦 Binary Size-limit
🙈 Size remains the same at 47.93MB |
CodSpeed Performance ReportMerging #11990 will not alter performanceComparing Summary
|
…-infra-dev/rspack into 10-23-chore/rstest-wasm-test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves WASM test support, upgrades the test framework, and includes minor code quality improvements across documentation and test infrastructure.
- Upgrades
@rstest/corefrom^0.6.1to^0.6.3 - Adds comprehensive WASM test configuration with proper concurrency limits and test exclusions
- Improves error handling in hash test cases to provide more informative error messages
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| website/docs/zh/plugins/webpack/entry-plugin.mdx | Consolidates multi-line code example to single line for better readability |
| website/docs/en/plugins/webpack/entry-plugin.mdx | Consolidates multi-line code example to single line for better readability |
| tests/rspack-test/rstest.config.ts | Adds WASM-specific test configuration with appropriate test exclusions and concurrency settings |
| tests/rspack-test/package.json | Updates test scripts to use full binary path and upgrades @rstest/core version |
| pnpm-lock.yaml | Updates lockfile to reflect package version upgrades and new dependency additions |
| packages/rspack/src/ChunkGraph.ts | Updates parameter names in compareFn signature with underscore prefix |
| packages/rspack-test-tools/src/test/creator.ts | Adjusts WASM concurrency handling to use numeric value instead of boolean |
| packages/rspack-test-tools/src/helper/setup-env.ts | Removes legacy Jest compatibility code for WASM tests |
| packages/rspack-test-tools/src/case/hash.ts | Improves error messaging when stats are not found during hash test validation |
| package.json | Updates @rstest/core version in root package.json |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
Related links
Checklist