Skip to content

Conversation

@CPunisher
Copy link
Contributor

Summary

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link

netlify bot commented Oct 23, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 2257e20
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/691175cc56d7c20008cb6914

@CPunisher CPunisher force-pushed the 10-23-chore/rstest-wasm-test branch from 3417a39 to 3ac4a9b Compare October 23, 2025 11:37
@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2025

📦 Binary Size-limit

Comparing 2257e20 to fix: should not inject css prefetch/preload runtime when only prefetch/preload js chunks (#12112) by harpsealjs

🙈 Size remains the same at 47.93MB

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 23, 2025

CodSpeed Performance Report

Merging #11990 will not alter performance

Comparing 10-23-chore/rstest-wasm-test (2257e20) with main (4506d64)

Summary

✅ 17 untouched

@CPunisher CPunisher requested a review from 9aoy October 24, 2025 08:14
@9aoy 9aoy marked this pull request as ready for review November 10, 2025 04:33
Copilot AI review requested due to automatic review settings November 10, 2025 04:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves WASM test support, upgrades the test framework, and includes minor code quality improvements across documentation and test infrastructure.

  • Upgrades @rstest/core from ^0.6.1 to ^0.6.3
  • Adds comprehensive WASM test configuration with proper concurrency limits and test exclusions
  • Improves error handling in hash test cases to provide more informative error messages

Reviewed Changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
website/docs/zh/plugins/webpack/entry-plugin.mdx Consolidates multi-line code example to single line for better readability
website/docs/en/plugins/webpack/entry-plugin.mdx Consolidates multi-line code example to single line for better readability
tests/rspack-test/rstest.config.ts Adds WASM-specific test configuration with appropriate test exclusions and concurrency settings
tests/rspack-test/package.json Updates test scripts to use full binary path and upgrades @rstest/core version
pnpm-lock.yaml Updates lockfile to reflect package version upgrades and new dependency additions
packages/rspack/src/ChunkGraph.ts Updates parameter names in compareFn signature with underscore prefix
packages/rspack-test-tools/src/test/creator.ts Adjusts WASM concurrency handling to use numeric value instead of boolean
packages/rspack-test-tools/src/helper/setup-env.ts Removes legacy Jest compatibility code for WASM tests
packages/rspack-test-tools/src/case/hash.ts Improves error messaging when stats are not found during hash test validation
package.json Updates @rstest/core version in root package.json
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@9aoy 9aoy enabled auto-merge (squash) November 10, 2025 05:48
@9aoy 9aoy merged commit 2c12f2a into main Nov 10, 2025
44 checks passed
@9aoy 9aoy deleted the 10-23-chore/rstest-wasm-test branch November 10, 2025 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants