fix(dts): correct tsconfig path not found error message (#740)

Author: fi3ework

packages/plugin-dts/src/index.ts

@@ -2,6 +2,7 @@ import { type ChildProcess, fork } from 'node:child_process';
 import { dirname, extname, join } from 'node:path';
 import { fileURLToPath } from 'node:url';
 import { type RsbuildConfig, type RsbuildPlugin, logger } from '@rsbuild/core';
+import color from 'picocolors';
 import ts from 'typescript';
 import { loadTsconfig, processSourceEntry } from './utils';
 
@@ -88,7 +89,9 @@ export const pluginDts = (options: PluginDtsOptions = {}): RsbuildPlugin => ({
         );
 
         if (!tsconfigPath) {
-          logger.error(`tsconfig.json not found in ${cwd}`);
+          logger.error(
+            `Failed to resolve tsconfig file ${color.cyan(`"${config.source.tsconfigPath}"`)} from ${color.cyan(cwd)}. Please ensure that the file exists.`,
+          );
           throw new Error();
         }
 

pnpm-lock.yaml

@@ -0,0 +1,6 @@
+{
+  "name": "dts-true-bundle-false-tsconfig-path-test",
+  "version": "1.0.0",
+  "private": true,
+  "type": "module"
+}

tests/integration/dts/bundle-false/tsconfig-path/package.json

@@ -0,0 +1,19 @@
+import { defineConfig } from '@rslib/core';
+import { generateBundleEsmConfig } from 'test-helper';
+
+export default defineConfig({
+  lib: [
+    generateBundleEsmConfig({
+      bundle: false,
+      dts: {
+        bundle: false,
+      },
+    }),
+  ],
+  source: {
+    entry: {
+      index: '../__fixtures__/src/index.ts',
+    },
+    tsconfigPath: '../path_not_exist/tsconfig.json',
+  },
+});

tests/integration/dts/bundle-false/tsconfig-path/rslib.config.ts

@@ -1,9 +1,11 @@
 import { existsSync } from 'node:fs';
 import { join } from 'node:path';
+import stripAnsi from 'strip-ansi';
 import {
   buildAndGetResults,
   createTempFiles,
   globContentJSON,
+  proxyConsole,
 } from 'test-helper';
 import { describe, expect, test } from 'vitest';
 
@@ -145,6 +147,21 @@ describe('dts when bundle: false', () => {
       ]
     `);
   });
+
+  test('should emit error when tsconfig not found', async () => {
+    const fixturePath = join(__dirname, 'bundle-false', 'tsconfig-path');
+    await createTempFiles(fixturePath, false);
+
+    const { logs, restore } = proxyConsole();
+    try {
+      await buildAndGetResults({ fixturePath, type: 'dts' });
+    } catch (err: any) {
+      expect(logs.map((log) => stripAnsi(log)).join('')).toMatchInlineSnapshot(
+        `"error   Failed to resolve tsconfig file "../path_not_exist/tsconfig.json" from <ROOT>/tests/integration/dts/bundle-false/tsconfig-path. Please ensure that the file exists."`,
+      );
+    }
+    restore();
+  });
 });
 
 describe('dts when bundle: true', () => {