feat: handle i18n public resources not redirect (#7862)

Author: caohuilin

packages/runtime/plugin-i18n/src/cli/index.ts

@@ -31,10 +31,24 @@ export const i18nPlugin = (
     });
 
     api._internalServerPlugins(({ plugins }) => {
+      const { serverRoutes } = api.getAppContext();
+
+      let staticRoutePrefixes: string[] = [];
+      if (serverRoutes && Array.isArray(serverRoutes)) {
+        // Get static route prefixes from 'public' directories
+        // 'public' routes are handled by static plugin
+        staticRoutePrefixes = serverRoutes
+          .filter(
+            route => !route.entryName && route.entryPath.startsWith('public'),
+          )
+          .map(route => route.urlPath)
+          .filter(Boolean);
+      }
       plugins.push({
         name: '@modern-js/plugin-i18n/server',
         options: {
           localeDetection,
+          staticRoutePrefixes,
         },
       });
       return { plugins };

packages/runtime/plugin-i18n/src/server/index.ts

@@ -10,6 +10,7 @@ import { getLocaleDetectionOptions } from '../shared/utils.js';
 
 export interface I18nPluginOptions {
   localeDetection: LocaleDetectionOptions;
+  staticRoutePrefixes: string[];
 }
 
 /**
@@ -77,6 +78,18 @@ const convertToHonoLanguageDetectorOptions = (
   };
 };
 
+/**
+ * Check if the given pathname is a static resource request
+ */
+const isStaticResourceRequest = (
+  pathname: string,
+  staticRoutePrefixes: string[],
+): boolean => {
+  return staticRoutePrefixes.some(
+    prefix => pathname.startsWith(`${prefix}/`) || pathname === prefix,
+  );
+};
+
 const getLanguageFromPath = (
   req: any,
   urlPath: string,
@@ -156,6 +169,7 @@ export const i18nServerPlugin = (options: I18nPluginOptions): ServerPlugin => ({
           fallbackLanguage = 'en',
           detection,
         } = getLocaleDetectionOptions(entryName, options.localeDetection);
+        const staticRoutePrefixes = options.staticRoutePrefixes;
         const originUrlPath = route.urlPath;
         const urlPath = originUrlPath.endsWith('/')
           ? `${originUrlPath}*`
@@ -168,17 +182,36 @@ export const i18nServerPlugin = (options: I18nPluginOptions): ServerPlugin => ({
               fallbackLanguage,
               detection,
             );
+            const detectorHandler = languageDetector(detectorOptions);
             middlewares.push({
               name: 'i18n-language-detector',
               path: urlPath,
-              handler: languageDetector(detectorOptions),
+              handler: async (c: Context, next: Next) => {
+                const url = new URL(c.req.url);
+                const pathname = url.pathname;
+
+                // For static resource requests, skip language detection
+                if (isStaticResourceRequest(pathname, staticRoutePrefixes)) {
+                  return await next();
+                }
+
+                return detectorHandler(c, next);
+              },
             });
           }
 
           middlewares.push({
             name: 'i18n-server-middleware',
             path: urlPath,
             handler: async (c: Context, next: Next) => {
+              const url = new URL(c.req.url);
+              const pathname = url.pathname;
+
+              // For static resource requests, skip i18n processing
+              if (isStaticResourceRequest(pathname, staticRoutePrefixes)) {
+                return await next();
+              }
+
               const language = getLanguageFromPath(c.req, urlPath, languages);
               if (!language) {
                 // Get detected language from languageDetector middleware

tests/integration/i18n/app-ssr/config/public/text.txt

@@ -0,0 +1 @@
+test public

tests/integration/i18n/app-ssr/tests/index.test.ts

@@ -87,4 +87,11 @@ describe('app-ssr-i18n', () => {
       { timeout: 10000 },
     );
   });
+  test('static-resource', async () => {
+    const response = await page.goto(`http://localhost:${appPort}/text.txt`, {
+      waitUntil: ['networkidle0'],
+    });
+    const body = await response?.text();
+    expect(body).toContain('test public');
+  });
 });