👌 Add some code review changes

Author: hirsch

.env.test

@@ -41,6 +41,7 @@ MUTATIONS=src/api/mutations/**/*Mutation.ts
 #
 GRAPHQL_ENABLED=true
 GRAPHQL_ROUTE=/graphql
+GRAPHQL_EDITOR=false
 
 #
 # Swagger

package-scripts.js

@@ -8,11 +8,11 @@ module.exports = {
     scripts: {
         default: 'nps start',
         /**
-         * Starts the builded app from the dist directory
+         * Starts the builded app from the dist directory.
          */
         start: {
-            script: 'cross-env NODE_ENV=production node dist/app.js',
-            description: 'Starts the builded app from the dist directory'
+            script: 'cross-env NODE_ENV=production node dist/src/app.js',
+            description: 'Starts the builded app',
         },
         /**
          * Serves the current app and watches for changes to restart it
@@ -274,7 +274,7 @@ function banner(name) {
 }
 
 function copy(source, target) {
-    return `copyup ${source} ${target}`;
+    return `copyfiles ${source} ${target}`;
 }
 
 function run(path) {

package.json

@@ -38,22 +38,6 @@
     }
   ],
   "dependencies": {
-    "@types/bcrypt": "^2.0.0",
-    "@types/bluebird": "^3.5.18",
-    "@types/chalk": "^2.2.0",
-    "@types/commander": "^2.11.0",
-    "@types/cors": "^2.8.1",
-    "@types/dotenv": "^4.0.2",
-    "@types/express": "^4.0.39",
-    "@types/faker": "^4.1.2",
-    "@types/figlet": "^1.2.0",
-    "@types/helmet": "0.0.41",
-    "@types/morgan": "^1.7.35",
-    "@types/reflect-metadata": "0.1.0",
-    "@types/serve-favicon": "^2.2.29",
-    "@types/supertest": "^2.0.4",
-    "@types/uuid": "^3.4.3",
-    "@types/winston": "^2.3.7",
     "bcrypt": "3.0.1",
     "chalk": "^2.4.1",
     "class-validator": "0.9.1",
@@ -112,8 +96,24 @@
   },
   "license": "MIT",
   "devDependencies": {
+    "@types/bcrypt": "^2.0.0",
+    "@types/bluebird": "^3.5.18",
+    "@types/chalk": "^2.2.0",
+    "@types/commander": "^2.11.0",
+    "@types/cors": "^2.8.1",
+    "@types/dotenv": "^4.0.2",
+    "@types/express": "^4.0.39",
+    "@types/faker": "^4.1.2",
+    "@types/figlet": "^1.2.0",
+    "@types/helmet": "0.0.41",
     "@types/jest": "23.3.2",
+    "@types/morgan": "^1.7.35",
     "@types/nock": "^9.1.3",
+    "@types/reflect-metadata": "0.1.0",
+    "@types/serve-favicon": "^2.2.29",
+    "@types/supertest": "^2.0.4",
+    "@types/uuid": "^3.4.3",
+    "@types/winston": "^2.3.7",
     "cross-env": "^5.1.1",
     "jest": "23.6.0",
     "mock-express-request": "^0.2.0",

src/env.ts

@@ -2,7 +2,9 @@ import * as dotenv from 'dotenv';
 import * as path from 'path';
 
 import * as pkg from '../package.json';
-import { getOsEnv, getOsPath, getOsPaths, normalizePort, toBool, toNumber } from './lib/env';
+import {
+    getOsEnv, getOsEnvOptional, getOsPath, getOsPaths, normalizePort, toBool, toNumber
+} from './lib/env';
 
 /**
  * Load .env file or for tests the .env.test file.
@@ -41,17 +43,17 @@ export const env = {
     },
     log: {
         level: getOsEnv('LOG_LEVEL'),
-        json: toBool(getOsEnv('LOG_JSON')),
+        json: toBool(getOsEnvOptional('LOG_JSON')),
         output: getOsEnv('LOG_OUTPUT'),
     },
     db: {
         type: getOsEnv('TYPEORM_CONNECTION'),
-        host: getOsEnv('TYPEORM_HOST'),
-        port: toNumber(getOsEnv('TYPEORM_PORT')),
-        username: getOsEnv('TYPEORM_USERNAME'),
-        password: getOsEnv('TYPEORM_PASSWORD'),
+        host: getOsEnvOptional('TYPEORM_HOST'),
+        port: toNumber(getOsEnvOptional('TYPEORM_PORT')),
+        username: getOsEnvOptional('TYPEORM_USERNAME'),
+        password: getOsEnvOptional('TYPEORM_PASSWORD'),
         database: getOsEnv('TYPEORM_DATABASE'),
-        synchronize: toBool(getOsEnv('TYPEORM_SYNCHRONIZE')),
+        synchronize: toBool(getOsEnvOptional('TYPEORM_SYNCHRONIZE')),
         logging: toBool(getOsEnv('TYPEORM_LOGGING')),
     },
     graphql: {

src/lib/env/utils.ts

@@ -1,9 +1,17 @@
 import { join } from 'path';
 
 export function getOsEnv(key: string): string {
+    if (typeof process.env[key] === 'undefined') {
+        throw new Error(`Environment variable ${key} is not set.`);
+    }
+
     return process.env[key] as string;
 }
 
+export function getOsEnvOptional(key: string): string | undefined {
+    return process.env[key];
+}
+
 export function getPath(path: string): string {
     return (process.env.NODE_ENV === 'production')
         ? join(process.cwd(), path.replace('src/', 'dist/').slice(0, -3) + '.js')