From fbad714ccb4f38336cc791faa928c344bfcd415e Mon Sep 17 00:00:00 2001
From: Marcos Caceres
Date: Tue, 30 Jul 2024 13:40:37 +1000
Subject: [PATCH 1/5] Add required mediation
---
index.html | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/index.html b/index.html
index c43c5057..d424d371 100644
--- a/index.html
+++ b/index.html
@@ -295,6 +295,15 @@
[=Consume user activation=] of |window|.
+
+ Validate |options| :
+
+ If |options|'s {{CredentialRequestOptions/mediation}} is not
+ {CredentialMediationRequirement/"required"}, [=exception/throw=] a
+ {{TypeError}}.
+
+
+
Details of how to actually get the [=digital credential=] are
From ae1df5c05c3055158ef3389a2bf6ef69091ec973 Mon Sep 17 00:00:00 2001
From: Marcos Caceres
Date: Wed, 21 Aug 2024 16:36:30 +1000
Subject: [PATCH 2/5] Set mediation requirement
---
index.html | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/index.html b/index.html
index d424d371..340096ad 100644
--- a/index.html
+++ b/index.html
@@ -230,6 +230,15 @@
The DigitalCredential interface represents a conceptual
[=digital credential=].
+
+ [=Request a credential|Requesting a `DigitalCredential` credential=] does
+ not support {{CredentialMediationRequirement/"conditional"}} [=user
+ mediation=]. [=User mediation=] is always
+ {{CredentialMediationRequirement/"required"}}. No other
+ {{CredentialMediationRequirement}} enum value is supported, apart from
+ {{CredentialMediationRequirement/"required"}}, and results in a
+ {{TypeError}} when {{CredentialsContainer/get()}} is called.
+
[Exposed=Window, SecureContext]
interface DigitalCredential : Credential {
@@ -295,15 +304,6 @@
[=Consume user activation=] of |window|.
-
- Validate |options| :
-
- If |options|'s {{CredentialRequestOptions/mediation}} is not
- {CredentialMediationRequirement/"required"}, [=exception/throw=] a
- {{TypeError}}.
-
-
-
Details of how to actually get the [=digital credential=] are
From 1b6198386da1714e61eda8d876941f7a702211d9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Marcos=20C=C3=A1ceres?=
Date: Fri, 23 Aug 2024 12:32:10 +1000
Subject: [PATCH 3/5] Update index.html
Co-authored-by: Ted Thibodeau Jr
---
index.html | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/index.html b/index.html
index 340096ad..74b15412 100644
--- a/index.html
+++ b/index.html
@@ -234,9 +234,9 @@
[=Request a credential|Requesting a `DigitalCredential` credential=] does
not support {{CredentialMediationRequirement/"conditional"}} [=user
mediation=]. [=User mediation=] is always
- {{CredentialMediationRequirement/"required"}}. No other
- {{CredentialMediationRequirement}} enum value is supported, apart from
- {{CredentialMediationRequirement/"required"}}, and results in a
+ {{CredentialMediationRequirement/"required"}}. The only supported
+ {{CredentialMediationRequirement}} enum value is
+ {{CredentialMediationRequirement/"required"}}, which results in a
{{TypeError}} when {{CredentialsContainer/get()}} is called.
From 533077c1d0f1cc6b96408b15da70b6ff927ad083 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Marcos=20C=C3=A1ceres?=
Date: Tue, 27 Aug 2024 11:26:42 +1000
Subject: [PATCH 4/5] Apply suggestions from code review
Co-authored-by: Sam Goto
---
index.html | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/index.html b/index.html
index 74b15412..95d52804 100644
--- a/index.html
+++ b/index.html
@@ -232,12 +232,12 @@
[=Request a credential|Requesting a `DigitalCredential` credential=] does
- not support {{CredentialMediationRequirement/"conditional"}} [=user
+ not support {{CredentialMediationRequirement/"conditional"}} and {{CredentialMediationRequirement/"optional"}} and {{CredentialMediationRequirement/"silent"}} [=user
mediation=]. [=User mediation=] is always
{{CredentialMediationRequirement/"required"}}. The only supported
{{CredentialMediationRequirement}} enum value is
{{CredentialMediationRequirement/"required"}}, which results in a
- {{TypeError}} when {{CredentialsContainer/get()}} is called.
+ {{TypeError}} when {{CredentialsContainer/get()}} is called with anything but {{CredentialMediationRequirement/"required"}}.
[Exposed=Window, SecureContext]
From 2e9b825bd07c7afed3eb72bd1021c96a9ee25119 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Marcos=20C=C3=A1ceres?=
Date: Tue, 27 Aug 2024 11:31:19 +1000
Subject: [PATCH 5/5] Update index.html
---
index.html | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/index.html b/index.html
index 95d52804..514b25dd 100644
--- a/index.html
+++ b/index.html
@@ -231,13 +231,8 @@
[=digital credential=].
- [=Request a credential|Requesting a `DigitalCredential` credential=] does
- not support {{CredentialMediationRequirement/"conditional"}} and {{CredentialMediationRequirement/"optional"}} and {{CredentialMediationRequirement/"silent"}} [=user
- mediation=]. [=User mediation=] is always
- {{CredentialMediationRequirement/"required"}}. The only supported
- {{CredentialMediationRequirement}} enum value is
- {{CredentialMediationRequirement/"required"}}, which results in a
- {{TypeError}} when {{CredentialsContainer/get()}} is called with anything but {{CredentialMediationRequirement/"required"}}.
+ [=User mediation=] is always {{CredentialMediationRequirement/"required"}}.
+ [=Request a credential|Requesting a DigitalCredential credential=] does not support {{CredentialMediationRequirement/"conditional"}}, {{CredentialMediationRequirement/"optional"}}, or {{CredentialMediationRequirement/"silent"}} [=user mediation=]. If {{CredentialsContainer/get()}} is called with anything other than {{CredentialMediationRequirement/"required"}}, a {{TypeError}} will be thrown.
[Exposed=Window, SecureContext]