udpate typings

Author: tkostuch

package.json

@@ -54,7 +54,7 @@
     "ajv-keywords": "^3.4.0",
     "body-parser": "^1.18.2",
     "bodybuilder": "2.2.21",
-    "commander": "^2.19.0",
+    "commander": "^5.1.0",
     "compression": "^1.7.2",
     "config": "^1.30.0",
     "cors": "^2.8.4",
@@ -98,9 +98,10 @@
   "devDependencies": {
     "@types/body-parser": "^1.17.0",
     "@types/config": "^0.0.34",
-    "@types/express": "^4.16.1",
-    "@types/jest": "^24.0.11",
-    "@types/node": "^11.13.4",
+    "@types/express": "^4.17.6",
+    "@types/express-serve-static-core": "^4.17.7",
+    "@types/jest": "^25.2.3",
+    "@types/node": "^14.0.5",
     "@typescript-eslint/eslint-plugin": "^1.7.1-alpha.17",
     "@typescript-eslint/parser": "^1.7.1-alpha.17",
     "apollo-server-express": "^1.3.6",

src/api/product.ts

@@ -22,7 +22,7 @@ export default ({ config, db }) => {
 
     if (!req.query.skus) { return apiStatus(res, 'skus parameter is required', 500); }
 
-    productProxy.list(req.query.skus.split(',')).then((result) => {
+    productProxy.list((req.query.skus as string).split(',')).then((result) => {
       apiStatus(res, result, 200);
     }).catch(err => {
       apiError(res, err);
@@ -37,7 +37,7 @@ export default ({ config, db }) => {
 
     if (!req.query.skus) { return apiStatus(res, 'skus parameter is required', 500); }
 
-    productProxy.renderList(req.query.skus.split(','), req.query.currencyCode, (req.query.storeId && parseInt(req.query.storeId) > 0) ? req.query.storeId : 1).then((result) => {
+    productProxy.renderList((req.query.skus as string).split(','), req.query.currencyCode, (req.query.storeId && parseInt((req.query.storeId as string)) > 0) ? req.query.storeId : 1).then((result) => {
       result.items = result.items.map((item) => {
         let sgnObj = item
         if (config.tax.calculateServerSide === true) {

src/api/stock.ts

@@ -65,7 +65,7 @@ export default ({ config, db }) => {
       return apiStatus(res, 'skus parameter is required', 500);
     }
 
-    const skuArray = req.query.skus.split(',')
+    const skuArray = (req.query.skus as string).split(',')
     const promisesList = []
     for (const sku of skuArray) {
       promisesList.push(stockProxy.check({sku: sku, stockId: config.msi.enabled ? _getStockId(req.query.storeCode) : null}))

src/api/user.ts

@@ -121,7 +121,7 @@ export default ({config, db}) => {
   userApi.post('/reset-password', (req, res) => {
     const userProxy = _getProxy(req)
     const { storeCode } = req.query
-    const websiteId = storeCode ? config.storeViews[storeCode].websiteId : undefined
+    const websiteId = storeCode ? config.storeViews[storeCode as string].websiteId : undefined
 
     if (!req.body.email) {
       return apiStatus(res, 'Invalid e-mail provided!', 500)

src/image/action/local/index.ts

@@ -25,10 +25,10 @@ export default class LocalImageAction extends ImageAction {
     let height: number
     let action: string
     if (this.req.query.url) { // url provided as the query param
-      imgUrl = decodeURIComponent(this.req.query.url)
-      width = parseInt(this.req.query.width)
-      height = parseInt(this.req.query.height)
-      action = this.req.query.action
+      imgUrl = decodeURIComponent(this.req.query.url as string)
+      width = parseInt(this.req.query.width as string)
+      height = parseInt(this.req.query.height as string)
+      action = this.req.query.action as string
     } else {
       let urlParts = this.req.url.split('/')
       width = parseInt(urlParts[1])

src/processor/default.ts

@@ -22,7 +22,7 @@ class HmacProcessor {
     const processorChain = []
     return new Promise((resolve, reject) => {
       const rs = items.map((item) => {
-        if (this._req.query._source_exclude && this._req.query._source_exclude.indexOf('sgn') < 0) {
+        if (this._req.query._source_exclude && (this._req.query._source_exclude as string[]).indexOf('sgn') < 0) {
           item._source.sgn = hmac.sign(item._source, this._config.get('objHashSecret')); // for products we sign off only price and id becase only such data is getting back with orders
         }
         return item

yarn.lock

@@ -402,12 +402,23 @@
     "@types/node" "*"
     "@types/range-parser" "*"
 
-"@types/express@^4.16.1":
-  version "4.17.0"
-  resolved "https://registry.yarnpkg.com/@types/express/-/express-4.17.0.tgz#49eaedb209582a86f12ed9b725160f12d04ef287"
+"@types/express-serve-static-core@^4.17.7":
+  version "4.17.7"
+  resolved "https://registry.yarnpkg.com/@types/express-serve-static-core/-/express-serve-static-core-4.17.7.tgz#dfe61f870eb549dc6d7e12050901847c7d7e915b"
+  integrity sha512-EMgTj/DF9qpgLXyc+Btimg+XoH7A2liE8uKul8qSmMTHCeNYzydDKFdsJskDvw42UsesCnhO63dO0Grbj8J4Dw==
+  dependencies:
+    "@types/node" "*"
+    "@types/qs" "*"
+    "@types/range-parser" "*"
+
+"@types/express@^4.17.6":
+  version "4.17.6"
+  resolved "https://registry.yarnpkg.com/@types/express/-/express-4.17.6.tgz#6bce49e49570507b86ea1b07b806f04697fac45e"
+  integrity sha512-n/mr9tZI83kd4azlPG5y997C/M4DNABK9yErhFM6hKdym4kkmd9j0vtsJyjFIwfRBxtrxZtAfGZCNRIBMFLK5w==
   dependencies:
     "@types/body-parser" "*"
     "@types/express-serve-static-core" "*"
+    "@types/qs" "*"
     "@types/serve-static" "*"
 
 "@types/graphql@^0.9.0":
@@ -462,6 +473,11 @@
   version "11.13.17"
   resolved "https://registry.yarnpkg.com/@types/node/-/node-11.13.17.tgz#2e7efbfe5253561087812571e5e6a1e4b1d6295b"
 
+"@types/qs@*":
+  version "6.9.3"
+  resolved "https://registry.yarnpkg.com/@types/qs/-/qs-6.9.3.tgz#b755a0934564a200d3efdf88546ec93c369abd03"
+  integrity sha512-7s9EQWupR1fTc2pSMtXRQ9w9gLOcrJn+h7HOXw4evxyvVqMi4f+q7d2tnFe3ng3SNHjtK+0EzGMGFUQX4/AQRA==
+
 "@types/range-parser@*":
   version "1.2.3"
   resolved "https://registry.yarnpkg.com/@types/range-parser/-/range-parser-1.2.3.tgz#7ee330ba7caafb98090bece86a5ee44115904c2c"