complete test coverage

Author: yyx990803

src/vuefire.js

@@ -38,6 +38,7 @@ function indexForKey (array, key) {
       return i
     }
   }
+  /* istanbul ignore next */
   return -1
 }
 
@@ -157,13 +158,24 @@ function unbind (vm, key) {
   vm._firebaseListeners[key] = null
 }
 
+/**
+ * Ensure the related bookkeeping variables on an instance.
+ *
+ * @param {Vue} vm
+ */
+function ensureRefs (vm) {
+  if (!vm.$firebaseRefs) {
+    vm.$firebaseRefs = Object.create(null)
+    vm._firebaseSources = Object.create(null)
+    vm._firebaseListeners = Object.create(null)
+  }
+}
+
 var VueFireMixin = {
   init: function () {
     var bindings = this.$options.firebase
     if (!bindings) return
-    this.$firebaseRefs = Object.create(null)
-    this._firebaseSources = Object.create(null)
-    this._firebaseListeners = Object.create(null)
+    ensureRefs(this)
     for (var key in bindings) {
       bind(this, key, bindings[key])
     }
@@ -196,6 +208,7 @@ function install (_Vue) {
 
   // extend instance methods
   Vue.prototype.$bindAsObject = function (key, source, cancelCallback) {
+    ensureRefs(this)
     bind(this, key, {
       source: source,
       asObject: true,
@@ -204,6 +217,7 @@ function install (_Vue) {
   }
 
   Vue.prototype.$bindAsArray = function (key, source, cancelCallback) {
+    ensureRefs(this)
     bind(this, key, {
       source: source,
       cancelCallback: cancelCallback
@@ -216,6 +230,7 @@ function install (_Vue) {
 }
 
 // auto install
+/* istanbul ignore if */
 if (typeof window !== 'undefined' && window.Vue) {
   install(window.Vue)
 }

tests/vuefire.spec.js

@@ -59,6 +59,30 @@ describe('VueFire', function () {
       })
     })
 
+    it('bind using $bindAsArray', function (done) {
+      var vm = new Vue({
+        template: '<div><div v-for="item in items">{{ item[".key"] }} {{ item.index }} </div></div>',
+        created: function () {
+          this.$bindAsArray('items', firebaseRef)
+        }
+      }).$mount()
+      firebaseRef.set({
+        first: { index: 0 },
+        second: { index: 1 },
+        third: { index: 2 }
+      }, function () {
+        expect(vm.items).to.deep.equal([
+          { '.key': 'first', index: 0 },
+          { '.key': 'second', index: 1 },
+          { '.key': 'third', index: 2 }
+        ])
+        Vue.nextTick(function () {
+          expect(vm.$el.textContent).to.contain('first 0 second 1 third 2')
+          done()
+        })
+      })
+    })
+
     it('binds array records which are primitives', function (done) {
       var vm = new Vue({
         firebase: {
@@ -504,6 +528,28 @@ describe('VueFire', function () {
       })
     })
 
+    it('binds with $bindAsObject', function (done) {
+      var obj = {
+        first: { index: 0 },
+        second: { index: 1 },
+        third: { index: 2 }
+      }
+      var vm = new Vue({
+        template: '<div>{{ items | json }}</div>',
+        created: function () {
+          this.$bindAsObject('items', firebaseRef.child('items'))
+        }
+      }).$mount()
+      firebaseRef.child('items').set(obj, function () {
+        obj['.key'] = 'items'
+        expect(vm.items).to.deep.equal(obj)
+        Vue.nextTick(function () {
+          expect(vm.$el.textContent).to.contain(JSON.stringify(obj, null, 2))
+          done()
+        })
+      })
+    })
+
     it('binds to a primitive', function (done) {
       var vm = new Vue({
         firebase: {
@@ -700,6 +746,13 @@ describe('VueFire', function () {
       }).to.throw(/not bound to a Firebase reference/)
     })
 
+    it('should work properly for instances with no firebase bindings', function () {
+      expect(function () {
+        var vm = new Vue()
+        vm.$destroy()
+      }).not.to.throw()
+    })
+
     it('unbinds the state bound to Firebase as an array', function (done) {
       var vm = new Vue({
         firebase: {