chore(core): lint --fix

Author: posva

packages/@posva/vuefire-core/package.json

@@ -24,7 +24,7 @@
     "pretest": "npm run lint",
     "test": "npm run unit",
     "unit": "jest",
-    "lint": "eslint --fix --ext=js,html src test",
+    "lint": "eslint --fix src test",
     "dev": "npm run unit -- --watchAll"
   },
   "bugs": {

packages/@posva/vuefire-core/src/index.js

@@ -1,6 +1,6 @@
 import { createSnapshot, extractRefs, callOnceWithArg, walkGet, walkSet } from './utils'
 
-function unsubscribeAll(subs) {
+function unsubscribeAll (subs) {
   for (const sub in subs) {
     subs[sub].unsub()
   }
@@ -9,7 +9,7 @@ function unsubscribeAll(subs) {
 // NOTE not convinced by the naming of subscribeToRefs and subscribeToDocument
 // first one is calling the other on every ref and subscribeToDocument may call
 // updateDataFromDocumentSnapshot which may call subscribeToRefs as well
-function subscribeToRefs({ subs, refs, target, path, data, depth, ops, resolve }, options) {
+function subscribeToRefs ({ subs, refs, target, path, data, depth, ops, resolve }, options) {
   const refKeys = Object.keys(refs)
   const missingKeys = Object.keys(subs).filter(refKey => refKeys.indexOf(refKey) < 0)
   // unbind keys that are no longer there
@@ -22,7 +22,7 @@ function subscribeToRefs({ subs, refs, target, path, data, depth, ops, resolve }
   let resolvedCount = 0
   const totalToResolve = refKeys.length
   const validResolves = Object.create(null)
-  function deepResolve(key) {
+  function deepResolve (key) {
     if (key in validResolves) {
       if (++resolvedCount >= totalToResolve) resolve(path)
     }
@@ -50,16 +50,16 @@ function subscribeToRefs({ subs, refs, target, path, data, depth, ops, resolve }
           path: docPath,
           depth,
           ops,
-          resolve: deepResolve.bind(null, docPath),
+          resolve: deepResolve.bind(null, docPath)
         },
         options
       ),
-      path: ref.path,
+      path: ref.path
     }
   })
 }
 
-export function bindCollection(
+export function bindCollection (
   { vm, key, collection, ops, resolve, reject },
   options = { maxRefDepth: 2 }
 ) {
@@ -92,7 +92,7 @@ export function bindCollection(
           path: newIndex,
           depth: 0,
           ops,
-          resolve: resolve.bind(null, doc),
+          resolve: resolve.bind(null, doc)
         },
         options
       )
@@ -117,7 +117,7 @@ export function bindCollection(
           target: array,
           path: newIndex,
           depth: 0,
-          resolve,
+          resolve
         },
         options
       )
@@ -127,7 +127,7 @@ export function bindCollection(
       ops.remove(array, oldIndex)
       // array.splice(oldIndex, 1)
       unsubscribeAll(arraySubs.splice(oldIndex, 1)[0])
-    },
+    }
   }
 
   const unbind = collection.onSnapshot(ref => {
@@ -171,7 +171,7 @@ export function bindCollection(
   }
 }
 
-function updateDataFromDocumentSnapshot(
+function updateDataFromDocumentSnapshot (
   { snapshot, target, path, subs, ops, depth = 0, resolve },
   options = { maxRefDepth: 2 }
 ) {
@@ -188,13 +188,13 @@ function updateDataFromDocumentSnapshot(
       path,
       ops,
       depth,
-      resolve,
+      resolve
     },
     options
   )
 }
 
-function subscribeToDocument({ ref, target, path, depth, resolve, ops }, options) {
+function subscribeToDocument ({ ref, target, path, depth, resolve, ops }, options) {
   const subs = Object.create(null)
   const unbind = ref.onSnapshot(doc => {
     if (doc.exists) {
@@ -206,7 +206,7 @@ function subscribeToDocument({ ref, target, path, depth, resolve, ops }, options
           ops,
           subs,
           depth,
-          resolve,
+          resolve
         },
         options
       )
@@ -234,7 +234,7 @@ function subscribeToDocument({ ref, target, path, depth, resolve, ops }, options
  * @param {OperationsType<any>} ops
  * @param {*} options
  */
-export function bindDocument({ vm, key, document, resolve, reject, ops }, options) {
+export function bindDocument ({ vm, key, document, resolve, reject, ops }, options) {
   // TODO warning check if key exists?
   // const boundRefs = Object.create(null)
 
@@ -252,7 +252,7 @@ export function bindDocument({ vm, key, document, resolve, reject, ops }, option
           path: key,
           subs,
           ops,
-          resolve,
+          resolve
         },
         options
       )

packages/@posva/vuefire-core/src/utils.js

@@ -6,10 +6,10 @@
  * @param {firebase.firestore.DocumentSnapshot} doc
  * @return {DocumentData}
  */
-export function createSnapshot(doc) {
+export function createSnapshot (doc) {
   // defaults everything to false, so no need to set
   return Object.defineProperty(doc.data(), 'id', {
-    value: doc.id,
+    value: doc.id
   })
 }
 
@@ -18,7 +18,7 @@ export function createSnapshot(doc) {
  * @param {any} o
  * @returns {boolean}
  */
-function isObject(o) {
+function isObject (o) {
   return o && typeof o === 'object'
 }
 
@@ -28,7 +28,7 @@ function isObject(o) {
  * should be o is Date https://github.com/Microsoft/TypeScript/issues/26297
  * @returns {boolean}
  */
-function isTimestamp(o) {
+function isTimestamp (o) {
   return o.toDate
 }
 
@@ -37,7 +37,7 @@ function isTimestamp(o) {
  * @param {*} o
  * @returns {boolean}
  */
-function isRef(o) {
+function isRef (o) {
   return o && o.onSnapshot
 }
 
@@ -49,7 +49,7 @@ function isRef(o) {
  * @param {[firebase.firestore.DocumentData, Record<string, Reference>]} result
  * @returns {[firebase.firestore.DocumentData, Record<string, Reference>]}
  */
-export function extractRefs(doc, oldDoc = {}, path = '', result = [{}, {}]) {
+export function extractRefs (doc, oldDoc = {}, path = '', result = [{}, {}]) {
   // must be set here because walkGet can return null or undefined
   oldDoc = oldDoc || {}
   const idDescriptor = Object.getOwnPropertyDescriptor(doc, 'id')
@@ -92,7 +92,7 @@ export function extractRefs(doc, oldDoc = {}, path = '', result = [{}, {}]) {
  * @param {() => T} argFn
  * @returns {() => K | undefined}
  */
-export function callOnceWithArg(fn, argFn) {
+export function callOnceWithArg (fn, argFn) {
   /** @type {boolean | undefined} */
   let called
   return () => {
@@ -109,7 +109,7 @@ export function callOnceWithArg(fn, argFn) {
  * @param {string} path
  * @returns {any}
  */
-export function walkGet(obj, path) {
+export function walkGet (obj, path) {
   return path.split('.').reduce((target, key) => target[key], obj)
 }
 
@@ -120,7 +120,7 @@ export function walkGet(obj, path) {
  * @param {any} value
  * @returns
  */
-export function walkSet(obj, path, value) {
+export function walkSet (obj, path, value) {
   // path can be a number
   const keys = ('' + path).split('.')
   const key = keys.pop()

packages/@posva/vuefire-core/test/collection.spec.js

@@ -76,7 +76,7 @@ describe('collections', () => {
         configurable: false,
         enumerable: false,
         writable: false,
-        value: `u${i}`,
+        value: `u${i}`
       })
     })
   })

packages/@posva/vuefire-core/test/document.spec.js

@@ -42,7 +42,7 @@ describe('documents', () => {
       configurable: false,
       enumerable: false,
       writable: false,
-      value: 'some-id',
+      value: 'some-id'
     })
   })
 

packages/@posva/vuefire-core/test/refs-collections.spec.js

@@ -8,7 +8,7 @@ describe('refs in collections', () => {
       items: null,
       a: null,
       b: null,
-      c: null,
+      c: null
     }
     ops = createOps(walkSet)
     bind = (key, collection, options) => {
@@ -29,7 +29,7 @@ describe('refs in collections', () => {
   it('binds refs on collections', async () => {
     await bind('items', collection)
 
-    expect(vm.items).toEqual([{ ref: { isA: true } }, { ref: { isB: true } }])
+    expect(vm.items).toEqual([{ ref: { isA: true }}, { ref: { isB: true }}])
   })
 
   it('waits for array to be fully populated', async () => {
@@ -42,9 +42,9 @@ describe('refs in collections', () => {
 
     expect(data).toEqual(vm.items)
     expect(vm.items).toEqual([
-      { ref: { isA: true } },
-      { ref: { isB: true } },
-      { ref: { isC: true } },
+      { ref: { isA: true }},
+      { ref: { isB: true }},
+      { ref: { isC: true }}
     ])
   })
 
@@ -58,9 +58,9 @@ describe('refs in collections', () => {
     await delay(5)
 
     expect(vm.items).toEqual([
-      { ref: { isA: true } },
-      { ref: { isB: true } },
-      { ref: { isC: true } },
+      { ref: { isA: true }},
+      { ref: { isB: true }},
+      { ref: { isC: true }}
     ])
   })
 
@@ -87,7 +87,7 @@ describe('refs in collections', () => {
   it('unbinds nested refs when the collection is unbound', async () => {
     const items = db.collection()
     const spyA = spyUnbind(a)
-    await items.add({ ref: { ref: a } })
+    await items.add({ ref: { ref: a }})
     await bind('items', items)
 
     expect(spyA).toHaveBeenCalledTimes(0)
@@ -127,7 +127,7 @@ describe('refs in collections', () => {
     await first.update({ newThing: true })
     await delay(5)
 
-    expect(vm.items).toEqual([{ ref: { isA: true }, newThing: true }, { ref: { isB: true } }])
+    expect(vm.items).toEqual([{ ref: { isA: true }, newThing: true }, { ref: { isB: true }}])
   })
 
   it('keeps old data of refs when modifying an item', async () => {
@@ -136,7 +136,7 @@ describe('refs in collections', () => {
 
     expect(vm.items[0]).toEqual({
       ref: { isA: true },
-      newThing: true,
+      newThing: true
     })
   })
 
@@ -156,9 +156,9 @@ describe('refs in collections', () => {
     expect(vm.items).toEqual([
       {
         a: {
-          b: b.path,
-        },
-      },
+          b: b.path
+        }
+      }
     ])
 
     await bind('items', collection, { maxRefDepth: 3 })
@@ -167,11 +167,11 @@ describe('refs in collections', () => {
         a: {
           b: {
             c: {
-              d: d.path,
-            },
-          },
-        },
-      },
+              d: d.path
+            }
+          }
+        }
+      }
     ])
   })
 
@@ -190,13 +190,13 @@ describe('refs in collections', () => {
             item: {
               item: {
                 item: {
-                  item: item.path,
-                },
-              },
-            },
-          },
-        },
-      },
+                  item: item.path
+                }
+              }
+            }
+          }
+        }
+      }
     ])
   })
 })