refactor: stricter ssr data

Author: posva

src/database/useDatabaseRef.ts

@@ -12,6 +12,7 @@ import {
   getCurrentInstance,
   onServerPrefetch,
 } from 'vue-demi'
+import { useFirebaseApp } from '../app'
 import {
   _MaybeRef,
   _Nullable,
@@ -62,7 +63,13 @@ export function _useDatabaseRef(
   }
 
   // set the initial value from SSR even if the ref comes from outside
-  data.value = getInitialValue(initialSourceValue, options.ssrKey, data.value)
+  // TODO: firebase app name
+  data.value = getInitialValue(
+    initialSourceValue,
+    options.ssrKey,
+    data.value,
+    useFirebaseApp()
+  )
 
   const error = ref<Error>()
   const pending = ref(true)

src/firestore/useFirestoreRef.ts

@@ -17,6 +17,7 @@ import {
   onServerPrefetch,
   onScopeDispose,
 } from 'vue-demi'
+import { useFirebaseApp } from '../app'
 import {
   _MaybeRef,
   _Nullable,
@@ -80,7 +81,13 @@ export function _useFirestoreRef(
   }
 
   // set the initial value from SSR even if the ref comes from outside
-  data.value = getInitialValue(initialSourceValue, options.ssrKey, data.value)
+  // TODO: allow passing firebase app name
+  data.value = getInitialValue(
+    initialSourceValue,
+    options.ssrKey,
+    data.value,
+    useFirebaseApp()
+  )
 
   const pending = ref(true)
   const error = ref<FirestoreError>()

src/ssr/initialState.ts

@@ -41,8 +41,8 @@ const initialStatesMap = new WeakMap<FirebaseApp, SSRStore>()
  * @returns the initial states for the current firebaseApp
  */
 export function useSSRInitialState(
-  initialState?: SSRStore,
-  firebaseApp: FirebaseApp = useFirebaseApp()
+  initialState: SSRStore | undefined,
+  firebaseApp: FirebaseApp
 ): SSRStore {
   // get initial state based on the current firebase app
   if (!initialStatesMap.has(firebaseApp)) {
@@ -60,15 +60,16 @@ export function getInitialValue(
     _FirestoreDataSource | DatabaseReference | DatabaseQuery | StorageReference
   >,
   ssrKey: string | undefined,
-  fallbackValue: unknown
+  fallbackValue: unknown,
+  firebaseApp: FirebaseApp
 ) {
   if (!dataSource) return fallbackValue
 
   const [sourceType, path] = getDataSourceInfo(dataSource)
   if (!sourceType) return fallbackValue
 
   const initialState: Record<string, unknown> =
-    useSSRInitialState()[sourceType] || {}
+    useSSRInitialState(undefined, firebaseApp)[sourceType] || {}
   const key = ssrKey || path
 
   // TODO: warn for queries on the client if there are other keys and this is during hydration
@@ -82,14 +83,18 @@ export function deferInitialValueSetup(
     _FirestoreDataSource | DatabaseReference | DatabaseQuery | StorageReference
   >,
   ssrKey: string | undefined | null,
-  promise: Promise<unknown>
+  promise: Promise<unknown>,
+  firebaseApp: FirebaseApp
 ) {
   if (!dataSource) return
 
   const [sourceType, path] = getDataSourceInfo(dataSource)
   if (!sourceType) return
 
-  const initialState: Record<string, unknown> = useSSRInitialState()[sourceType]
+  const initialState: Record<string, unknown> = useSSRInitialState(
+    undefined,
+    firebaseApp
+  )[sourceType]
   const key = ssrKey || path
 
   if (key) {

src/ssr/plugin.ts

@@ -36,7 +36,7 @@ export function addPendingPromise(
   const pendingPromises = appPendingPromises.get(app)!
 
   // TODO: skip this outside of SSR
-  const key = deferInitialValueSetup(dataSource, ssrKey, promise)
+  const key = deferInitialValueSetup(dataSource, ssrKey, promise, app)
   if (key) {
     pendingPromises.set(key, promise)
   } else {

src/storage/index.ts

@@ -53,7 +53,8 @@ export function useStorageFileUrl(
   url.value = getInitialValue(
     initialSourceValue,
     undefined,
-    url.value
+    url.value,
+    useFirebaseApp()
   ) as string
   const promise = ref<Promise<string | null>>(Promise.resolve(null))
   // TODO: pending and error states?
@@ -108,7 +109,8 @@ export function useStorageFileMetadata(
       initialSourceValue,
       // 'm ' is a prefix to differentiate from urls since both are stored in the same object
       'm ' + initialSourceValue.toString(),
-      metadata.value
+      metadata.value,
+      useFirebaseApp()
     ) as FullMetadata
   }
   const promise = shallowRef<Promise<FullMetadata | null>>(