Skip to content

Commit a03f5ca

Browse files
committed
refactor(bundler): add eslint
1 parent bbdc656 commit a03f5ca

File tree

5 files changed

+25
-22
lines changed

5 files changed

+25
-22
lines changed

packages/@posva/vuefire-bundler/package.json

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@
1212
"files": [
1313
"src"
1414
],
15+
"scripts": {
16+
"lint": "eslint --fix src"
17+
},
1518
"publishConfig": {
1619
"access": "public"
1720
},
@@ -27,9 +30,11 @@
2730
"rollup": "^0.64.1",
2831
"rollup-plugin-buble": "^0.19.2",
2932
"rollup-plugin-node-resolve": "^3.3.0",
30-
"shelljs": "^0.8.2"
33+
"shelljs": "^0.8.2",
34+
"uglify-js": "^3.4.7"
3135
},
3236
"devDependencies": {
33-
"eslint": "^5.3.0"
37+
"eslint": "^5.3.0",
38+
"eslint-plugin-vue-libs": "^3.0.0"
3439
}
3540
}

packages/@posva/vuefire-bundler/src/index.js

Lines changed: 14 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -13,16 +13,14 @@ const packageData = require(join(cwd, 'package.json'))
1313
const { version, author, name } = packageData
1414
// remove the email at the end
1515
const authorName = author.name
16-
const moduleName = 'Vuefire'
17-
console.log({ name, author, moduleName })
1816

1917
// Make sure dist dir exists
2018
const distFolder = join(cwd, 'dist')
2119
mkdirp(distFolder)
2220

2321
const bundleOptions = {
2422
exports: 'auto',
25-
format: 'umd',
23+
format: 'umd'
2624
}
2725

2826
const plugins = [
@@ -31,20 +29,20 @@ const plugins = [
3129
// // 'process.env.NODE_ENV': '"development"',
3230
// }),
3331
resolve({
34-
extensions: ['.js', '.vue', '.jsx', '.json'],
32+
extensions: ['.js', '.vue', '.jsx', '.json']
3533
}),
3634
buble({
3735
objectAssign: 'Object.assign',
3836
transforms: {
39-
dangerousForOf: true,
40-
},
41-
}),
37+
dangerousForOf: true
38+
}
39+
})
4240
]
4341

44-
function createBundle({ filename, format, moduleName, banner }) {
42+
function createBundle ({ filename, format, moduleName, banner }) {
4543
rollup({
4644
input: join(cwd, 'src/index.js'),
47-
plugins,
45+
plugins
4846
})
4947
.then(bundle => {
5048
const options = Object.assign({ banner, name: moduleName }, bundleOptions)
@@ -56,8 +54,8 @@ function createBundle({ filename, format, moduleName, banner }) {
5654
const minified = uglify.minify(code, {
5755
output: {
5856
preamble: banner,
59-
ascii_only: true,
60-
},
57+
ascii_only: true
58+
}
6159
}).code
6260
return write(`${distFolder}/${filename}.js`, minified)
6361
} else {
@@ -67,7 +65,7 @@ function createBundle({ filename, format, moduleName, banner }) {
6765
.catch(logError)
6866
}
6967

70-
module.exports = function run(moduleName) {
68+
module.exports = function run (moduleName) {
7169
const banner =
7270
'/*!\n' +
7371
` * ${name} v${version}\n` +
@@ -79,7 +77,7 @@ module.exports = function run(moduleName) {
7977
createBundle({
8078
banner,
8179
filename: name,
82-
moduleName,
80+
moduleName
8381
})
8482

8583
// Commonjs bundle (preserves process.env.NODE_ENV) so
@@ -88,20 +86,20 @@ module.exports = function run(moduleName) {
8886
banner,
8987
filename: `${name}.esm`,
9088
format: 'es',
91-
moduleName,
89+
moduleName
9290
})
9391

9492
createBundle({
9593
banner,
9694
filename: `${name}.common`,
9795
format: 'cjs',
98-
moduleName,
96+
moduleName
9997
})
10098

10199
// Minified version for browser
102100
createBundle({
103101
banner,
104102
filename: `${name}.min`,
105-
moduleName,
103+
moduleName
106104
})
107105
}

packages/@posva/vuefire-bundler/src/utils/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,5 @@ const { logError } = require('./log.js')
33

44
module.exports = {
55
write,
6-
logError,
6+
logError
77
}

packages/@posva/vuefire-bundler/src/utils/log.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,5 +23,5 @@ module.exports = {
2323
green,
2424
red,
2525
yellow,
26-
logError,
26+
logError
2727
}

packages/@posva/vuefire-bundler/src/utils/write.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ const fs = require('fs')
22

33
const { blue } = require('./log.js')
44

5-
function write(dest, code) {
5+
function write (dest, code) {
66
return new Promise((resolve, reject) => {
77
fs.writeFile(dest, code, err => {
88
if (err) return reject(err)
@@ -12,7 +12,7 @@ function write(dest, code) {
1212
})
1313
}
1414

15-
function getSize(code) {
15+
function getSize (code) {
1616
return (code.length / 1024).toFixed(2) + 'kb'
1717
}
1818

0 commit comments

Comments
 (0)