fix(bind): do not extract refs on geopoints

Fix #179

Author: posva

src/utils.js

@@ -27,7 +27,10 @@ export function extractRefs (doc, oldDoc, path = '', result = [{}, {}]) {
       // TODO handle array
       tot[0][key] = Array(ref.length).fill(null)
       extractRefs(ref, oldDoc[key], path + key + '.', [tot[0][key], tot[1]])
-    } else if (ref instanceof Date) {
+    } else if (
+      ref instanceof Date ||
+      (ref.longitude && ref.latitude) // GeoPoint
+    ) {
       tot[0][key] = ref
     } else if (isObject(ref)) {
       tot[0][key] = {}

test/helpers/mock.js

@@ -1,3 +1,16 @@
+export class GeoPoint {
+  constructor (lat, long) {
+    this._lat = lat
+    this._long = long
+  }
+
+  get latitude () {
+    return this._lat
+  }
+  get longitude () {
+    return this._long
+  }
+}
 export class DocumentSnapshot {
   constructor (firestore, key, document, exists) {
     this._firestore = firestore

test/utils.spec.js

@@ -1,14 +1,5 @@
-import {
-  createSnapshot,
-  extractRefs
-} from '../src/utils'
-import {
-  Key,
-  db,
-  _id,
-  DocumentReference,
-  DocumentSnapshot
-} from './helpers'
+import { createSnapshot, extractRefs } from '../src/utils'
+import { Key, db, _id, DocumentReference, GeoPoint, DocumentSnapshot } from './helpers'
 
 let id, doc, snapshot, collection, docRef
 beforeEach(() => {
@@ -60,8 +51,19 @@ test('leave Date objects alone when extracting refs', () => {
     foo: 1,
     bar: d
   })
-  expect(doc.foo).toEqual(1)
-  expect(doc.bar).toEqual(d)
+  expect(doc.foo).toBe(1)
+  expect(doc.bar).toBe(d)
+  expect(refs).toEqual({})
+})
+
+test('leave GeoPoint objects alone when extracting refs', () => {
+  const d = new GeoPoint(2, 48)
+  const [doc, refs] = extractRefs({
+    foo: 1,
+    bar: d
+  })
+  expect(doc.foo).toBe(1)
+  expect(doc.bar).toBe(d)
   expect(refs).toEqual({})
 })
 
@@ -99,11 +101,7 @@ test('extracts refs from array', async () => {
     index: 0
   })
   const [noRefsDoc, refs] = extractRefs({
-    arr: [
-      docRef,
-      docRef2,
-      docRef
-    ]
+    arr: [docRef, docRef2, docRef]
   })
   expect(noRefsDoc.arr[0]).toEqual(docRef.path)
   expect(noRefsDoc.arr[1]).toEqual(docRef2.path)