directive: always call update + ensure modifiers

Author: yyx990803

src/core/vdom/modules/directives.js

@@ -17,6 +17,8 @@ export default {
   }
 }
 
+const emptyModifiers = Object.create(null)
+
 function applyDirectives (
   oldVnode: VNodeWithData,
   vnode: VNodeWithData,
@@ -31,12 +33,11 @@ function applyDirectives (
       const def = resolveAsset(vnode.context.$options, 'directives', dir.name, true)
       const fn = def && def[hook]
       if (fn) {
-        // only call update if value has changed
         if (isUpdate && oldDirs) {
-          const oldValue = dir.oldValue = oldDirs[i].value
-          if (oldValue === dir.value) {
-            continue
-          }
+          dir.oldValue = oldDirs[i].value
+        }
+        if (!dir.modifiers) {
+          dir.modifiers = emptyModifiers
         }
         fn(vnode.elm, dir, vnode, oldVnode)
       }

test/unit/features/options/directives.spec.js

@@ -35,9 +35,11 @@ describe('Options directives', () => {
             expect(el).toBe(vm.$el)
             expect(oldVnode).toBe(vm._vnode)
             expect(oldVnode).not.toBe(vnode)
-            expect(binding.value).toBe('bar')
-            expect(binding.oldValue).toBe('foo')
             expect(binding.expression).toBe('a')
+            if (binding.value !== binding.oldValue) {
+              expect(binding.value).toBe('bar')
+              expect(binding.oldValue).toBe('foo')
+            }
           },
           componentUpdated (el, binding, vnode) {
             componentUpdatedSpy()

test/unit/modules/vdom/modules/attrs.spec.js

@@ -2,7 +2,7 @@ import { patch } from 'web/runtime/patch'
 import VNode from 'core/vdom/vnode'
 import { xlinkNS } from 'web/util/index'
 
-describe('attrs module', () => {
+describe('vdom attrs module', () => {
   it('should create an element with staticAttrs', () => {
     const vnode = new VNode('p', { staticAttrs: { id: 1, class: 'class1' }})
     const elm = patch(null, vnode)

test/unit/modules/vdom/modules/class.spec.js

@@ -1,7 +1,7 @@
 import { patch } from 'web/runtime/patch'
 import VNode from 'core/vdom/vnode'
 
-describe('class module', () => {
+describe('vdom class module', () => {
   it('shuold create an element with staticClass', () => {
     const vnode = new VNode('p', { staticClass: 'class1' })
     const elm = patch(null, vnode)

test/unit/modules/vdom/modules/directive.spec.js

@@ -2,8 +2,8 @@ import Vue from 'vue'
 import { patch } from 'web/runtime/patch'
 import VNode from 'core/vdom/vnode'
 
-describe('directive module', () => {
-  it('should work directive', () => {
+describe('vdom directive module', () => {
+  it('should work', () => {
     const directive1 = {
       bind: jasmine.createSpy('bind'),
       update: jasmine.createSpy('update'),
@@ -35,28 +35,4 @@ describe('directive module', () => {
     patch(vnode2, vnode3)
     expect(directive1.unbind).toHaveBeenCalled()
   })
-
-  it('should not update when same binding value', () => {
-    const directive1 = {
-      update: jasmine.createSpy('update')
-    }
-    const vm = new Vue({ directives: { directive1 }})
-    const vnode1 = new VNode('div', {}, [
-      new VNode('p', {
-        directives: [{
-          name: 'directive1', value: 'hello', arg: 'arg1', modifiers: { modifire1: true }
-        }]
-      }, undefined, 'hello world', undefined, undefined, vm)
-    ])
-    const vnode2 = new VNode('div', {}, [
-      new VNode('p', {
-        directives: [{
-          name: 'directive1', value: 'hello', arg: 'arg1', modifiers: { modifire1: true }
-        }]
-      }, undefined, 'hello world', undefined, undefined, vm)
-    ])
-    patch(null, vnode1)
-    patch(vnode1, vnode2)
-    expect(directive1.update).not.toHaveBeenCalled()
-  })
 })

test/unit/modules/vdom/modules/events.spec.js

@@ -1,7 +1,7 @@
 import { patch } from 'web/runtime/patch'
 import VNode from 'core/vdom/vnode'
 
-describe('events module', () => {
+describe('vdom events module', () => {
   it('should attach event handler to element', () => {
     const click = jasmine.createSpy()
     const vnode = new VNode('a', { on: { click }})

test/unit/modules/vdom/modules/props.spec.js

@@ -1,7 +1,7 @@
 import { patch } from 'web/runtime/patch'
 import VNode from 'core/vdom/vnode'
 
-describe('props module', () => {
+describe('vdom props module', () => {
   it('should create an element with props', () => {
     const vnode = new VNode('a', { props: { src: 'http://localhost/' }})
     const elm = patch(null, vnode)

test/unit/modules/vdom/modules/style.spec.js

@@ -1,7 +1,7 @@
 import { patch } from 'web/runtime/patch'
 import VNode from 'core/vdom/vnode'
 
-describe('style module', () => {
+describe('vdom style module', () => {
   it('should create an element with style', () => {
     const vnode = new VNode('p', { style: { fontSize: '12px' }})
     const elm = patch(null, vnode)