fix #610 transclusion + partial throws error in $destroy

Author: yyx990803

src/api/lifecycle.js

@@ -82,9 +82,10 @@ exports.$destroy = function (remove, deferCleanup) {
     }
   }
   // teardown all directives. this also tearsdown all
-  // directive-owned watchers.
-  i = this._directives.length
-  while (i--) {
+  // directive-owned watchers. intentionally check for
+  // directives array length on every loop since directives
+  // that manages partial compilation can splice ones out
+  for (i = 0; i < this._directives.length; i++) {
     this._directives[i]._teardown()
   }
   // teardown all user watchers.

test/unit/specs/api/lifecycle_spec.js

@@ -254,6 +254,23 @@ if (_.inBrowser) {
         expect(spy.calls.count()).toBe(1)
       })
 
+      it('safely teardown partial compilation', function () {
+        var vm = new Vue({
+          template: '<div v-component="dialog"><div v-partial="hello"></div></div>',
+          partials: {
+            hello: 'Hello {{name}}'
+          },
+          components: {
+            dialog: {
+              template: '<content>'
+            }
+          }
+        }).$mount()
+        expect(function () {
+          vm.$destroy()
+        }).not.toThrow()
+      })
+
     })
 
     describe('$compile', function () {