fix(compiler-core): should not remove slot node with v-else (#11150)

kermanx · web-flow · commit e102670bde00 · 2024-06-22T17:08:39.000+08:00
diff --git a/packages/compiler-core/__tests__/transforms/vSlot.spec.ts b/packages/compiler-core/__tests__/transforms/vSlot.spec.ts
@@ -696,6 +696,7 @@ describe('compiler: transform component slots', () => {
     expect((root as any).children[0].codegenNode.patchFlag).toMatch(
       PatchFlags.DYNAMIC_SLOTS + '',
     )
+    expect((root as any).children[0].children.length).toBe(3)
     expect(generate(root).code).toMatchSnapshot()
   })
 
diff --git a/packages/compiler-core/src/transforms/vSlot.ts b/packages/compiler-core/src/transforms/vSlot.ts
@@ -226,10 +226,7 @@ export function buildSlots(
           break
         }
       }
-      if (prev && isTemplateNode(prev) && findDir(prev, 'if')) {
-        // remove node
-        children.splice(i, 1)
-        i--
+      if (prev && isTemplateNode(prev) && findDir(prev, /^(else-)?if$/)) {
         __TEST__ && assert(dynamicSlots.length > 0)
         // attach this slot to previous conditional
         let conditional = dynamicSlots[

Original file line number	Diff line number	Diff line change
`@@ -696,6 +696,7 @@ describe('compiler: transform component slots', () => {`
`696`	`696`	`expect((root as any).children[0].codegenNode.patchFlag).toMatch(`
`697`	`697`	`PatchFlags.DYNAMIC_SLOTS + '',`
`698`	`698`	`)`
	`699`	`+ expect((root as any).children[0].children.length).toBe(3)`
`699`	`700`	`expect(generate(root).code).toMatchSnapshot()`
`700`	`701`	`})`
`701`	`702`
Original file line number	Diff line number	Diff line change
`@@ -226,10 +226,7 @@ export function buildSlots(`
`226`	`226`	`break`
`227`	`227`	`}`
`228`	`228`	`}`
`229`		`- if (prev && isTemplateNode(prev) && findDir(prev, 'if')) {`
`230`		`- // remove node`
`231`		`- children.splice(i, 1)`
`232`		`- i--`
	`229`	`+ if (prev && isTemplateNode(prev) && findDir(prev, /^(else-)?if$/)) {`
`233`	`230`	`__TEST__ && assert(dynamicSlots.length > 0)`
`234`	`231`	`// attach this slot to previous conditional`
`235`	`232`	`let conditional = dynamicSlots[`