refactor: move extractOptions to seperate file

Author: eddyerburgh

flow/options.flow.js

@@ -3,6 +3,7 @@ declare type Options = { // eslint-disable-line no-undef
     mocks?: Object,
     slots?: Object,
     localVue?: Component,
+    provide?: Object,
     stubs?: Object,
     context?: Object,
     clone?: boolean,

src/lib/add-provide.js

@@ -1,9 +1,7 @@
-function addProvide (component, options) {
-  const provide = typeof options.provide === 'function'
-    ? options.provide
-    : Object.assign({}, options.provide)
-
-  delete options.provide
+function addProvide (component, optionProvide, options) {
+  const provide = typeof optionProvide === 'function'
+    ? optionProvide
+    : Object.assign({}, optionProvide)
 
   options.beforeCreate = function vueTestUtilBeforeCreate () {
     this._provided = typeof provide === 'function'

src/lib/create-instance.js

@@ -10,50 +10,45 @@ import { throwError } from './util'
 import cloneDeep from 'lodash/cloneDeep'
 import { compileTemplate } from './compile-template'
 import createLocalVue from '../create-local-vue'
-import config from '../config'
+import extractOptions from '../options/extract-options'
 
 export default function createConstructor (
   component: Component,
   options: Options
 ): Component {
-  const vue = options.localVue || createLocalVue()
+  const mountingOptions = extractOptions(options)
 
-  if (options.mocks) {
-    addMocks(options.mocks, vue)
+  const vue = mountingOptions.localVue || createLocalVue()
+
+  if (mountingOptions.mocks) {
+    addMocks(mountingOptions.mocks, vue)
   }
 
   if (component.functional) {
-    if (options.context && typeof options.context !== 'object') {
+    if (mountingOptions.context && typeof mountingOptions.context !== 'object') {
       throwError('mount.context must be an object')
     }
     const clonedComponent = cloneDeep(component)
     component = {
       render (h) {
         return h(
           clonedComponent,
-          options.context || component.FunctionalRenderContext
+          mountingOptions.context || component.FunctionalRenderContext
         )
       }
     }
-  } else if (options.context) {
+  } else if (mountingOptions.context) {
     throwError(
       'mount.context can only be used when mounting a functional component'
     )
   }
 
-  if (options.provide) {
-    addProvide(component, options)
+  if (mountingOptions.provide) {
+    addProvide(component, mountingOptions.provide, options)
   }
 
-  if (options.stubs || Object.keys(config.stubs).length > 0) {
-    if (Array.isArray(options.stubs)) {
-      stubComponents(component, options.stubs)
-    } else {
-      stubComponents(component, {
-        ...config.stubs,
-        ...options.stubs
-      })
-    }
+  if (mountingOptions.stubs) {
+    stubComponents(component, mountingOptions.stubs)
   }
 
   if (!component.render && component.template && !component.functional) {
@@ -64,11 +59,11 @@ export default function createConstructor (
 
   const vm = new Constructor(options)
 
-  addAttrs(vm, options.attrs)
-  addListeners(vm, options.listeners)
+  addAttrs(vm, mountingOptions.attrs)
+  addListeners(vm, mountingOptions.listeners)
 
-  if (options.slots) {
-    addSlots(vm, options.slots)
+  if (mountingOptions.slots) {
+    addSlots(vm, mountingOptions.slots)
   }
 
   return vm

src/options/extract-options.js

@@ -0,0 +1,30 @@
+// @flow
+import config from '../config'
+
+function getStubs (optionStubs) {
+  if (optionStubs || Object.keys(config.stubs).length > 0) {
+    if (Array.isArray(optionStubs)) {
+      return optionStubs
+    } else {
+      return {
+        ...config.stubs,
+        ...optionStubs
+      }
+    }
+  }
+}
+
+export default function extractOptions (
+  options: Options
+): Options {
+  return {
+    mocks: options.mocks,
+    context: options.context,
+    provide: options.provide,
+    stubs: getStubs(options.stubs),
+    attrs: options.attrs,
+    listeners: options.listeners,
+    slots: options.slots,
+    localVue: options.localVue
+  }
+}

test/unit/specs/config.spec.js

@@ -13,6 +13,7 @@ describe('config', () => {
     TransitionGroupStub.name = 'transition-group'
     TransitionStub.name = 'transition'
   })
+
   it('stubs transition and transition-group by default', () => {
     const testComponent = {
       template: `
@@ -52,4 +53,36 @@ describe('config', () => {
     const wrapper = mount(testComponent)
     expect(wrapper.contains(TransitionGroupStub)).to.equal(false)
   })
+
+  it('doesn\'t stub transition when config.stubs is set to false', () => {
+    const configStubsSave = config.stubs
+    config.stubs = false
+    const testComponent = {
+      template: `
+        <div>
+          <transition-group><p /><p /></transition-group>
+        </div>
+      `
+    }
+    const wrapper = mount(testComponent)
+    expect(wrapper.contains(TransitionGroupStub)).to.equal(false)
+    expect(wrapper.contains(TransitionStub)).to.equal(false)
+    config.stubs = configStubsSave
+  })
+
+  it('doesn\'t stub transition when config.stubs is set to a string', () => {
+    const configStubsSave = config.stubs
+    config.stubs = 'a string'
+    const testComponent = {
+      template: `
+        <div>
+          <transition-group><p /><p /></transition-group>
+        </div>
+      `
+    }
+    const wrapper = mount(testComponent)
+    expect(wrapper.contains(TransitionGroupStub)).to.equal(false)
+    expect(wrapper.contains(TransitionStub)).to.equal(false)
+    config.stubs = configStubsSave
+  })
 })