ci: add ie via browserstack

Author: posva

.circleci/config.yml

@@ -55,6 +55,13 @@ jobs:
           at: ~/project
       - run: npm run test:e2e
 
+  test-e2e-browserstack:
+    <<: *defaults
+    steps:
+      - attach_workspace:
+          at: ~/project
+      - run: npm run test:e2e:ci
+
 workflows:
   version: 2
   install-and-parallel-test:
@@ -69,3 +76,6 @@ workflows:
       - test-e2e:
           requires:
             - install
+      - test-e2e-browserstack:
+          requires:
+            - install

.gitignore

@@ -14,3 +14,4 @@ yarn-error.log
 .env
 selenium-server.log
 local.log
+browserstack.err

package.json

@@ -32,7 +32,9 @@
     "test": "npm run lint && npm run flow && npm run test:unit && npm run test:e2e && npm run test:types",
     "flow": "flow check",
     "test:unit": "jasmine JASMINE_CONFIG_PATH=test/unit/jasmine.json",
-    "test:e2e": "node test/e2e/runner.js -e firefox,chrome -c test/e2e/nightwatch.config.js",
+    "test:e2e": "node test/e2e/runner.js",
+    "test:e2e:ci": "node test/e2e/runner.js --local -e ie -c test/e2e/nightwatch.browserstack.js test/e2e/specs/basic.js",
+    "test:e2e:ff": "node test/e2e/runner.js -e firefox -c test/e2e/nightwatch.config.js",
     "test:types": "tsc -p types/test",
     "docs": "vuepress dev docs",
     "docs:build": "vuepress build docs",

test/e2e/nightwatch.browserstack.js

@@ -4,6 +4,7 @@
 
 const BS_USER = process.env.BS_USER
 const BS_KEY = process.env.BS_KEY
+const isCI = process.env.CI
 
 if (!BS_USER || !BS_KEY) {
   console.log(
@@ -12,7 +13,8 @@ if (!BS_USER || !BS_KEY) {
     'If you are a contributor, this is normal, credentials are private. These tests must be run by a maintainer of vue-router',
     'If you are a maintainer, you forgot to `source keys.env`!'
   )
-  process.exit(0)
+  // fail if testing locally
+  process.exit(isCI ? 0 : 1)
 }
 
 const nwConf = {
@@ -58,13 +60,22 @@ const nwConf = {
       }
     },
 
-    ie: {
+    ie9: {
       desiredCapabilities: {
         browser: 'internet explorer',
         browser_version: '9'
         // name: 'Bstack-[Nightwatch] Vue Router',
         // 'browserstack.video': true
       }
+    },
+
+    ie: {
+      desiredCapabilities: {
+        browser: 'internet explorer',
+        browser_version: '11'
+        // name: 'Bstack-[Nightwatch] Vue Router',
+        // 'browserstack.video': true
+      }
     }
   }
 }

test/e2e/runner.js

@@ -84,27 +84,26 @@ if (isLocal) {
   let bsLocal
   const browserstack = require('browserstack-local')
   Nightwatch.bs_local = bsLocal = new browserstack.Local()
-  bsLocal.start({ key: process.env.BS_KEY }, function (error) {
+  bsLocal.start({ key: process.env.BS_KEY }, error => {
     if (error) throw error
 
     console.log('Connected. Now testing...')
     try {
-      Nightwatch.cli(function (argv) {
+      Nightwatch.cli(argv => {
         adaptArgv(argv)
-        console.log(argv)
         Nightwatch.CliRunner(argv)
-          .setup(null, function () {
+          .setup(null, () => {
             // NOTE: I don't know when this is running or if it does
             // Code to stop browserstack local after end of parallel test
-            bsLocal.stop(function () {
+            bsLocal.stop(() => {
               server && server.close()
               process.exit(0)
             })
           })
           .runTests()
           .then(() => {
             // Code to stop browserstack local after end of single test
-            bsLocal.stop(function () {
+            bsLocal.stop(() => {
               server && server.close()
               process.exit(0)
             })
@@ -124,7 +123,7 @@ if (isLocal) {
   })
 } else {
   // create the Nightwatch CLI runner
-  Nightwatch.cli(function (argv) {
+  Nightwatch.cli(argv => {
     adaptArgv(argv)
     const runner = Nightwatch.CliRunner(argv)