feat: use more sensible default localIdentName for css modules

yyx990803 · yyx990803 · commit 084bf3d8fb08 · 2018-03-07T00:21:05.000-05:00
diff --git a/lib/helpers.js b/lib/helpers.js
@@ -238,7 +238,7 @@ module.exports = function createHelpers (
       modules: true
     }
     const OPTIONS = {
-      localIdentName: '[hash:base64]',
+      localIdentName: '[local]_[hash:base64:8]',
       importLoaders: 1
     }
     return loader.replace(/((?:^|!)css(?:-loader)?)(\?[^!]*)?/, (m, $1, $2) => {
diff --git a/test/test.js b/test/test.js
@@ -618,7 +618,7 @@ describe('vue-loader', () => {
       })
     }
     // default localIdentName
-    testWithIdent(undefined, /^\w{22}/, () => {
+    testWithIdent(undefined, /^red_\w{8}/, () => {
       // specified localIdentName
       const ident = '[path][name]---[local]---[hash:base64:5]'
       const regex = /css-modules---red---\w{5}/

Original file line number	Diff line number	Diff line change
`@@ -238,7 +238,7 @@ module.exports = function createHelpers (`
`238`	`238`	`modules: true`
`239`	`239`	`}`
`240`	`240`	`const OPTIONS = {`
`241`		`- localIdentName: '[hash:base64]',`
	`241`	`+ localIdentName: '[local]_[hash:base64:8]',`
`242`	`242`	`importLoaders: 1`
`243`	`243`	`}`
`244`	`244`	`return loader.replace(/((?:^\|!)css(?:-loader)?)(\?[^!]*)?/, (m, $1, $2) => {`
Original file line number	Diff line number	Diff line change
`@@ -618,7 +618,7 @@ describe('vue-loader', () => {`
`618`	`618`	`})`
`619`	`619`	`}`
`620`	`620`	`// default localIdentName`
`621`		`- testWithIdent(undefined, /^\w{22}/, () => {`
	`621`	`+ testWithIdent(undefined, /^red_\w{8}/, () => {`
`622`	`622`	`// specified localIdentName`
`623`	`623`	`const ident = '[path][name]---[local]---[hash:base64:5]'`
`624`	`624`	`const regex = /css-modules---red---\w{5}/`