Drop support for Node.js v12 (#149)

* Drop support for Node.js v12

* update

* fix core tests

Author: ota-meshi

.github/workflows/CI.yml

@@ -13,13 +13,13 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
       - name: Checkout submodules
         run: git submodule update --init
       - name: Install Node.js
-        uses: actions/setup-node@v1
+        uses: actions/setup-node@v3
         with:
-          node-version: 14
+          node-version: 16
       - name: Install Packages
         run: npm install && cd test/fixtures/eslint && npm install
       - name: Lint
@@ -30,37 +30,37 @@ jobs:
     strategy:
       matrix:
         eslint: [7, 8]
-        node: [14, 16]
+        node: [16, 17]
         os: [ubuntu-latest]
         include:
           # On other platforms
           - eslint: 7
-            node: 14
+            node: 16
             os: windows-latest
           - eslint: 7
-            node: 14
+            node: 16
             os: macos-latest
           # On old Node.js versions
           - eslint: 7
-            node: 12
+            node: 14
             os: ubuntu-latest
           # On old ESLint versions
           - eslint: 6
-            node: 14
+            node: 16
             os: ubuntu-latest
           # On the minimum supported ESLint/Node.js version
           - eslint: 6
-            node: 12
+            node: 14
             os: ubuntu-latest
 
     runs-on: ${{ matrix.os }}
     steps:
     - name: Checkout
-      uses: actions/checkout@v2
+      uses: actions/checkout@v3
     - name: Checkout submodules
       run: git submodule update --init
     - name: Install Node.js v${{ matrix.node }}
-      uses: actions/setup-node@v1
+      uses: actions/setup-node@v3
       with:
         node-version: ${{ matrix.node }}
     - name: Install Packages
@@ -77,17 +77,17 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - name: Checkout
-      uses: actions/checkout@v2
+      uses: actions/checkout@v3
     - name: Checkout submodules
       run: git submodule update --init
-    - name: Install Node.js v14
-      uses: actions/setup-node@v1
+    - name: Install Node.js v16
+      uses: actions/setup-node@v3
       with:
-        node-version: 14
+        node-version: 16
     - name: Install Packages
       run: npm install
-    - name: Install ESLint v7
-      run: node scripts/ci-install-eslint 7
+    - name: Install ESLint v8
+      run: node scripts/ci-install-eslint 8.12.0
     - name: Build
       run: npm run -s build
     - name: Test

README.md

@@ -18,7 +18,7 @@ This parser allows us to lint the `<template>` of `.vue` files. We can make mist
 npm install --save-dev eslint vue-eslint-parser
 ```
 
-- Requires Node.js ^12.22.0, ^14.17.0, 16.0.0 or later.
+- Requires Node.js ^14.17.0, 16.0.0 or later.
 - Requires ESLint 6.0.0 or later.
 
 ## 📖 Usage

package.json

@@ -3,7 +3,7 @@
   "version": "8.3.0",
   "description": "The ESLint custom parser for `.vue` files.",
   "engines": {
-    "node": "^12.22.0 || ^14.17.0 || >=16.0.0"
+    "node": "^14.17.0 || >=16.0.0"
   },
   "main": "index.js",
   "files": [
@@ -13,13 +13,13 @@
     "eslint": ">=6.0.0"
   },
   "dependencies": {
-    "debug": "^4.3.2",
-    "eslint-scope": "^7.0.0",
-    "eslint-visitor-keys": "^3.1.0",
-    "espree": "^9.0.0",
+    "debug": "^4.3.4",
+    "eslint-scope": "^7.1.1",
+    "eslint-visitor-keys": "^3.3.0",
+    "espree": "^9.3.1",
     "esquery": "^1.4.0",
     "lodash": "^4.17.21",
-    "semver": "^7.3.5"
+    "semver": "^7.3.6"
   },
   "devDependencies": {
     "@babel/core": "^7.16.0",
@@ -34,17 +34,17 @@
     "@types/mocha": "^9.0.0",
     "@types/node": "^16.11.7",
     "@types/semver": "^7.3.9",
-    "@typescript-eslint/eslint-plugin": "^5.4.0",
-    "@typescript-eslint/parser": "^5.4.0",
+    "@typescript-eslint/eslint-plugin": "^5.18.0",
+    "@typescript-eslint/parser": "^5.18.0",
     "chokidar": "^3.5.2",
     "codecov": "^3.8.3",
     "cross-spawn": "^7.0.3",
     "dts-bundle": "^0.7.3",
-    "eslint": "^8.2.0",
+    "eslint": "^8.12.0",
     "eslint-plugin-eslint-comments": "^3.2.0",
-    "eslint-plugin-jsonc": "^2.0.0",
+    "eslint-plugin-jsonc": "^2.2.1",
     "eslint-plugin-node": "^11.1.0",
-    "eslint-plugin-node-dependencies": "^0.6.0",
+    "eslint-plugin-node-dependencies": "^0.8.0",
     "eslint-plugin-prettier": "^4.0.0",
     "fs-extra": "^10.0.0",
     "jsonc-eslint-parser": "^2.0.3",

test/core-rules.js

@@ -60,15 +60,19 @@ function codeShouldBeSkipped(code) {
 /**
  * Wrap the given code with a `<script>` tag.
  *
+ * @param {string} ruleId The rule ID.
  * @param {string} code - The code to be wrapped.
  * @returns {string} The wrapped code.
  */
-function wrapCode(code) {
+function wrapCode(ruleId, code) {
     const eol = "\n"
 
     if (code.charCodeAt(0) === 0xfeff) {
         return `\uFEFF<script>${eol}${code.slice(1)}${eol}</script>`
     }
+    if (ruleId === "prefer-regex-literals") {
+        return `<script>;${eol}${code}${eol}</script>`
+    }
     return `<script>${eol}${code}${eol}</script>`
 }
 
@@ -86,7 +90,7 @@ function modifyPattern(ruleId, pattern) {
             return null
         }
         return {
-            code: wrapCode(pattern),
+            code: wrapCode(ruleId, pattern),
             filename: "test.vue",
             parser: PARSER_PATH,
         }
@@ -120,9 +124,9 @@ function modifyPattern(ruleId, pattern) {
     // Wrap the code by `<script>` tag.
     pattern.filename = "test.vue"
     pattern.parser = PARSER_PATH
-    pattern.code = wrapCode(pattern.code)
+    pattern.code = wrapCode(ruleId, pattern.code)
     if (pattern.output != null) {
-        pattern.output = wrapCode(pattern.output)
+        pattern.output = wrapCode(ruleId, pattern.output)
     }
 
     if (Array.isArray(pattern.errors)) {
@@ -177,7 +181,7 @@ function modifyPattern(ruleId, pattern) {
                 // Wrap the code by `<script>` tag.
                 if (Array.isArray(error.suggestions)) {
                     for (const suggestion of error.suggestions) {
-                        suggestion.output = wrapCode(suggestion.output)
+                        suggestion.output = wrapCode(ruleId, suggestion.output)
                     }
                 }
             }