refactor(vscode): simplify welcome activation and execution functions

Author: johnsoncodehk

extensions/vscode/index.ts

@@ -16,7 +16,7 @@ import {
 } from 'reactive-vscode';
 import * as vscode from 'vscode';
 import { config } from './lib/config';
-import { activate as activateWelcome, executeWelcome } from './lib/welcome';
+import * as welcome from './lib/welcome';
 
 let client: lsp.BaseLanguageClient | undefined;
 let needRestart = false;
@@ -40,7 +40,7 @@ for (
 	}
 }
 
-export const { activate, deactivate } = defineExtension(() => {
+export = defineExtension(() => {
 	const context = extensionContext.value!;
 	const volarLabs = createLabsInfo();
 	const activeTextEditor = useActiveTextEditor();
@@ -98,10 +98,10 @@ export const { activate, deactivate } = defineExtension(() => {
 
 		activateAutoInsertion(selectors, client);
 		activateDocumentDropEdit(selectors, client);
-		activateWelcome(context);
+		welcome.activate(context);
 	}, { immediate: true });
 
-	useCommand('vue.welcome', () => executeWelcome(context));
+	useCommand('vue.welcome', () => welcome.execute(context));
 	useCommand('vue.action.restartServer', async () => {
 		await executeCommand('typescript.restartTsServer');
 		await client?.stop();
@@ -183,9 +183,9 @@ else {
 	const extensionJsPath = require.resolve('./dist/extension.js', {
 		paths: [tsExtension.extensionPath],
 	});
+	const vuePluginName = require('./package.json').contributes.typescriptServerPlugins[0].name;
 
-	// @ts-expect-error
-	fs.readFileSync = (...args) => {
+	fs.readFileSync = (...args: any[]) => {
 		if (args[0] === extensionJsPath) {
 			let text = readFileSync(...args) as string;
 
@@ -194,7 +194,7 @@ else {
 				'languages:Array.isArray(e.languages)',
 				[
 					'languages:',
-					`e.name==='vue-typescript-plugin-pack'?[${
+					`e.name==='${vuePluginName}'?[${
 						config.server.includeLanguages
 							.map(lang => `'${lang}'`)
 							.join(',')
@@ -215,7 +215,6 @@ else {
 			);
 
 			// sort plugins for johnsoncodehk.tsslint, zardoy.ts-essential-plugins
-			const vuePluginName = require('./package.json').contributes.typescriptServerPlugins[0].name;
 			text = text.replace(
 				'"--globalPlugins",i.plugins',
 				s => s + `.sort((a,b)=>(b.name==="${vuePluginName}"?-1:0)-(a.name==="${vuePluginName}"?-1:0))`,

extensions/vscode/lib/welcome.ts

@@ -10,11 +10,11 @@ export function activate(context: vscode.ExtensionContext) {
 		&& context.globalState.get('vue-welcome') !== welcomeVersion
 	) {
 		context.globalState.update('vue-welcome', welcomeVersion);
-		vscode.commands.executeCommand('vue.welcome');
+		execute(context);
 	}
 }
 
-export function executeWelcome(context: vscode.ExtensionContext) {
+export function execute(context: vscode.ExtensionContext) {
 	if (panel) {
 		panel.reveal(vscode.ViewColumn.One);
 		return;