fix(vscode): show welcome page only when opening a Vue file

Author: johnsoncodehk

extensions/vscode/index.ts

@@ -16,7 +16,7 @@ import {
 } from 'reactive-vscode';
 import * as vscode from 'vscode';
 import { config } from './lib/config';
-import { activate as activateWelcome } from './lib/welcome';
+import { activate as activateWelcome, executeWelcome } from './lib/welcome';
 
 let client: lsp.BaseLanguageClient | undefined;
 let needRestart = false;
@@ -98,9 +98,10 @@ export const { activate, deactivate } = defineExtension(() => {
 
 		activateAutoInsertion(selectors, client);
 		activateDocumentDropEdit(selectors, client);
+		activateWelcome(context);
 	}, { immediate: true });
 
-	activateWelcome(context);
+	useCommand('vue.welcome', () => executeWelcome(context));
 	useCommand('vue.action.restartServer', async () => {
 		await executeCommand('typescript.restartTsServer');
 		await client?.stop();

extensions/vscode/lib/welcome.ts

@@ -1,41 +1,10 @@
-import { useCommand } from 'reactive-vscode';
 import * as vscode from 'vscode';
 
 const welcomeVersion = '3.0.6';
 
 let panel: vscode.WebviewPanel | undefined;
 
 export function activate(context: vscode.ExtensionContext) {
-	useCommand('vue.welcome', () => {
-		if (panel) {
-			panel.reveal(vscode.ViewColumn.One);
-			return;
-		}
-
-		panel = vscode.window.createWebviewPanel(
-			'vue.welcome',
-			'Welcome to Vue',
-			vscode.ViewColumn.One,
-			{ enableScripts: true },
-		);
-
-		panel.webview.html = getWelcomeHtml(context);
-		panel.webview.onDidReceiveMessage(message => {
-			switch (message.command) {
-				case 'verifySponsor':
-					vscode.commands.executeCommand('vue.action.verify');
-					break;
-				case 'toggleShowUpdates':
-					context.globalState.update('vue.showUpdates', message.value);
-					break;
-			}
-		});
-
-		panel.onDidDispose(() => {
-			panel = undefined;
-		});
-	});
-
 	if (
 		context.globalState.get('vue.showUpdates', true)
 		&& context.globalState.get('vue-welcome') !== welcomeVersion
@@ -45,6 +14,31 @@ export function activate(context: vscode.ExtensionContext) {
 	}
 }
 
+export function executeWelcome(context: vscode.ExtensionContext) {
+	if (panel) {
+		panel.reveal(vscode.ViewColumn.One);
+		return;
+	}
+	panel = vscode.window.createWebviewPanel(
+		'vue.welcome',
+		'Welcome to Vue',
+		vscode.ViewColumn.One,
+		{ enableScripts: true },
+	);
+	panel.webview.html = getWelcomeHtml(context);
+	panel.webview.onDidReceiveMessage(message => {
+		switch (message.command) {
+			case 'verifySponsor':
+				vscode.commands.executeCommand('vue.action.verify');
+				break;
+			case 'toggleShowUpdates':
+				context.globalState.update('vue.showUpdates', message.value);
+				break;
+		}
+	});
+	panel.onDidDispose(() => panel = undefined);
+}
+
 function getWelcomeHtml(context: vscode.ExtensionContext) {
 	const version = context.extension.packageJSON.version;
 	return /* HTML */ `
@@ -339,7 +333,7 @@ function getWelcomeHtml(context: vscode.ExtensionContext) {
 			<input type="checkbox" onchange="toggleShowUpdates(this.checked)" ${
 		context.globalState.get('vue.showUpdates', true) ? 'checked' : ''
 	}>
-			<span>Show release notes on every significant update</span>
+			<span>Show release notes on update</span>
 		</label>
 	</div>