fix: fix tests failing

Author: mpiniarski

lib/rules/define-props-declaration.js

@@ -15,62 +15,58 @@ const PROPS_SEPARATOR = ', '
  * @param {RuleContext} context
  */
 function* fixTypeBased(fixer, node, props, context) {
-  try {
-    const sourceCode = context.getSourceCode()
-    const autoFixToSeparateInterface =
-      context.options[1]?.autoFixToSeparateInterface || false
+  const sourceCode = context.getSourceCode()
+  const autoFixToSeparateInterface =
+    context.options[1]?.autoFixToSeparateInterface || false
 
-    const componentPropsData = props.map((prop) =>
-      getComponentPropData(prop, sourceCode)
-    )
-
-    const componentPropsTypes = componentPropsData.map(
-      ({ name, type, required, defaultValue }) => {
-        const isOptional = required === false || defaultValue
-        return `${name}${isOptional ? '?' : ''}: ${type}`
-      }
-    )
+  const componentPropsData = props.map((prop) =>
+    getComponentPropData(prop, sourceCode)
+  )
 
-    const componentPropsTypeCode = `{${componentPropsTypes.join(PROPS_SEPARATOR)}}`
+  const componentPropsTypes = componentPropsData.map(
+    ({ name, type, required, defaultValue }) => {
+      const isOptional = required === false || defaultValue
+      return `${name}${isOptional ? '?' : ''}: ${type}`
+    }
+  )
 
-    // remove defineProps function parameters
-    yield fixer.replaceText(node.arguments[0], '')
+  const componentPropsTypeCode = `{ ${componentPropsTypes.join(PROPS_SEPARATOR)} }`
 
-    // add type annotation
-    if (autoFixToSeparateInterface) {
-      const variableDeclarationNode = node.parent.parent
-      if (!variableDeclarationNode) {
-        return
-      }
+  // remove defineProps function parameters
+  yield fixer.replaceText(node.arguments[0], '')
 
-      yield fixer.insertTextBefore(
-        variableDeclarationNode,
-        `interface Props ${componentPropsTypeCode.replace(/;/g, ',')}; `
-      )
-      yield fixer.insertTextAfter(node.callee, `<Props>`)
-    } else {
-      yield fixer.insertTextAfter(node.callee, `<${componentPropsTypeCode}>`)
+  // add type annotation
+  if (autoFixToSeparateInterface) {
+    const variableDeclarationNode = node.parent.parent
+    if (!variableDeclarationNode) {
+      return
     }
 
-    // add defaults if needed
-    const propTypesDataWithDefaultValue = componentPropsData.filter(
-      ({ defaultValue }) => defaultValue
+    yield fixer.insertTextBefore(
+      variableDeclarationNode,
+      `interface Props ${componentPropsTypeCode.replace(/;/g, ',')}; `
     )
-    if (propTypesDataWithDefaultValue.length > 0) {
-      const defaultsCode = propTypesDataWithDefaultValue
-        .map(
-          ({ name, defaultValue }) =>
-            `${name}: ${sourceCode.getText(defaultValue)}`
-        )
-        .join(PROPS_SEPARATOR)
+    yield fixer.insertTextAfter(node.callee, `<Props>`)
+  } else {
+    yield fixer.insertTextAfter(node.callee, `<${componentPropsTypeCode}>`)
+  }
 
-      yield fixer.insertTextBefore(node, `withDefaults(`)
-      yield fixer.insertTextAfter(node, `, { ${defaultsCode} })`)
-    }
-    return null
-  } catch (error) {
-    return null
+  // add defaults if needed
+  const propTypesDataWithDefaultValue = componentPropsData.filter(
+    ({ defaultValue }) => defaultValue
+  )
+  if (propTypesDataWithDefaultValue.length > 0) {
+    const defaultsCode = propTypesDataWithDefaultValue
+      .map(
+        ({ name, defaultValue }) =>
+          `${name}: ${sourceCode.getText(defaultValue)}`
+      )
+      .join(PROPS_SEPARATOR)
+
+    yield fixer.insertTextBefore(node, `withDefaults(`)
+    yield fixer.insertTextAfter(node, `, { ${defaultsCode} })`)
   }
+  return null
 }
 const mapNativeType = (/** @type {string} */ nativeType) => {
   switch (nativeType) {