fix: use --build for type-checking to be exhaustive and less-fragile (#274)

haoqunjiang · web-flow · commit 9b27fdf31387 · 2023-12-04T13:32:46.000+08:00
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/template/base/_gitignore b/template/base/_gitignore
@@ -26,3 +26,5 @@ coverage
 *.njsproj
 *.sln
 *.sw?
+
+*.tsbuildinfo
diff --git a/template/config/nightwatch/package.json b/template/config/nightwatch/package.json
@@ -9,6 +9,7 @@
     "@types/nightwatch": "^2.3.30",
     "geckodriver": "^4.2.1",
     "chromedriver": "^119.0.0",
-    "ts-node": "^10.9.1"
+    "ts-node": "^10.9.1",
+    "vite-plugin-nightwatch": "^0.4.5"
   }
 }
diff --git a/template/config/typescript/package.json b/template/config/typescript/package.json
@@ -2,7 +2,7 @@
   "scripts": {
     "build": "run-p type-check \"build-only {@}\" --",
     "build-only": "vite build",
-    "type-check": "vue-tsc --noEmit -p tsconfig.app.json --composite false"
+    "type-check": "vue-tsc --build --force"
   },
   "devDependencies": {
     "@types/node": "^18.18.13",
diff --git a/template/tsconfig/base/tsconfig.app.json b/template/tsconfig/base/tsconfig.app.json
@@ -4,6 +4,7 @@
   "exclude": ["src/**/__tests__/*"],
   "compilerOptions": {
     "composite": true,
+    "noEmit": true,
     "baseUrl": ".",
     "paths": {
       "@/*": ["./src/*"]
diff --git a/template/tsconfig/base/tsconfig.node.json b/template/tsconfig/base/tsconfig.node.json
@@ -9,6 +9,7 @@
   ],
   "compilerOptions": {
     "composite": true,
+    "noEmit": true,
     "module": "ESNext",
     "moduleResolution": "Bundler",
     "types": ["node"]
diff --git a/template/tsconfig/cypress-ct/package.json b/template/tsconfig/cypress-ct/package.json
diff --git a/template/tsconfig/nightwatch-ct/tsconfig.app.json b/template/tsconfig/nightwatch-ct/tsconfig.app.json
@@ -4,6 +4,7 @@
   "exclude": ["src/**/__tests__/*"],
   "compilerOptions": {
     "composite": true,
+    "noEmit": true,
     "baseUrl": ".",
     "paths": {
       "@/*": ["./src/*"]
diff --git a/template/tsconfig/nightwatch/nightwatch/tsconfig.json b/template/tsconfig/nightwatch/nightwatch/tsconfig.json
@@ -5,6 +5,7 @@
     "module": "commonjs",
     "moduleResolution": "node",
     "composite": true,
+    "noEmit": true,
     "rootDir": "../",
     "lib": ["ESNext", "dom"],
     "types": ["nightwatch"]
diff --git a/template/tsconfig/vitest/package.json b/template/tsconfig/vitest/package.json
@@ -1,7 +1,4 @@
 {
-  "scripts": {
-    "type-check": "vue-tsc --noEmit -p tsconfig.vitest.json --composite false"
-  },
   "devDependencies": {
     "@types/jsdom": "^21.1.6"
   }

Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,7 @@`
`9`	`9`	`"@types/nightwatch": "^2.3.30",`
`10`	`10`	`"geckodriver": "^4.2.1",`
`11`	`11`	`"chromedriver": "^119.0.0",`
`12`		`- "ts-node": "^10.9.1"`
	`12`	`+ "ts-node": "^10.9.1",`
	`13`	`+ "vite-plugin-nightwatch": "^0.4.5"`
`13`	`14`	`}`
`14`	`15`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,4 @@`
`1`	`1`	`{`
`2`		`- "scripts": {`
`3`		`- "type-check": "vue-tsc --noEmit -p tsconfig.vitest.json --composite false"`
`4`		`- },`
`5`	`2`	`"devDependencies": {`
`6`	`3`	`"@types/jsdom": "^21.1.6"`
`7`	`4`	`}`