fix: (@vue/apollo-option) memory leak in wrapped ssrRender (#1553)

deleteme · web-flow · commit fceb40cd2c92 · 2024-08-14T16:39:44.000+02:00
diff --git a/packages/vue-apollo-option/src/mixin.js b/packages/vue-apollo-option/src/mixin.js
@@ -115,11 +115,14 @@ export function installMixin (app, provider) {
       if (isServer) {
         // Patch render function to cleanup apollo
         const render = this.$options.ssrRender
+        if (!render) return
+        if (render.__IS_VUE_APOLLO_WRAPPED) return
         this.$options.ssrRender = (h) => {
           const result = render.call(this, h)
           destroy.call(this)
           return result
         }
+        this.$options.ssrRender.__IS_VUE_APOLLO_WRAPPED = true
       }
     },
 

Original file line number	Diff line number	Diff line change
`@@ -115,11 +115,14 @@ export function installMixin (app, provider) {`
`115`	`115`	`if (isServer) {`
`116`	`116`	`// Patch render function to cleanup apollo`
`117`	`117`	`const render = this.$options.ssrRender`
	`118`	`+ if (!render) return`
	`119`	`+ if (render.__IS_VUE_APOLLO_WRAPPED) return`
`118`	`120`	`this.$options.ssrRender = (h) => {`
`119`	`121`	`const result = render.call(this, h)`
`120`	`122`	`destroy.call(this)`
`121`	`123`	`return result`
`122`	`124`	`}`
	`125`	`+ this.$options.ssrRender.__IS_VUE_APOLLO_WRAPPED = true`
`123`	`126`	`}`
`124`	`127`	`},`
`125`	`128`