Merge pull request #149 from vue-pivottable/fix/eslint-and-style-format

chore: modify lint and format rule

Author: Seungwoo321

.gitignore

@@ -25,4 +25,5 @@ dist-ssr
 *.sw?
 
 # vscode
-.history
+.history
+reference

eslint.config.js

@@ -17,20 +17,11 @@ export default defineConfig([
   {
     files: ['**/*.{js,mjs,cjs,vue,ts}', 'eslint.config.js'],
     extends: [
-      ...standardjs.configs.recommended,
+      ...standardjs.configs.base,
       ...tseslint.configs.recommended,
       ...pluginVue.configs['flat/strongly-recommended']
     ],
     rules: {
-      '@stylistic/space-before-function-paren': [
-        'error',
-        {
-          anonymous: 'always',
-          named: 'never',
-          asyncArrow: 'always'
-        }
-      ],
-      '@stylistic/quote-props': ['error', 'consistent'],
       'vue/html-self-closing': [
         'error',
         {

src/App.vue

@@ -111,7 +111,7 @@ const sorters = ref({
 
 const vals = ref(['Tip'])
 const rendererName = ref('Table')
-const onDataParsed = (data) => {
+const onDataParsed = () => {
   rows.value = []
   cols.value = []
   vals.value = []

src/components/pivottable-ui/VAggregatorCell.vue

@@ -107,9 +107,9 @@ const numValsAllowed = computed(
 const currentRowSortIcon = computed(() => sortIcons[props.rowOrder].rowSymbol)
 const currentColSortIcon = computed(() => sortIcons[props.colOrder].colSymbol)
 const updateAggregatorName = (value) => emit('update:aggregatorName', value)
-const updateRowOrder = (value) =>
+const updateRowOrder = () =>
   emit('update:rowOrder', sortIcons[props.rowOrder].next)
-const updateColOrder = (value) =>
+const updateColOrder = () =>
   emit('update:colOrder', sortIcons[props.colOrder].next)
 const updateVals = (val, i) => {
   const newVals = [...props.vals]

src/composables/usePivotUiState.ts

@@ -7,7 +7,7 @@ type PivotUiState = {
   openStatus: Record<string, boolean>
 }
 
-export function usePivotUiState() {
+export function usePivotUiState () {
   const pivotUiState = reactive<PivotUiState>({
     unusedOrder: [],
     zIndices: {},

src/composables/useProvideFilterbox.ts

@@ -10,7 +10,7 @@ interface ProvideFilterBoxProps {
   [key: string]: any
 }
 
-export function provideFilterBox(props: ProvideFilterBoxProps) {
+export function provideFilterBox (props: ProvideFilterBoxProps) {
   const localeStrings = computed(
     () => props.languagePack[props.locale].localeStrings
   )
@@ -24,6 +24,6 @@ export function provideFilterBox(props: ProvideFilterBoxProps) {
   })
 }
 
-export function useProvideFilterBox() {
+export function useProvideFilterBox () {
   return inject(filterBoxKey)
 }

src/helper/utilities.d.ts

@@ -38,6 +38,9 @@ interface AggregatorInstance {
     format?: Formatter | ((x: any) => string);
     numInputs?: number;
 }
+interface PivotDataContext {
+    getAggregator: (rowKey: any[], colKey: any[]) => AggregatorInstance;
+}
 type AggregatorFunction = (data?: PivotDataContext, rowKey?: any[], colKey?: any[]) => AggregatorInstance;
 type AggregatorTemplate = (...args: any[]) => AggregatorFunction;
 interface AggregatorTemplates {
@@ -73,9 +76,6 @@ interface PivotDataProps {
     colOrder?: 'key_a_to_z' | 'key_z_to_a' | 'value_a_to_z' | 'value_z_to_a';
     derivedAttributes?: Record<string, (record: DataRecord) => RecordValue>;
 }
-interface PivotDataContext {
-    getAggregator: (rowKey: any[], colKey: any[]) => AggregatorInstance;
-}
 interface LocaleStrings {
     renderError: string;
     computeError: string;

src/helper/utilities.ts

@@ -41,7 +41,9 @@ interface AggregatorInstance {
   format?: Formatter | ((x: any) => string)
   numInputs?: number
 }
-
+interface PivotDataContext {
+  getAggregator: (rowKey: any[], colKey: any[]) => AggregatorInstance
+}
 type AggregatorFunction = (data?: PivotDataContext, rowKey?: any[], colKey?: any[]) => AggregatorInstance
 type AggregatorTemplate = (...args: any[]) => AggregatorFunction
 
@@ -81,10 +83,6 @@ interface PivotDataProps {
   derivedAttributes?: Record<string, (record: DataRecord) => RecordValue>
 }
 
-interface PivotDataContext {
-  getAggregator: (rowKey: any[], colKey: any[]) => AggregatorInstance
-}
-
 // ==================== Locale 관련 타입 ====================
 interface LocaleStrings {
   renderError: string
@@ -209,8 +207,8 @@ const naturalSort: SortFunction = (as: any, bs: any): number => {
   }
 
   // finally, "smart" string sorting
-  let a = String(as)
-  let b = String(bs)
+  const a = String(as)
+  const b = String(bs)
   if (a === b) {
     return 0
   }
@@ -353,7 +351,7 @@ const aggregatorTemplates: AggregatorTemplates = {
       ),
       push (record: DataRecord) {
         const raw = record?.[attr]
-        let x = raw
+        const x = raw
         if (['min', 'max'].includes(mode)) {
           const numX = x != null ? parseFloat(String(x)) : NaN
           if (!isNaN(numX)) {
@@ -1000,4 +998,4 @@ export {
   getSort,
   sortAs,
   PivotData
-} 
+}