Skip to content

Commit 38f83ca

Browse files
committed
refactor: 1. export CoreModal for unit testing 2. move packages/vue-final-modal/viteplay to ./viteplay
1 parent fe9a0a9 commit 38f83ca

File tree

24 files changed

+117
-35
lines changed

24 files changed

+117
-35
lines changed

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
"dev:docs": "pnpm --filter docs dev",
77
"build:docs": "pnpm --filter docs build",
88
"generate:docs": "pnpm --filter docs generate",
9-
"dev:viteplay": "pnpm --filter vue-final-modal dev:viteplay",
10-
"build:viteplay": "pnpm --filter vue-final-modal build:viteplay",
9+
"dev:viteplay": "pnpm --filter viteplay dev",
10+
"build:viteplay": "pnpm --filter viteplay build",
1111
"dev:vfm": "pnpm --filter vue-final-modal dev",
1212
"build:vfm": "pnpm --filter vue-final-modal build",
1313
"test:vfm": "pnpm --filter vue-final-modal test",

packages/vue-final-modal/package.json

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@
2323
"scripts": {
2424
"dev": "vue-tsc --noEmit && vite build -w",
2525
"build": "vue-tsc --noEmit && vite build && vue-tsc -p tsconfig.build-dts.json --declaration --emitDeclarationOnly",
26-
"dev:viteplay": "vite --config vite.config.play.ts --host",
27-
"build:viteplay": "vite build --config vite.config.play.ts",
2826
"test": "vitest run",
2927
"coverage": "vitest run --coverage",
3028
"typecheck": "vue-tsc --noEmit",
@@ -40,8 +38,6 @@
4038
},
4139
"devDependencies": {
4240
"@release-it/conventional-changelog": "^5.1.1",
43-
"@viteplay/plugin": "^0.2.4",
44-
"@viteplay/vue": "^0.2.4",
4541
"@vitest/coverage-istanbul": "^0.24.5",
4642
"jsdom": "^20.0.2",
4743
"release-it": "^15.5.0",

packages/vue-final-modal/src/index.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import ModalsContainer from './components/ModalsContainer.vue'
2+
import CoreModal from './components/CoreModal/CoreModal.vue'
23
import VueFinalModal from './components/VueFinalModal/VueFinalModal.vue'
34
import VFullscreen from './components/VFullscreen/VFullscreen.vue'
45
import VBottomSheet from './components/VBottomSheet/VBottomSheet.vue'
@@ -12,11 +13,13 @@ export * from './plugin'
1213
/** Components */
1314
export {
1415
ModalsContainer,
16+
CoreModal,
1517
VueFinalModal,
1618
VBottomSheet,
1719
VFullscreen,
1820
}
1921

22+
export { coreModalProps } from './components/CoreModal/CoreModalProps'
2023
export { vueFinalModalProps } from './components/VueFinalModal/VueFinalModalProps'
2124
export { vFullscreenProps } from './components/VFullscreen/VFullscreenProps'
2225
export { vBottomSheetProps } from './components/VBottomSheet/VBottomSheetProps'

packages/vue-final-modal/test/VueFinalModal.test.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
import { describe, expect, it } from 'vitest'
22
import type { VueWrapper } from '@vue/test-utils'
33
import { mount } from '@vue/test-utils'
4-
import { VueFinalModal, createVfm } from '../src/index'
5-
import CoreModal from '~/components/CoreModal/CoreModal.vue'
4+
import { CoreModal, VueFinalModal, createVfm } from '../src/index'
65

76
// vi.mock('tabbable', async () => {
87
// const lib = await vi.importActual<typeof import('tabbable')>('tabbable')

packages/vue-final-modal/tsconfig.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,6 @@
1414
],
1515
"~": [
1616
"src"
17-
],
18-
"vue-final-modal": [
19-
"src/index"
2017
]
2118
}
2219
},

packages/vue-final-modal/viteplay/viteplay.iframe.ts

Lines changed: 0 additions & 7 deletions
This file was deleted.

pnpm-lock.yaml

Lines changed: 61 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pnpm-workspace.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,3 +4,4 @@ packages:
44
# all packages in subdirs of packages/ and components/
55
- "packages/**"
66
- "docs"
7+
- "viteplay"
File renamed without changes.
File renamed without changes.

0 commit comments

Comments
 (0)