Apply suggestions from code review

Co-authored-by: Y.Horie <u5.horie@gmail.com>

Author: wpjunior

src/ngx_http_vhost_traffic_status_display_json.c

@@ -68,8 +68,9 @@ ngx_http_vhost_traffic_status_display_set_server_node(
     ngx_http_vhost_traffic_status_node_t *vtsn)
 {
     u_char                                    *p, *c;
-    ngx_int_t                                  rc;
+    ngx_int_t                                  rc, i;
     ngx_str_t                                  tmp, dst;
+    ngx_uint_t                                *status_codes
     ngx_http_vhost_traffic_status_loc_conf_t  *vtscf;
     ngx_http_vhost_traffic_status_ctx_t       *ctx;
 
@@ -116,9 +117,9 @@ ngx_http_vhost_traffic_status_display_set_server_node(
         buf = ngx_sprintf(buf, NGX_HTTP_VHOST_TRAFFIC_STATUS_JSON_FMT_SERVER_OTHER_STATUS_CODE,
             vtsn->stat_status_code_counter[0]);
 
-        ngx_uint_t *status_codes = (ngx_uint_t *) ctx->measure_status_codes->elts;
+        *status_codes = (ngx_uint_t *) ctx->measure_status_codes->elts;
 
-        for (ngx_uint_t i = 0; i < ctx->measure_status_codes->nelts; i++) {
+        for (i = 0; i < ctx->measure_status_codes->nelts; i++) {
             if (vtsn->stat_status_code_counter[i+1] == 0 && ctx->measure_all_status_codes) {
                 continue;
             }

src/ngx_http_vhost_traffic_status_display_prometheus.c

@@ -84,7 +84,7 @@ ngx_http_vhost_traffic_status_display_prometheus_set_server_node(
         buf = ngx_sprintf(buf, NGX_HTTP_VHOST_TRAFFIC_STATUS_PROMETHEUS_FMT_SERVER_OTHER_STATUS_CODE,
             &server, vtsn->stat_status_code_counter[0]);
 
-        for (ngx_uint_t i = 0; i < ctx->measure_status_codes->nelts; i++) {
+        for (i = 0; i < ctx->measure_status_codes->nelts; i++) {
             if (vtsn->stat_status_code_counter[i+1] == 0 && ctx->measure_all_status_codes) {
                 continue;
             }

src/ngx_http_vhost_traffic_status_node.c

@@ -292,7 +292,7 @@ ngx_http_vhost_traffic_status_node_zero(ngx_http_vhost_traffic_status_node_t *vt
     vtsn->stat_request_time_counter_oc = 0;
     vtsn->stat_response_time_counter_oc = 0;
 
-    for (uint i=0; i<vtsn->stat_status_code_length; i++) {
+    for (i = 0; i < vtsn->stat_status_code_length; i++) {
         vtsn->stat_status_code_counter[i] = 0;
     }
 

src/ngx_http_vhost_traffic_status_shm.c

@@ -565,7 +565,7 @@ static int ngx_http_vhost_traffic_status_find_status_code_slot_cmp(const void *o
     return (*(ngx_uint_t *) one - *(ngx_uint_t *) two);
 }
 
-ngx_int_t
+ngx_uint_t
 ngx_http_vhost_traffic_status_find_status_code_slot(ngx_uint_t status, ngx_array_t *status_codes)
 {
     ngx_uint_t *found = (ngx_uint_t *) bsearch(&status, status_codes->elts, status_codes->nelts,
@@ -578,8 +578,7 @@ ngx_http_vhost_traffic_status_find_status_code_slot(ngx_uint_t status, ngx_array
         return 0;
     }
 
-    ngx_int_t index = (ngx_int_t)(found - (ngx_uint_t *)status_codes->elts);
-    return index + 1;
+    return found - (ngx_uint_t *)status_codes->elts + 1;
 }
 
 #if (NGX_HTTP_CACHE)