Pick default gunicorn workers from non-legacy fact

While the documentation for the core fact `processors.count` states that
it is an _integer_ already, the previous behavior was to silently treat
a missing fact as a processor count of zero, via `NilClass#to_i`.

This does not happen in FacterDB entries for supported os, but the spec
still mirrors the conversion done by the template.

Author: notCalle

manifests/gunicorn.pp

@@ -55,6 +55,8 @@
   String[1]                             $template          = 'python/gunicorn.erb',
   Array                                 $args              = [],
 ) {
+  $processor_count = fact('processors.count')
+
   if $manage_config_dir {
     file { $config_dir:
       ensure => directory,

spec/defines/gunicorn_spec.rb

@@ -13,8 +13,11 @@
         context 'configures test app with default parameter values' do
           let(:params) { { dir: '/srv/testapp' } }
           let(:expected_workers) do
+            # manifests/gunicorn.pp
+            processor_count = facts.dig(:processors, 'count')
+
             # templates/gunicorn.erb
-            (facts[:processorcount].to_i * 2) + 1
+            (processor_count.to_i * 2) + 1
           end
 
           it { is_expected.to contain_file('/etc/gunicorn.d/test-app').with_mode('0644').with_content(%r{--log-level=error}) }

templates/gunicorn.erb

@@ -39,7 +39,7 @@ CONFIG = {
 <% if @workers -%>
     '--workers=<%= @workers %>',
 <% else -%>
-    '--workers=<%= @processorcount.to_i*2 + 1 %>',
+    '--workers=<%= @processor_count.to_i*2 + 1 %>',
 <% end -%>
     '--timeout=<%= @timeout %>',
 <% if @access_log_format -%>