Merge pull request #342 from bastelfreak/cleanupdatatypes

cleanup types in openvpn::client_specific_config

Author: bastelfreak

manifests/client_specific_config.pp

@@ -23,14 +23,14 @@
 #       dhcp_options => ['DNS 8.8.8.8']
 #    }
 define openvpn::client_specific_config (
-  String $server,
-  Enum[present, absent] $ensure      = present,
-  Array[String] $iroute              = [],
-  Array[String] $iroute_ipv6         = [],
-  Array[String] $route               = [],
-  Variant[Boolean, String] $ifconfig = false,
+  String[1] $server,
+  Enum['present', 'absent'] $ensure  = present,
+  Array[String[1]] $iroute           = [],
+  Array[String[1]] $iroute_ipv6      = [],
+  Array[String[1]] $route            = [],
+  Optional[String[1]] $ifconfig      = undef,
   Optional[String[1]] $ifconfig_ipv6 = undef,
-  Array[String]  $dhcp_options       = [],
+  Array[String[1]]  $dhcp_options    = [],
   Boolean $redirect_gateway          = false,
   Boolean $manage_client_configs     = true,
 ) {

templates/client_specific_config.erb

@@ -4,8 +4,8 @@ iroute <%= iroute %>
 <% @iroute_ipv6.each do |iroute_ipv6| -%>
 iroute-ipv6 <%= iroute_ipv6 %>
 <% end -%>
-<% if ifconfig = @ifconfig -%>
-ifconfig-push <%= ifconfig %>
+<% if @ifconfig -%>
+ifconfig-push <%= @ifconfig %>
 <% end -%>
 <% if @ifconfig_ipv6 -%>
 ifconfig-ipv6-push <%= @ifconfig_ipv6 %>