Skip to content

Conversation

@fengruotj
Copy link

The same as this pr: volcano-sh/volcano#4285.

StartHealthz() provides health checks for volcano-controller, volcano-admission, and volcano-scheduler.

Regarding the stop channel returned from signal handling: if multiple handlers are waiting on different channels, only one of them will be triggered. Therefore, we must use signals.SetupSignalContext() to handle signals, as it will close the signal channel, allowing multiple handlers to be triggered simultaneously.

@volcano-sh-bot
Copy link
Collaborator

Welcome @fengruotj!

It looks like this is your first PR to volcano-sh/apis.

Thank you, and welcome to Volcano. 😃

@fengruotj
Copy link
Author

Why i got the following message:
You're not authorized to push to this branch. Visit https://docs.github.com/repositories/configuring-branches-and-merges-in-your-repository/managing-protected-branches/about-protected-branches for more information.

@fengruotj
Copy link
Author

/assign @hwdef

@fengruotj
Copy link
Author

PTAL, makes code strong & elegance together .

@fengruotj
Copy link
Author

/assign @k82cn

Signed-off-by: tanjie.master <tanjie.master@gmail.com>
@fengruotj fengruotj force-pushed the graceful-shutdown branch from 7388416 to 56e1644 Compare June 20, 2025 05:16
@volcano-sh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hzxuzhonghu
Once this PR has been reviewed and has the lgtm label, please ask for approval from k82cn. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hzxuzhonghu
Copy link
Member

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants