-
Notifications
You must be signed in to change notification settings - Fork 93
feat: add graceful shutdown for healthy-check http server. #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Welcome @fengruotj! |
|
Why i got the following message: |
8e6c25f to
7388416
Compare
|
/assign @hwdef |
|
PTAL, makes code strong & elegance together . |
|
/assign @k82cn |
Signed-off-by: tanjie.master <tanjie.master@gmail.com>
7388416 to
56e1644
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
The same as this pr: volcano-sh/volcano#4285.
StartHealthz() provides health checks for volcano-controller, volcano-admission, and volcano-scheduler.
Regarding the stop channel returned from signal handling: if multiple handlers are waiting on different channels, only one of them will be triggered. Therefore, we must use signals.SetupSignalContext() to handle signals, as it will close the signal channel, allowing multiple handlers to be triggered simultaneously.