Reduce logging, now that bugs are addressed.

Author: hunhoffe

kernel/src/arch/x86_64/rackscale/dcm/affinity_alloc.rs

@@ -54,7 +54,7 @@ pub(crate) fn dcm_affinity_alloc(node_id: DCMNodeId, num_memslices: usize) -> bo
         num_cores: 0,
         num_memslices: num_memslices as u64,
     };
-    log::warn!(
+    log::debug!(
         "dcm_affinity_alloc(node={:?}, cores={:?}, memslices={:?})",
         node_id,
         0,
@@ -71,6 +71,6 @@ pub(crate) fn dcm_affinity_alloc(node_id: DCMNodeId, num_memslices: usize) -> bo
             unsafe { &mut [res.as_mut_bytes()] },
         )
         .expect("Failed to send resource alloc RPC to DCM");
-    log::warn!("Can the allocation be satisfied? {:?}", res.can_satisfy);
+    log::debug!("Can the allocation be satisfied? {:?}", res.can_satisfy);
     return res.can_satisfy;
 }

kernel/src/arch/x86_64/rackscale/dcm/resource_alloc.rs

@@ -58,7 +58,7 @@ pub(crate) fn dcm_resource_alloc(
 ) -> (Vec<DCMNodeId>, Vec<DCMNodeId>) {
     // TODO(rackscale): make debug assert
     assert!(cores > 0 || memslices > 0);
-    log::warn!(
+    log::debug!(
         "Asking DCM for {:?} cores and {:?} memslices for pid {:?}",
         cores,
         memslices,
@@ -85,7 +85,7 @@ pub(crate) fn dcm_resource_alloc(
             )
             .expect("Failed to send resource alloc RPC to DCM");
     }
-    log::warn!("Received allocation id in response: {:?}", res.alloc_id);
+    log::debug!("Received allocation id in response: {:?}", res.alloc_id);
 
     let mut received_allocations = 0;
     let mut dcm_node_for_cores =
@@ -115,7 +115,5 @@ pub(crate) fn dcm_resource_alloc(
             _ => unreachable!("Should not reach here"),
         }
     }
-    assert!(dcm_node_for_cores.len() as u64 == cores);
-    assert!(dcm_node_for_memslices.len() as u64 == memslices);
     (dcm_node_for_cores, dcm_node_for_memslices)
 }

kernel/src/arch/x86_64/rackscale/get_shmem_frames.rs

@@ -110,7 +110,7 @@ pub(crate) fn handle_get_shmem_frames(
     mut payload: &mut [u8],
     state: ControllerState,
 ) -> Result<ControllerState, RPCError> {
-    log::warn!("Handling get_shmem_frames()");
+    log::debug!("Handling get_shmem_frames()");
 
     // Parse request
     let (machine_id, pid, num_frames) = match unsafe { decode::<ShmemFrameReq>(payload) } {
@@ -141,14 +141,6 @@ pub(crate) fn handle_get_shmem_frames(
                 .shmem_manager
                 .as_mut()
                 .expect("No shmem manager found for client");
-            log::warn!(
-                "Manager for client {:?} ({:?}) free_bp={:?} free_lp={:?} need_lp={:?}",
-                mid,
-                node_id,
-                manager.free_base_pages(),
-                manager.free_large_pages(),
-                num_frames
-            );
 
             for _i in 0..num_frames {
                 let frame = manager
@@ -165,21 +157,14 @@ pub(crate) fn handle_get_shmem_frames(
         let (_, dcm_ids) = dcm_resource_alloc(pid, 0, num_frames as u64);
         for i in 0..num_frames {
             let dcm_id = dcm_ids[i];
-            log::warn!("Received node assignment from DCM: node {:?}", dcm_id);
+            log::debug!("Received node assignment from DCM: node {:?}", dcm_id);
 
             // TODO(error_handling): should handle errors gracefully here, maybe percolate to client?
             let mut client_state = state.get_client_state_by_dcm_id(dcm_id).lock();
             let mut manager = client_state
                 .shmem_manager
                 .as_mut()
                 .expect("No shmem manager found for client");
-
-            // TODO(error): this is where things fail
-            log::warn!(
-                "About to allocate large page from shmem manager: free_large:{:?} free_base:{:?}",
-                manager.free_large_pages(),
-                manager.free_base_pages()
-            );
             let frame = manager
                 .allocate_large_page()
                 .expect("DCM OK'd allocation, this should succeed");
@@ -201,7 +186,7 @@ pub(crate) fn handle_get_shmem_frames(
     let additional_data = end - start;
     unsafe { encode(&regions, &mut &mut payload[start..end]) }
         .expect("Failed to encode shmem region vector");
-    log::warn!(
+    log::debug!(
         "Sending back {:?} bytes of data ({:?} frames)",
         additional_data,
         regions.len()