Skip to content

Commit b5964fd

Browse files
committed
Addressing comments: Enforce and clean up type hints
1 parent bf791db commit b5964fd

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

src/llmcompressor/metrics/logger.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,7 @@ def lambda_func(
223223

224224
def log_hyperparams(
225225
self,
226-
params: dict,
226+
params: dict[str, float],
227227
level: int | str | None = None,
228228
) -> bool:
229229
"""
@@ -931,7 +931,7 @@ def log_scalar(
931931
value: float,
932932
step: int | None = None,
933933
wall_time: float | None = None,
934-
log_types: str | list[str] | None = ALL_TOKEN,
934+
log_types: str | list[str] = ALL_TOKEN,
935935
level: int | str | None = None,
936936
):
937937
"""
@@ -962,7 +962,7 @@ def log_scalars(
962962
values: dict[str, float],
963963
step: int | None = None,
964964
wall_time: float | None = None,
965-
log_types: str | list[str] | None = ALL_TOKEN,
965+
log_types: str | list[str] = ALL_TOKEN,
966966
level: int | str | None = None,
967967
):
968968
"""
@@ -990,7 +990,7 @@ def log_scalars(
990990
def log_hyperparams(
991991
self,
992992
params: dict,
993-
log_types: str | list[str] | None = ALL_TOKEN,
993+
log_types: str | list[str] = ALL_TOKEN,
994994
level: int | str | None = None,
995995
):
996996
"""
@@ -1210,7 +1210,7 @@ class MetricLoggingWrapper(LoggingWrapperBase):
12101210

12111211
def log_hyperparams(
12121212
self,
1213-
params: dict,
1213+
params: dict[str, float],
12141214
log_types: str | list[str] = ALL_TOKEN,
12151215
level: int | str | None = None,
12161216
):

src/llmcompressor/metrics/utils/frequency_manager.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,7 @@ def log_ready(
256256
current_log_step: LogStepType | None,
257257
last_log_step: LogStepType | None,
258258
log_frequency: LogStepType | None,
259-
last_model_update_step: LogStepType | None = None,
259+
last_model_update_step: LogStepType = None,
260260
check_model_update: bool = False,
261261
):
262262
"""

0 commit comments

Comments
 (0)