Modernize metrics module with type hints and generic types (#1993)

SUMMARY:
This is part of
#1927

Modernize type annotations using | operator and built-in generics in the
metrics module as part of codebase modernization effort.

I also fixed typo for the function name `SystemLoggingWraper` ->
`SystemLoggingWrapper` as part of this PR.

TEST PLAN:
```
make style
make quality
make tests
```

Notes:
Happy to address any comments! Thank you!

---------

Co-authored-by: Brian Dellabetta <brian-dellabetta@users.noreply.github.com>

Author: sugatmahanti