feat: disable minify by default in development

Author: sapphi-red

packages/vite/src/node/__tests__/build.spec.ts

@@ -3,7 +3,7 @@ import { fileURLToPath } from 'node:url'
 import { stripVTControlCharacters } from 'node:util'
 import fsp from 'node:fs/promises'
 import colors from 'picocolors'
-import { afterEach, describe, expect, test, vi } from 'vitest'
+import { afterEach, describe, expect, onTestFinished, test, vi } from 'vitest'
 import type {
   LogLevel,
   OutputChunk,
@@ -809,6 +809,13 @@ test('default sharedConfigBuild true on build api', async () => {
 test.for([true, false])(
   'minify per environment (builder.sharedPlugins: %s)',
   async (sharedPlugins) => {
+    const _nodeEnv = process.env.NODE_ENV
+    // Overriding the NODE_ENV set by vitest
+    process.env.NODE_ENV = ''
+    onTestFinished(() => {
+      process.env.NODE_ENV = _nodeEnv
+    })
+
     const root = resolve(__dirname, 'fixtures/shared-plugins/minify')
     const builder = await createBuilder({
       root,

packages/vite/src/node/build.ts

@@ -402,6 +402,7 @@ export function resolveBuildEnvironmentOptions(
   raw: BuildEnvironmentOptions,
   logger: Logger,
   consumer: 'client' | 'server' | undefined,
+  isProduction: boolean,
 ): ResolvedBuildEnvironmentOptions {
   const deprecatedPolyfillModulePreload = raw.polyfillModulePreload
   const { polyfillModulePreload, ...rest } = raw
@@ -422,7 +423,7 @@ export function resolveBuildEnvironmentOptions(
     {
       ...buildEnvironmentOptionsDefaults,
       cssCodeSplit: !raw.lib,
-      minify: consumer === 'server' ? false : 'oxc',
+      minify: !isProduction || consumer === 'server' ? false : 'oxc',
       rollupOptions: {
         platform: consumer === 'server' ? 'node' : 'browser',
       },

packages/vite/src/node/config.ts

@@ -822,6 +822,7 @@ function resolveEnvironmentOptions(
   preserveSymlinks: boolean,
   forceOptimizeDeps: boolean | undefined,
   logger: Logger,
+  isProduction: boolean,
   environmentName: string,
   // Backward compatibility
   skipSsrTransform?: boolean,
@@ -887,6 +888,7 @@ function resolveEnvironmentOptions(
       options.build ?? {},
       logger,
       consumer,
+      isProduction,
     ),
     // will be set by `setOptimizeDepsPluginNames` later
     optimizeDepsPluginNames: undefined!,
@@ -1445,6 +1447,36 @@ export async function resolveConfig(
     config.ssr?.target === 'webworker',
   )
 
+  // load .env files
+  // Backward compatibility: set envDir to false when envFile is false
+  let envDir = config.envFile === false ? false : config.envDir
+  if (envDir !== false) {
+    envDir = config.envDir
+      ? normalizePath(path.resolve(resolvedRoot, config.envDir))
+      : resolvedRoot
+  }
+
+  const userEnv = loadEnv(mode, envDir, resolveEnvPrefix(config))
+
+  // Note it is possible for user to have a custom mode, e.g. `staging` where
+  // development-like behavior is expected. This is indicated by NODE_ENV=development
+  // loaded from `.staging.env` and set by us as VITE_USER_NODE_ENV
+  const userNodeEnv = process.env.VITE_USER_NODE_ENV
+  if (!isNodeEnvSet && userNodeEnv) {
+    if (userNodeEnv === 'development') {
+      process.env.NODE_ENV = 'development'
+    } else {
+      // NODE_ENV=production is not supported as it could break HMR in dev for frameworks like Vue
+      logger.warn(
+        `NODE_ENV=${userNodeEnv} is not supported in the .env file. ` +
+          `Only NODE_ENV=development is supported to create a development build of your project. ` +
+          `If you need to set process.env.NODE_ENV, you can set it in the Vite config instead.`,
+      )
+    }
+  }
+
+  const isProduction = process.env.NODE_ENV === 'production'
+
   // Backward compatibility: merge config.environments.client.resolve back into config.resolve
   config.resolve ??= {}
   config.resolve.conditions = config.environments.client.resolve?.conditions
@@ -1460,6 +1492,7 @@ export async function resolveConfig(
       resolvedDefaultResolve.preserveSymlinks,
       inlineConfig.forceOptimizeDeps,
       logger,
+      isProduction,
       environmentName,
       config.experimental?.skipSsrTransform,
       config.ssr?.target === 'webworker',
@@ -1485,6 +1518,7 @@ export async function resolveConfig(
     config.build ?? {},
     logger,
     undefined,
+    isProduction,
   )
 
   // Backward compatibility: merge config.environments.ssr back into config.ssr
@@ -1505,36 +1539,6 @@ export async function resolveConfig(
     resolvedDefaultResolve.preserveSymlinks,
   )
 
-  // load .env files
-  // Backward compatibility: set envDir to false when envFile is false
-  let envDir = config.envFile === false ? false : config.envDir
-  if (envDir !== false) {
-    envDir = config.envDir
-      ? normalizePath(path.resolve(resolvedRoot, config.envDir))
-      : resolvedRoot
-  }
-
-  const userEnv = loadEnv(mode, envDir, resolveEnvPrefix(config))
-
-  // Note it is possible for user to have a custom mode, e.g. `staging` where
-  // development-like behavior is expected. This is indicated by NODE_ENV=development
-  // loaded from `.staging.env` and set by us as VITE_USER_NODE_ENV
-  const userNodeEnv = process.env.VITE_USER_NODE_ENV
-  if (!isNodeEnvSet && userNodeEnv) {
-    if (userNodeEnv === 'development') {
-      process.env.NODE_ENV = 'development'
-    } else {
-      // NODE_ENV=production is not supported as it could break HMR in dev for frameworks like Vue
-      logger.warn(
-        `NODE_ENV=${userNodeEnv} is not supported in the .env file. ` +
-          `Only NODE_ENV=development is supported to create a development build of your project. ` +
-          `If you need to set process.env.NODE_ENV, you can set it in the Vite config instead.`,
-      )
-    }
-  }
-
-  const isProduction = process.env.NODE_ENV === 'production'
-
   // resolve public base url
   const relativeBaseShortcut = config.base === '' || config.base === './'