chore: skip sideeffects set for HTML scripts for now

Author: sapphi-red

packages/vite/src/node/plugins/html.ts

@@ -488,24 +488,25 @@ export function buildHtmlPlugin(config: ResolvedConfig): RolldownPlugin {
                 if (isModule) {
                   inlineModuleIndex++
                   if (url && !isExcludedUrl(url) && !isPublicFile) {
-                    setModuleSideEffectPromises.push(
-                      this.resolve(url, id).then((resolved) => {
-                        if (!resolved) {
-                          return Promise.reject(
-                            new Error(`Failed to resolve ${url} from ${id}`),
-                          )
-                        }
-                        // set moduleSideEffects to keep the module even if `treeshake.moduleSideEffects=false` is set
-                        const moduleInfo = this.getModuleInfo(resolved.id)
-                        if (moduleInfo) {
-                          moduleInfo.moduleSideEffects = true
-                        } else if (!resolved.external) {
-                          return this.load(resolved).then((mod) => {
-                            mod.moduleSideEffects = true
-                          })
-                        }
-                      }),
-                    )
+                    // FIXME: rolldown does not support `this.load`: https://github.com/rolldown/rolldown/issues/2355
+                    // setModuleSideEffectPromises.push(
+                    //   this.resolve(url, id).then((resolved) => {
+                    //     if (!resolved) {
+                    //       return Promise.reject(
+                    //         new Error(`Failed to resolve ${url} from ${id}`),
+                    //       )
+                    //     }
+                    //     // set moduleSideEffects to keep the module even if `treeshake.moduleSideEffects=false` is set
+                    //     const moduleInfo = this.getModuleInfo(resolved.id)
+                    //     if (moduleInfo) {
+                    //       moduleInfo.moduleSideEffects = true
+                    //     } else if (!resolved.external) {
+                    //       return this.load(resolved).then((mod) => {
+                    //         mod.moduleSideEffects = true
+                    //       })
+                    //     }
+                    //   }),
+                    // )
                     // <script type="module" src="..."/>
                     // add it as an import
                     js += `\nimport ${JSON.stringify(url)}`

playground/html/__tests__/html.spec.ts

@@ -398,7 +398,7 @@ describe('side-effects', () => {
     await page.goto(viteTestUrl + '/side-effects/')
   })
 
-  test('console.log is not tree-shaken', async () => {
+  test.skip('console.log is not tree-shaken', async () => {
     expect(browserLogs).toContain('message from sideEffects script')
   })
 })