fix: issues resolved with tests for options bar

Author: vip-git

src/client/shared/services/core/http.service.ts

@@ -101,7 +101,7 @@ export class HttpService {
 			if (!lastAccessToken) {
 				return 'Refresh API call failed';
 			}
-			const URL = returnValidURL('api', '/auth/refresh?lastToken=' + lastAccessToken + '&githubId=' + githubUserData.login);
+			const URL = returnValidURL('api', '/auth/refresh?lastToken=' + lastAccessToken + '&githubId=' +  githubUserData?.login);
 			const options: any = {
 				method: 'GET',
 			};

src/client/web/app/common/components/chat-box/index.tsx

@@ -207,7 +207,7 @@ class Chat extends Component<IChatProps, IChatState> {
 													ownerId: githubUserData.id,
 													memberId: contact.githubUid,
 													groupName: `${githubUserData.name ||
-														githubUserData.login} (${
+														 githubUserData?.login} (${
 														githubUserData.realId
 													}) - ${contact.name || contact.githubId} (${
 														contact.id
@@ -294,7 +294,7 @@ class Chat extends Component<IChatProps, IChatState> {
 			githubUserData.name && githubUserData.name.indexOf(' ') === -1
 				? githubUserData.name
 				: (githubUserData.name && githubUserData.name.split(' ')[0]) ||
-				  githubUserData.login;
+				   githubUserData?.login;
 		const oppositeAvatarUrl = groupType === 'personal'
 			? member.avatarUrl
 			: groupImage;

src/client/web/app/common/components/options-bar/__tests__/options-bar-component.spec.tsx

@@ -8,6 +8,7 @@ import theme from '../../../styles';
 
 // Web
 import OptionsBarComponent from '../index';
+import { act } from '@testing-library/react-hooks';
 
 describe('OptionsBarComponent <OptionsBar />', () => {
 	it('OptionsBar Component renders correctly', () => {
@@ -46,6 +47,11 @@ describe('OptionsBarComponent <OptionsBar />', () => {
 			</ThemeProvider>
 		);
 
+		act(() => {
+			(optionsBarComponent.find('WithStyles(ForwardRef(Menu))').props() as any).onClose(() => {});
+			(optionsBarComponent.find('WithStyles(ForwardRef(MenuItem))').first().props() as any).onClick(() => {});
+		})
+
 		expect(optionsBarComponent.length).toBeTruthy();
 	});
 });

src/client/web/app/containers/chat/__tests__/chat-container.spec.tsx

@@ -1,3 +1,4 @@
+// Library
 import React from 'react';
 import { ApolloProvider } from 'react-apollo';
 import { createMockClient } from 'mock-apollo-client';
@@ -14,6 +15,7 @@ import ChatContainer from '@omega-web-containers/chat';
 // Redux Model
 import { ChatReduxModel } from '@omega-state-machines/chat/chat.redux-model';
 import theme from '../../../common/styles';
+import { act } from '@testing-library/react-hooks';
 
 interface IState {
 	chats: {
@@ -98,6 +100,15 @@ describe('container <ChatContainer />', () => {
 			'groupData'
 		];
 
+		act(() => {
+			component.props().onSelectGroup();
+			component.props().onSelectContact();
+			component.props().submitCreateGroup();
+			component.props().readUsersAndChat();
+			component.props().SharedComponent();
+			component.props().submitChat();
+		});
+
 		expect(Object.keys(component.props())).toEqual(
 			expect.arrayContaining(expectedPropKeys)
 		);

src/client/web/app/containers/chat/index.tsx

@@ -42,10 +42,10 @@ class ChatContainer extends Component<any, any> {
 							submitChat={(payload: ICreateChatPayload) =>
 								dispatchCreateChat({
 									apolloClient,
-									data: payload.variables,
+									data: payload?.variables,
 									callBack: () => payload.callBack()
 								})}
-							onSelectContact={(groupId: Number) =>
+							onSelectContact={(groupId: number) =>
 								dispatchReadAllUsersAndChats({
 									apolloClient,
 									data: {
@@ -68,14 +68,14 @@ class ChatContainer extends Component<any, any> {
 										profilePayload: {
 											filters: {
 												not: {
-													githubId: githubUserData.login
+													githubId: githubUserData?.login
 												}
 											}
 										}
 									},
 									idToken
 								})}
-							onSelectGroup={(groupId: Number) =>
+							onSelectGroup={(groupId: number) =>
 								dispatchReadAllUsersAndChats({
 									apolloClient,
 									data: {
@@ -98,7 +98,7 @@ class ChatContainer extends Component<any, any> {
 										profilePayload: {
 											filters: {
 												not: {
-													githubId: githubUserData.login
+													githubId:  githubUserData?.login
 												}
 											}
 										}
@@ -128,7 +128,7 @@ class ChatContainer extends Component<any, any> {
 										profilePayload: {
 											filters: {
 												not: {
-													githubId: githubUserData.login
+													githubId: githubUserData?.login
 												}
 											}
 										}
@@ -138,7 +138,7 @@ class ChatContainer extends Component<any, any> {
 							submitCreateGroup={(payload: ICreateGroupPayload) =>
 								dispatchCreateGroup({
 									apolloClient,
-									data: payload.variables,
+									data: payload?.variables,
 									callBack: id => payload.callBack(id)
 								})}
 							githubUserData={githubUserData}