chore: run linters

Author: vimtor

.github/renovate.json

@@ -1,4 +1,4 @@
-{
-  "extends": ["config:base"],
-  "schedule": ["every month"]
-}
+{
+  "extends": ["config:base"],
+  "schedule": ["every month"]
+}

.github/workflows/ci.yml

@@ -1,6 +1,5 @@
 name: CI
-on:
-  push
+on: push
 
 jobs:
   ci:
@@ -20,6 +19,10 @@ jobs:
         if: ${{ matrix.node == 'with-node' }}
       - name: Install Dependencies
         run: yarn install
+      - name: Run Linters
+        run: yarn lint
+      - name: Format Check
+        run: yarn format
       - name: Build Package
         run: yarn build
       - name: Run Action

.prettierignore

@@ -0,0 +1 @@
+dist

README.md

@@ -10,7 +10,8 @@
 
 ## 🧠 Why
 
-There is an excellent action already: [firebase-action](https://github.com/w9jds/firebase-action), but it forces you to run a command in order to work.
+There is an excellent action already: [firebase-action](https://github.com/w9jds/firebase-action), but it forces you to
+run a command in order to work.
 
 With this one, after running the action you can use the firebase-tools CLI from anywhere: npm script, shell...
 
@@ -30,17 +31,16 @@ jobs:
           firebase-token: YOUR_TOKEN
 ```
 
-By default, it will try to download the package from npm,
-if it fails because npm is not installed, or it doesn't have sufficient permissions,
-the action will fallback to download it using `curl`.
+By default, it will try to download the package from npm, if it fails because npm is not installed, or it doesn't have
+sufficient permissions, the action will fallback to download it using `curl`.
 
 If you are running it on Windows you will need to use actions/setup-node before in order to work.
 
 ## ⚙ Inputs
 
-**Name**|**Description**|**Required**
------|-----|-----
-firebase-token|Firebase token you can get by running `firebase login:ci`|✔
+| **Name**       | **Description**                                           | **Required** |
+| -------------- | --------------------------------------------------------- | ------------ |
+| firebase-token | Firebase token you can get by running `firebase login:ci` | ✔            |
 
 ## 👋 Support
 

package.json

@@ -5,8 +5,10 @@
   "main": "lib/main.js",
   "scripts": {
     "build": "tsc && yarn run package",
-    "lint": "eslint src --ext .tsx,.js,.ts",
-    "lint:fix": "yarn lint --fix",
+    "lint": "eslint . --ext ts,tsx",
+    "lint:fix": "eslint . --ext ts,tsx --fix",
+    "format": "prettier --check .",
+    "format:fix": "prettier --write .",
     "package": "ncc build --source-map --license licenses.txt",
     "test": "jest"
   },
@@ -28,33 +30,20 @@
     "command-exists": "^1.2.9"
   },
   "devDependencies": {
-    "@pocket-studios/eslint-config": "1.1.0",
+    "@pocket-studios/eslint-config": "2.1.3",
+    "@pocket-studios/prettier-config": "1.0.0",
     "@types/command-exists": "1.2.0",
     "@types/jest": "26.0.13",
     "@types/node": "14.6.2",
-    "@typescript-eslint/eslint-plugin": "3.6.1",
-    "@typescript-eslint/parser": "3.7.1",
     "@vercel/ncc": "0.24.0",
-    "eslint": "6.8.0",
-    "eslint-config-airbnb": "18.2.0",
-    "eslint-plugin-cypress": "2.11.1",
-    "eslint-plugin-import": "2.22.0",
-    "eslint-plugin-jest": "23.20.0",
-    "eslint-plugin-jsx-a11y": "6.3.1",
-    "eslint-plugin-react": "7.20.0",
-    "eslint-plugin-react-hooks": "4.0.0",
-    "eslint-plugin-unused-imports": "0.1.3",
+    "eslint": "7.2.0",
+    "prettier": "2.1.2",
     "husky": "4.2.5",
     "jest": "26.4.2",
     "lint-staged": "10.2.13",
     "ts-jest": "26.3.0",
     "typescript": "4.0.2"
   },
-  "eslintConfig": {
-    "extends": [
-      "@pocket-studios/eslint-config"
-    ]
-  },
   "jest": {
     "testMatch": [
       "<rootDir>/tests/**/*.ts"
@@ -69,13 +58,21 @@
   },
   "husky": {
     "hooks": {
-      "pre-push": "lint-staged"
+      "pre-commit": "lint-staged"
     }
   },
   "lint-staged": {
-    "*.{ts,js,tsx}": [
-      "yarn lint:fix",
-      "yarn lint"
+    "*.(js|ts|tsx)": [
+      "eslint --fix"
+    ],
+    "*.+(js|jsx|json|yml|yaml|css|less|scss|ts|tsx|md|graphql|mdx)": [
+      "prettier --write"
     ]
-  }
-}
+  },
+  "eslintConfig": {
+    "extends": [
+      "@pocket-studios/eslint-config"
+    ]
+  },
+  "prettier": "@pocket-studios/prettier-config"
+}

src/main.ts

@@ -1,39 +1,39 @@
-import { execSync } from 'child_process';
-import * as core from '@actions/core';
-import commandExists from 'command-exists';
+import { execSync } from 'child_process'
+import * as core from '@actions/core'
+import commandExists from 'command-exists'
 
-const installNpm = () => execSync('npm install -g firebase-tools');
-const installBash = () => execSync('curl -sL https://firebase.tools | bash');
+const installNpm = () => execSync('npm install -g firebase-tools')
+const installBash = () => execSync('curl -sL https://firebase.tools | bash')
 
 const run = async () => {
-  const token = core.getInput('firebase-token');
-  const os = process.env.RUNNER_OS;
+  const token = core.getInput('firebase-token')
+  const os = process.env.RUNNER_OS
 
   if (!token) {
-    throw new Error('Missing mandatory input: firebase-token');
+    throw new Error('Missing mandatory input: firebase-token')
   }
 
-  core.exportVariable('FIREBASE_TOKEN', token);
-  core.info('Exported environment variable FIREBASE_TOKEN');
+  core.exportVariable('FIREBASE_TOKEN', token)
+  core.info('Exported environment variable FIREBASE_TOKEN')
 
   if (await commandExists('npm')) {
-    core.info('Detected NPM installation');
+    core.info('Detected NPM installation')
     try {
-      core.info('Trying to install firebase-tools using NPM');
-      installNpm();
+      core.info('Trying to install firebase-tools using NPM')
+      installNpm()
     } catch (e) {
-      core.info('Installation failed through NPM (maybe you forgot actions/setup-node before this action)');
-      core.info('Trying BASH instead');
-      installBash();
+      core.info('Installation failed through NPM (maybe you forgot actions/setup-node before this action)')
+      core.info('Trying BASH instead')
+      installBash()
     }
   } else if (os === 'Linux' || os === 'macOS') {
-    core.info('Trying to install firebase-tools using BASH');
-    installBash();
+    core.info('Trying to install firebase-tools using BASH')
+    installBash()
   } else if (os === 'Windows') {
-    throw new Error('On windows you must setup node before running this action');
+    throw new Error('On windows you must setup node before running this action')
   }
-};
+}
 
 run()
   .then(() => core.info('Successfully installed firebase-tools CLI'))
-  .catch(error => core.setFailed(error.message));
+  .catch(error => core.setFailed(error.message))

tests/enviroment.ts

@@ -1,13 +1,13 @@
-import commandExists from 'command-exists';
+import commandExists from 'command-exists'
 
 test('environment variable was set correctly', () => {
-  const token = process.env.FIREBASE_TOKEN;
+  const token = process.env.FIREBASE_TOKEN
 
-  expect(token).not.toBeUndefined();
-  expect(token).not.toBeNull();
-  expect(token).toBe('banana');
-});
+  expect(token).not.toBeUndefined()
+  expect(token).not.toBeNull()
+  expect(token).toBe('banana')
+})
 
 test('firebase tools cli is installed', async () => {
-  expect(await commandExists('firebase')).toBe('firebase');
-});
+  expect(await commandExists('firebase')).toBe('firebase')
+})