Merge pull request #50 from tomphp/feature/29

Add test for issue #29

Author: Gianluca Arbezzano

.gitignore

@@ -1,4 +1,4 @@
-tests/.test_fs
+.test_fs
 build/
 vendor/
 phpctags

PHPCtags.class.php

@@ -385,7 +385,7 @@ private function process($file)
     {
         if (is_dir($file) && isset($this->mOptions['R'])) {
             $iterator = new RecursiveIteratorIterator(
-                new RecursiveDirectoryIterator(
+                new ReadableRecursiveDirectoryIterator(
                     $file,
                     FilesystemIterator::SKIP_DOTS |
                     FilesystemIterator::FOLLOW_SYMLINKS
@@ -432,3 +432,14 @@ public function __toString() {
         return "PHPCtags: {$this->message}\n";
     }
 }
+
+class ReadableRecursiveDirectoryIterator extends RecursiveDirectoryIterator {
+    function getChildren() {
+        try {
+            return new ReadableRecursiveDirectoryIterator($this->getPathname());
+        } catch(UnexpectedValueException $e) {
+            file_put_contents('php://stderr', "\nPHPPCtags: {$e->getMessage()} - {$this->getPathname()}\n");
+            return new RecursiveArrayIterator(array());
+        }
+    }
+}

tests/Acceptance/AcceptanceTestCase.php

@@ -33,7 +33,7 @@ abstract class AcceptanceTestCase extends PHPUnit_Framework_TestCase
 
     protected function setUp()
     {
-        $this->testDir = __DIR__ . '/../.test_fs';
+        $this->testDir = __DIR__ . '/../../.test_fs';
 
         if (!file_exists($this->testDir)) {
             mkdir($this->testDir);
@@ -57,6 +57,20 @@ protected function givenSourceFile($filename, $content)
         file_put_contents($filename, $content);
     }
 
+    protected function givenDirectory($dirname)
+    {
+        $dirname = $this->testDir . DIRECTORY_SEPARATOR . $dirname;
+
+        mkdir($dirname);
+    }
+
+    protected function givenMode($file, $mode)
+    {
+        $file = $this->testDir . DIRECTORY_SEPARATOR . $file;
+
+        chmod($file, $mode);
+    }
+
     /**
      * @return void
      */
@@ -177,6 +191,10 @@ private function emptyTestDir()
             throw \RuntimeException('Test directory does not exist');
         }
 
+        foreach (glob($this->testDir . DIRECTORY_SEPARATOR . '*') as $file) {
+            chmod($file, 0755);
+        }
+
         $files = new RecursiveIteratorIterator(
             new RecursiveDirectoryIterator(
                 $this->testDir,

tests/Acceptance/FilesystemTest.php

@@ -0,0 +1,28 @@
+<?php
+
+namespace tests\PHPCTags\Acceptance;
+
+final class FilesystemTest extends AcceptanceTestCase
+{
+    /**
+     * @test
+     */
+    public function itSkipsUnreadableDirectories()
+    {
+        $this->givenDirectory('unreadable');
+        $this->givenSourceFile('unreadable/UnreadableClass.php', <<<EOS
+<?php
+
+class UnreadableClass
+{
+}
+EOS
+        );
+        $this->givenMode('unreadable', 0000);
+
+        $this->runPHPCtags();
+        $this->assertTagsFileHeaderIsCorrect();
+
+        $this->assertTagsFileContainsNoTagsFromFile('unreadable/UnreadableClass.php');
+    }
+}