Skip to content
This repository was archived by the owner on Mar 30, 2020. It is now read-only.

Commit 4502590

Browse files
chore: bump major version to indicate compatibility with generator v4
1 parent afb35ef commit 4502590

File tree

4 files changed

+19
-13
lines changed

4 files changed

+19
-13
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
55
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
66

77
## [Unreleased]
8+
- No changes, just bumping of major version to indicate compatibility with `jsonschema-generator` version 4.*
89

910
## [3.2.0] – 2019-09-01
1011
### Added

README.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,14 @@ Schema attributes derived from validation annotations on getter methods are also
2323
<dependency>
2424
<groupId>com.github.victools</groupId>
2525
<artifactId>jsonschema-module-javax-validation</artifactId>
26-
<version>3.2.0</version>
26+
<version>4.0.0</version>
2727
</dependency>
2828
```
2929

30+
### Compatibility
31+
Please note that while the minor versions may differ, it is recommended to use matching major versions of the `jsonschema-generator` and this module.
32+
However, version 3.* of this module is also compatible with `jsonschema-generator` version 4.* (as no relevant features were removed/broken).
33+
3034
### Code
3135
#### Passing into SchemaGeneratorConfigBuilder.with(Module)
3236
```java

pom.xml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
<groupId>com.github.victools</groupId>
1010
<artifactId>jsonschema-module-javax-validation</artifactId>
11-
<version>3.3.0-SNAPSHOT</version>
11+
<version>4.0.0-SNAPSHOT</version>
1212
<packaging>jar</packaging>
1313

1414
<licenses>
@@ -58,9 +58,10 @@
5858
<maven.compiler.source>1.8</maven.compiler.source>
5959
<maven.compiler.target>1.8</maven.compiler.target>
6060

61-
<version.generator>3.4.1</version.generator>
61+
<version.generator>4.0.0</version.generator>
6262

6363
<version.javax.validation>2.0.1.Final</version.javax.validation>
64+
6465
<version.jsonassert>1.5.0</version.jsonassert>
6566
<version.junit>4.12</version.junit>
6667
<version.junitparams>1.1.1</version.junitparams>

src/test/java/com/github/victools/jsonschema/module/javax/validation/IntegrationTest.java

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -86,32 +86,32 @@ private static String loadResource(String resourcePath) throws IOException {
8686
static class TestClass {
8787

8888
@Null
89-
Object nullObject;
89+
public Object nullObject;
9090

9191
@NotNull
92-
List<String> notNullList;
92+
public List<String> notNullList;
9393
@NotEmpty
94-
List<String> notEmptyList;
94+
public List<String> notEmptyList;
9595
@Size(min = 3, max = 25)
96-
List<String> sizeRangeList;
96+
public List<String> sizeRangeList;
9797

9898
@NotNull
9999
@Email(regexp = ".+@.+\\..+")
100-
String notNullEmail;
100+
public String notNullEmail;
101101
@NotEmpty
102102
@Pattern(regexp = "\\w+")
103-
String notEmptyPatternText;
103+
public String notEmptyPatternText;
104104
@NotBlank
105-
String notBlankText;
105+
public String notBlankText;
106106
@Size(min = 5, max = 12)
107-
String sizeRangeText;
107+
public String sizeRangeText;
108108

109109
@Min(7)
110110
@Max(38)
111-
int inclusiveRangeInt;
111+
public int inclusiveRangeInt;
112112

113113
@DecimalMin(value = "0", inclusive = false)
114114
@DecimalMax(value = "1", inclusive = false)
115-
double exclusiveRangeDouble;
115+
public double exclusiveRangeDouble;
116116
}
117117
}

0 commit comments

Comments
 (0)