fix a name

Author: lukesandberg

crates/next-core/src/next_client_reference/ecmascript_client_reference/ecmascript_client_reference_module.rs

@@ -244,7 +244,7 @@ impl Module for EcmascriptClientReferenceModule {
     #[turbo_tasks::function]
     fn side_effects(self: Vc<Self>) -> Vc<ModuleSideEffects> {
         // These just export some specially tagged functions
-        ModuleSideEffects::DeclaredSideEffectFree.cell()
+        ModuleSideEffects::SideEffectFree.cell()
     }
 }
 

crates/next-core/src/raw_ecmascript_module.rs

@@ -101,7 +101,7 @@ impl Module for RawEcmascriptModule {
     #[turbo_tasks::function]
     fn side_effects(self: Vc<Self>) -> Vc<ModuleSideEffects> {
         // Is this correct?
-        ModuleSideEffects::DeclaredSideEffectFree.cell()
+        ModuleSideEffects::SideEffectFree.cell()
     }
 }
 

turbopack/crates/turbopack-core/src/module.rs

@@ -10,7 +10,7 @@ pub enum StyleType {
     GlobalStyle,
 }
 
-#[derive(Hash, Debug)]
+#[derive(Hash, Debug, Copy, Clone)]
 #[turbo_tasks::value(shared)]
 pub enum ModuleSideEffects {
     /// Analysis determined that the module evaluation is side effect free

turbopack/crates/turbopack-core/src/module_graph/side_effect_module_info.rs

@@ -48,7 +48,7 @@ async fn compute_side_effect_free_module_info_single(
                 super::SingleModuleGraphNode::VisitedModule { idx: _, module } => (
                     *module,
                     if parent_side_effect_free_modules.contains(module) {
-                        ModuleSideEffects::DeclaredSideEffectFree
+                        ModuleSideEffects::SideEffectFree
                     } else {
                         ModuleSideEffects::SideEffectful
                     },
@@ -80,8 +80,7 @@ async fn compute_side_effect_free_module_info_single(
         |child, _parent, _s| {
             Ok(if let Some((child_module, _edge)) = child {
                 match module_side_effects.get(&child_module).unwrap() {
-                    ModuleSideEffects::SideEffectful
-                    | ModuleSideEffects::DeclaredSideEffectFree => {
+                    ModuleSideEffects::SideEffectful | ModuleSideEffects::SideEffectFree => {
                         // We have either already seen this or don't want to follow it
                         GraphTraversalAction::Exclude
                     }
@@ -104,7 +103,7 @@ async fn compute_side_effect_free_module_info_single(
         .into_iter()
         .filter_map(|(m, e)| match e {
             ModuleSideEffects::SideEffectful => None,
-            ModuleSideEffects::DeclaredSideEffectFree => Some(m),
+            ModuleSideEffects::SideEffectFree => Some(m),
             ModuleSideEffects::ModuleEvaluationIsSideEffectFree => {
                 if locally_side_effect_free_modules_that_have_side_effects.contains(&m) {
                     None

turbopack/crates/turbopack-ecmascript/src/async_chunk/module.rs

@@ -68,7 +68,7 @@ impl Module for AsyncLoaderModule {
 
     #[turbo_tasks::function]
     fn side_effects(self: Vc<Self>) -> Vc<ModuleSideEffects> {
-        ModuleSideEffects::DeclaredSideEffectFree.cell()
+        ModuleSideEffects::SideEffectFree.cell()
     }
 }
 

turbopack/crates/turbopack-ecmascript/src/inlined_bytes_module.rs

@@ -52,7 +52,7 @@ impl Module for InlinedBytesJsModule {
 
     #[turbo_tasks::function]
     fn side_effects(self: Vc<Self>) -> Vc<ModuleSideEffects> {
-        ModuleSideEffects::DeclaredSideEffectFree.cell()
+        ModuleSideEffects::SideEffectFree.cell()
     }
 }
 

turbopack/crates/turbopack-ecmascript/src/manifest/chunk_asset.rs

@@ -154,7 +154,7 @@ impl Module for ManifestAsyncModule {
 
     #[turbo_tasks::function]
     fn side_effects(self: Vc<Self>) -> Vc<ModuleSideEffects> {
-        ModuleSideEffects::DeclaredSideEffectFree.cell()
+        ModuleSideEffects::SideEffectFree.cell()
     }
 }
 

turbopack/crates/turbopack-ecmascript/src/references/esm/base.rs

@@ -419,7 +419,7 @@ impl ModuleReference for EsmAssetReference {
 
         if let Some(TreeShakingMode::ModuleFragments) = self.tree_shaking_mode {
             if let Some(ModulePart::Evaluation) = &self.export_name {
-                if *self.module.side_effects().await? == ModuleSideEffects::DeclaredSideEffectFree {
+                if *self.module.side_effects().await? == ModuleSideEffects::SideEffectFree {
                     return Ok(ModuleResolveResult {
                         primary: Box::new([(
                             RequestKey::default(),

turbopack/crates/turbopack-ecmascript/src/references/esm/export.rs

@@ -170,7 +170,7 @@ pub async fn follow_reexports(
         };
 
         if !ignore_side_effects
-            && *module.side_effects().await? != ModuleSideEffects::DeclaredSideEffectFree
+            && *module.side_effects().await? != ModuleSideEffects::SideEffectFree
         {
             // TODO It's unfortunate that we have to use the whole module here.
             // This is often the Facade module, which includes all reexports.

turbopack/crates/turbopack-ecmascript/src/references/require_context.rs

@@ -429,7 +429,7 @@ impl Module for RequireContextAsset {
 
     #[turbo_tasks::function]
     fn side_effects(self: Vc<Self>) -> Vc<ModuleSideEffects> {
-        ModuleSideEffects::DeclaredSideEffectFree.cell()
+        ModuleSideEffects::SideEffectFree.cell()
     }
 }